Date:   Tue, 31 Jan 2023 10:48:22 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Anthony Krowiak <akrowiak@linux.ibm.com>
Cc:     Yi Liu <yi.l.liu@intel.com>, alex.williamson@redhat.com,
        pbonzini@redhat.com, mjrosato@linux.ibm.com, kevin.tian@intel.com,
        cohuck@redhat.com, farman@linux.ibm.com, pmorel@linux.ibm.com,
        borntraeger@linux.ibm.com, frankja@linux.ibm.com,
        imbrenda@linux.ibm.com, david@redhat.com, jjherne@linux.ibm.com,
        pasic@linux.ibm.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
        seanjc@google.com, linux-s390@vger.kernel.org, kvm@vger.kernel.org,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm/vfio: Fix potential deadlock on vfio group_lock
Message-ID: <Y9kqNnJ5ayCQSW9z@nvidia.com>
References: <20230120150528.471752-1-yi.l.liu@intel.com>
 <67ec09bf-cb24-34e3-6ec4-1ae87b0738bd@linux.ibm.com>
 <Y9km+xezgD4ovjDX@nvidia.com>
 <b0ed98f6-3586-3151-47e7-9ec86d6c716d@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b0ed98f6-3586-3151-47e7-9ec86d6c716d@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aaJ+yuE7lb2TKu39cnydeyH1VSsYxEp1Ow+PDPbltzcoG+1fJdwtQklTLTLi?=
 =?us-ascii?Q?hj7kTZZDIeSwCqtbwsedbmcUvnCxUDDxRv/CNyLcJOEHXiM/faYy4FbysI1A?=
 =?us-ascii?Q?tTNEv5OGKssvobduBY+c+HDlQSjxJ/jdAKKB6knlGV+lzFqvcpScW72g9fCx?=
 =?us-ascii?Q?9ROLzdXqaFDr3VL0GYGT1sNCSPMre4fIcZsynB+5vxzkEiaVk9xo2edsYX64?=
 =?us-ascii?Q?auRpOXGl5HZqqkuccmfrmk2cEEn0qNSRL6fkmr0lErDYazcSN0cKQYOxiSTx?=
 =?us-ascii?Q?WrP7hpzdNCvJwL1cm+R5P1M8UhTj+7S0bkkXOmnnZzLX0MV++5j+Qu+OwEbt?=
 =?us-ascii?Q?+H7TtlomJ8hBX714d3yoDr/AlpWaMCZXD9I4tvu0zfWoSsWFU8O9Jcw1lJ3n?=
 =?us-ascii?Q?zfpJABL4K4Ts9MEJE4BID6ToAhqIpKxB2k5uv9pwuYotpnKSAb5ZsYYaUkQy?=
 =?us-ascii?Q?tc3pnAQvRLDojy3Qo6pQM4s35yqAJrHqSBEw03Y4W1SMGMWGA3fmR93IrM/a?=
 =?us-ascii?Q?1aHsTwa3/cefPudiGsLDP3KpgRxb88bsNEk1ByaTnZxvdRlgYqyRVIv09XGd?=
 =?us-ascii?Q?h69uooU6EXYwHSikLpcrD7yU0FWHl4+j1SPMg0HD4JGnjA2DYuDSdh9pFZCZ?=
 =?us-ascii?Q?Y08lRMIzGLrGEwZfrrnLZWrZY2lzNCRwlkSsYdvR+s1rPuZjL7w/OXXvj3rJ?=
 =?us-ascii?Q?uaUuoS3W80fh/LXQwmTHTIOSmT/J6gwMYzku9HlAcTZIhLax+eaVxr2L/Bvs?=
 =?us-ascii?Q?CXm3lk6LZBKANAVms/BDKE0YeC0gidDfFMjVXlQbpt/gh0+32sQKBtjJqHW1?=
 =?us-ascii?Q?Iyz3ukLhVEf7O+fEjzvOzP9G4oLFlDQAHdzZ+rVibRlAEhsZENPfmBoyfmh/?=
 =?us-ascii?Q?HyVW9I8noz80ojlEXN5tAdoiNSIkdUYbc8Ly5RNME1yKkB5R0DBEeMDw331K?=
 =?us-ascii?Q?JlYLYRS43x/cTm7gA9Cxa5hyIztveS5+Xc4vIz3JaTKSDuQDAXfIGoZShxZe?=
 =?us-ascii?Q?m4sQDMxNWdk9W/rtOQ7fsVXNdNoHwe2q9sVoT3zxOMRSJyFUvNkujIIzic3I?=
 =?us-ascii?Q?7jinJ9K5xPGcO3Bn0zcZrJBlklG+R3zIsUvwHgZtWsLk2YaeQZHBuICRuTLp?=
 =?us-ascii?Q?KrLLaWzKYZcO1SjYF52Nt+OSpDagNEDUBzE3D91FKJNit52WQ6I0O/J8g2Ym?=
 =?us-ascii?Q?wsaYx6cDxn6+wux97srWb2dgGiNtGt5U2ScPGuADY/ox7PCysLF08vtiboJb?=
 =?us-ascii?Q?Awg1oX0HjpGYGFB0vvuUT1sIzNciQkDHlj3WgAqzGJ0bEX+iztI5feo+8suC?=
 =?us-ascii?Q?zfvQCr2vXoURH7pHTkyKzXU/+gcDPT/kcM2ObczDA9Scpn1494oQHkh+byTS?=
 =?us-ascii?Q?//2LOfL9GcHmx2lMWJQ2NX44667+kuwUyUz11kwoVdqm9iWndmKRa5T9S7Mj?=
 =?us-ascii?Q?jaHNyvfYxVqgJCMRwWY01VDQKa7rIGKa3XlbQzxZ3XB71TyYf56+utTn9j1g?=
 =?us-ascii?Q?HqCBFP8CrRWHtx4faOO8TonDRKuP3eZm2BrgpX+Aeqp4rhs2PZziW5n9Wckh?=
 =?us-ascii?Q?5+R3K3+UuSxPNqgmHYU7Ti8KwGrV72Q6ZQ4m0hGh?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df1f9077-ae53-4a12-9ced-08db039a34ec
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 14:48:25.3325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hj5u4RRp6+j3pwhcXTDVht5SminWHog1xP07sTKODYwtHnJhhcFhBQek+rAwcjZH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5163
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 31, 2023 at 09:46:18AM -0500, Anthony Krowiak wrote:

> > Maybe you should split that lock and have a dedicated apcb lock?
> 
> I don't think that would suffice for taking the vCPUs out of SIE.

Then I think we have to keep this patch and also do Matthew's patch to
keep kvm refs inside vfio as well.

Jason