From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     Marcel Ziswiler <marcel@ziswiler.com>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-imx@nxp.com, Liu Ying <victor.liu@nxp.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Max Krummenacher <max.krummenacher@toradex.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Fabio Estevam <festevam@gmail.com>,
        Frank Li <Frank.Li@nxp.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Peng Fan <peng.fan@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v5 02/10] arm64: dts: imx8-ss-dma: add io-channel-cells to adc nodes
Date:   Tue, 31 Jan 2023 16:00:37 +0100
Message-ID: <8183250.T7Z3S40VBb@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20230126110833.264439-3-marcel@ziswiler.com>
References: <20230126110833.264439-1-marcel@ziswiler.com> <20230126110833.264439-3-marcel@ziswiler.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi Marcel,

Am Donnerstag, 26. Januar 2023, 12:08:25 CET schrieb Marcel Ziswiler:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> This commit adds io-channel-cells property to the ADC nodes. This
> property is required in order for an IIO consumer driver to work.
> Especially required for Apalis iMX8 QM, as the touchscreen driver
> uses ADC channels with the ADC driver based on IIO framework.
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Yep, that's even required per bindings.
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> ---
> 
> (no changes since v3)
> 
> Changes in v3:
> - Fix subject as pointed out by Shawn. Thanks!
> 
>  arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index
> a943a1e2797f..6e5ef8b69bf8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -270,6 +270,7 @@ i2c3: i2c@5a830000 {
> 
>  	adc0: adc@5a880000 {
>  		compatible = "nxp,imx8qxp-adc";
> +		#io-channel-cells = <1>;
>  		reg = <0x5a880000 0x10000>;
>  		interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-parent = <&gic>;
> @@ -284,6 +285,7 @@ adc0: adc@5a880000 {
> 
>  	adc1: adc@5a890000 {
>  		compatible = "nxp,imx8qxp-adc";
> +		#io-channel-cells = <1>;
>  		reg = <0x5a890000 0x10000>;
>  		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-parent = <&gic>;