Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD82DC636CC for ; Tue, 31 Jan 2023 15:11:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233048AbjAaPLo (ORCPT ); Tue, 31 Jan 2023 10:11:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232979AbjAaPL0 (ORCPT ); Tue, 31 Jan 2023 10:11:26 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2C9A18A85 for ; Tue, 31 Jan 2023 07:09:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 08C3ACE1ECD for ; Tue, 31 Jan 2023 15:07:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5FD0C433EF; Tue, 31 Jan 2023 15:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675177676; bh=ajutUaUEwqXpqNomITAth5hy9R3xXT8QLPlinoZAJIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p40lVlSOCH+VjSQIdjkU8PO+fVfLNYRtIkNTKm11vCDwQUrUgrEH69Bdgymfh7bfn U68elFR1rMLRVoUxa7B6ooWVJfyyEV+xkXSEpBtEraVXMNKnAi30GXM6lGwwTUReCV FXBZnI0eDKQd3AoRlrbvAXTcxTyFkOCZHl1W2As1Fc8+WmKvGkRSSbIeifWPYYDJww DZjd4fT3zidmMlcBZ+ktC8kswxEt/xwq1wNGFFk59c7YJClGjnYPbvvwRiIGtrh2C8 YhtaH0xUGM+7l4gIQcIQXjAV5w879Czn0AT9PFLeJfx9N7l8UfBpHMoIY/MWOa/0DF rRKYb+puZAocQ== Date: Tue, 31 Jan 2023 15:07:51 +0000 From: Will Deacon To: Andrew Morton , ardb@kernel.org Cc: Liu Shixin , Catalin Marinas , Uladzislau Rezki , Christoph Hellwig , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set Message-ID: <20230131150750.GB2605@willie-the-truck> References: <20221227092634.445212-1-liushixin2@huawei.com> <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> <20230131150644.GA2605@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230131150644.GA2605@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now really adding Ard... On Tue, Jan 31, 2023 at 03:06:44PM +0000, Will Deacon wrote: > +Ard -- full thread here: > > https://lore.kernel.org/all/20221227092634.445212-1-liushixin2@huawei.com/ > > On Sun, Jan 29, 2023 at 01:41:47PM -0800, Andrew Morton wrote: > > On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin wrote: > > > > > Hi, > > > > > > > > > This patch seems to have been lost in the corner. Recently I've meet this problem again > > > > > > on v6.1, so I would like to propose this patch again. > > > > > > > > > Thanks, > > > > > > > > > On 2022/12/27 17:26, Liu Shixin wrote: > > > > After I add a 10GB pmem device, I got the following error message when > > > > insert module: > > > > > > > > insmod: vmalloc error: size 16384, vm_struct allocation failed, > > > > mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0 > > > > > > > > If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the > > > > vmalloc region entirely. Although module_alloc() can fall back to a 2GB > > > > window if ARM64_MODULE_PLTS is set, the module region is still easily > > > > exhausted because the module region is located at bottom of vmalloc region > > > > and the vmalloc region is allocated from bottom to top. > > > > > > > > Skip module region if not calling from module_alloc(). > > > > > > > > I'll assume this is for the arm tree. > > > > Acked-by: Andrew Morton > > This looks like the same issue previously reported at: > > https://lore.kernel.org/all/e6a804de-a5f7-c551-ffba-e09d04e438fc@hisilicon.com/ > > where Ard had a few suggestions but, afaict, they didn't help. > > Will