Date:   Tue, 31 Jan 2023 07:32:49 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     "Li, Aubrey" <aubrey.li@linux.intel.com>
CC:     Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Stefan Talpalaru <stefantalpalaru@yahoo.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Peter Zilstra <peterz@infradead.org>,
        "Andy Lutomirski" <luto@kernel.org>,
        Andrew Cooper <Andrew.Cooper3@citrix.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Martin Pohlack <mpohlack@amazon.de>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch v3 Part2 1/9] x86/microcode: Taint kernel only if
 microcode loading was successful
Message-ID: <Y9k0of7zHCzOgTaD@a4bf019067fa.jf.intel.com>
References: <20230130213955.6046-1-ashok.raj@intel.com>
 <20230130213955.6046-2-ashok.raj@intel.com>
 <b6e8c90b-08ba-ccf9-8704-97c995722ea5@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b6e8c90b-08ba-ccf9-8704-97c995722ea5@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a2wElCiIZPxm5oo4pdHllMwjJtnTzCpkAfTZg/5X+mGfcHMio6PCsL9+YsLn?=
 =?us-ascii?Q?h8JEa9RpBzE6uLJhkRqsfY0L9HT7Edbmy5Q7YbkpjjhQZMzTjB/A08yLF3AS?=
 =?us-ascii?Q?HFRdOlHe1kXkvsyR2bBD3B5WI5/T1TeKoWlvSNzrKKKfEBEaQndGCT0RB8M5?=
 =?us-ascii?Q?mT34G7OvQOkhSpNOq8lvuzIq0gubZaZMYQ7fjhLu+xAc5K440Jk4rwKpd+Xv?=
 =?us-ascii?Q?DgAW9bELABvcZzcolfNJh70nhCm4AAnQgeqdUZECCLFzXPmR6L+8dCcjBNIo?=
 =?us-ascii?Q?qGa7T4hnZz5J1r5LAAq8aGQlo4pyP+c06y2Kz2ad1OQj/AS1Nwv6xzm278oR?=
 =?us-ascii?Q?j1ziY9Xhq1YwK6jxXGkP/gsfKCjecvUupsdXdWjJNKXzngP69GKjwqE56MoA?=
 =?us-ascii?Q?EDSWJnd2+qGk7BTKmH12PemiZlVrbdVzmONLvqV2SG/Oruw6VC4dBOMhOLGL?=
 =?us-ascii?Q?tsn3CdvRX5527u0OGZgmTdU8JykxmyTsDJ/nE6pQ68rkeCTCWiE1OSJxImCv?=
 =?us-ascii?Q?xFViV463KMsknG67Lqkvo6+B0nK9AUHFNDSdrX5wNi3yab2FnATFuc+tpKgA?=
 =?us-ascii?Q?dLE2DdEYGL6A0OTgYmThO1rNsSAqen8ZwwC8PKpPp9O0/tZTTwlHrzexozkY?=
 =?us-ascii?Q?mvQUar0+id80QU3k37Zv4h+aU5txzX3WtqWKFwpg4LLRXUzYpY1ZvnWbSRt7?=
 =?us-ascii?Q?y3aElHh36bQZqWGKcJpZ+h+HgxCcSrka47HqJThBZABgXDiaPIEKF+E36TNc?=
 =?us-ascii?Q?KJ7PP7JVgqJv2PHwenoccTeRJbhX5vsihAqIdF1WqKrM8650O0M7ca/izmin?=
 =?us-ascii?Q?nhY6iMEY0MELyc3y/Q004C96YkQsj8ILw76v9X1GFjQ0+rPndnkaYiOKdia1?=
 =?us-ascii?Q?TAKUFu/QucvRn5aDf1wdxJ9lnyZZnvfxJbGzIWFcCxf3KTBrMh6V1ryFm25I?=
 =?us-ascii?Q?iRkJIApPXo2xZrFoFBvdF7SdzU0TY9dwZVCPiHE+oyPMKTI9oav7T464DP6W?=
 =?us-ascii?Q?Yphu0uP0ieCjE2IFajUx+y2rwM6wdlE+rCHKiHp+YtoJpbY44QosDAy992eX?=
 =?us-ascii?Q?X5oJgnaZW9lg+EHyvaKcXbHr2x8AYPacyFUM4jXqQ0VC5DDvKphbd70Jj3lu?=
 =?us-ascii?Q?i5ThOGvhwKZa9i9Cqw8cE1f+SO3d2mBq8+SWx/4gC3BPfhcV/6+BWaETgiFJ?=
 =?us-ascii?Q?9kMozAh4XxLoR5MxSHCPU6mspux+GWtLsTuKn0+BrXSbw/UVHXV+wkKVFemw?=
 =?us-ascii?Q?O/qCpIT85hKaptOAsq8ePPpdKI8AjJ/fT/pcSTtvzdnLMZE/Z5y3gFHLPWRb?=
 =?us-ascii?Q?GiIn0FAPL0CXz9BHHUzWUfxBnTGN1UKRDkLuJSOa2Uf4PHJkwt7Mm6PSWY24?=
 =?us-ascii?Q?rr+Rkfb3/ocj0/9EIxRDHvxUwqgUwcQM3aIdZcHbDOxxJsvFPlUefxZLd2ix?=
 =?us-ascii?Q?M0N44Jrvw7MWbb54eNeHJvMCHU9Po9wQoV/XpSvGwe+w9T74uREXdJbi1/o3?=
 =?us-ascii?Q?atUU1zByOQ2AnC8P3OgrvOUlrpZuQGwdvWy7KLw3571P9E1NdjmVkP4yqecm?=
 =?us-ascii?Q?VL8guU1YlN9Py9/pjgZlWPIdM6qfejtXCfo077xFttdQ16ilaWJsa1Socfza?=
 =?us-ascii?Q?sQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ba009a5-0e95-44ac-08d0-08db03a07e60
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 15:33:25.5912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ozMjMtJRR4H17IHtpGwZYsioEpR06nAspD1efCakmeATGAaNsCHJFMxjuKcjdxJP93FkVtfEBhWxr399BWqddQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8053
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 31, 2023 at 08:17:25PM +0800, Li, Aubrey wrote:
> On 2023/1/31 5:39, Ashok Raj wrote:
> > Currently when late loading is aborted due to check_online_cpu(), kernel
> > still ends up tainting the kernel.
> > 
> > Taint only when microcode loading was successful.
> > 

[snip]

> > diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
> > index 61d57d9b93ee..1c6831b8b244 100644
> > --- a/arch/x86/kernel/cpu/microcode/core.c
> > +++ b/arch/x86/kernel/cpu/microcode/core.c
> > @@ -472,7 +472,8 @@ static ssize_t reload_store(struct device *dev,
> >   	enum ucode_state tmp_ret = UCODE_OK;
> >   	int bsp = boot_cpu_data.cpu_index;
> >   	unsigned long val;
> > -	ssize_t ret = 0;
> > +	int load_ret = -1;
> > +	ssize_t ret;
> >   	ret = kstrtoul(buf, 0, &val);
> >   	if (ret)
> > @@ -488,20 +489,26 @@ static ssize_t reload_store(struct device *dev,
> >   		goto put;
> >   	tmp_ret = microcode_ops->request_microcode_fw(bsp, &microcode_pdev->dev);
> > -	if (tmp_ret != UCODE_NEW)
> > +	if (tmp_ret != UCODE_NEW) {
> > +		ret = size;
> >   		goto put;
> > +	}
> >   	mutex_lock(&microcode_mutex);
> > -	ret = microcode_reload_late();
> > +	load_ret = microcode_reload_late();
> >   	mutex_unlock(&microcode_mutex);
> >   put:
> >   	cpus_read_unlock();
> > -	if (ret == 0)
> > +	/*
> > +	 * Taint only when loading was successful
> > +	 */
> > +	if (load_ret == 0) {
> >   		ret = size;
> 
> What about if loading was not successful(load_ret != 0)?
> ret has no chance to be returned as size here and we'll run into the endless
> update?

Good catch, we'll need to make that some meaningful return code to stop the
endless wait.