Date:   Tue, 31 Jan 2023 16:38:51 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Wei Fang <wei.fang@nxp.com>, Jakub Kicinski <kuba@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        ore@pengutronix.de, kernel@pengutronix.de
Subject: Re: [PATCH] [v2] fec: convert to gpio descriptor
Message-ID: <20230131153851.ua57vy7vc2xdasup@pengutronix.de>
References: <20230126210648.1668178-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zy7tm2hvwiyorecs"
Content-Disposition: inline
In-Reply-To: <20230126210648.1668178-1-arnd@kernel.org>
Precedence: bulk


--zy7tm2hvwiyorecs
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 26.01.2023 22:05:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The driver can be trivially converted, as it only triggers the gpio
> pin briefly to do a reset, and it already only supports DT.
>=20
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

On current net-next/main 6a8ab436831d ("Merge branch
'add-support-for-the-the-vsc7512-internal-copper-phys'") this causes the
riot board (arch/arm/boot/dts/imx6dl-riotboard.dts) to not probe the
fec:

| Jan 31 16:32:12 riot kernel: fec 2188000.ethernet: error -ENOENT: failed =
to get phy-reset-gpios
| Jan 31 16:32:12 riot kernel: fec: probe of 2188000.ethernet failed with e=
rror -2

reverting 468ba54bd616 ("fec: convert to gpio descriptor") solves the
problem.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--zy7tm2hvwiyorecs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmPZNggACgkQrX5LkNig
01358Af+MUiH2K0uM45xSjCGqBLdDwmDH3hIqbN7YOmbRY078ZN0+8MY6rKY3iyE
vToSnRFKHe8jyWCnqVdNSJGt2O/jsZ6QmAk731rHccG04ZZijLfowpnZWAMteq7t
nEmF9HitPx3l2cKYRORxoxBPqdUisrW/CrN8Xed6rvvrW75CXbYDQ/44Zq0WeNSf
E0QHDOkHoEpb+p8C0n+fJ2iMnK4P3973C6Z8FyxGUBHI/0xnaJkCvS3Tf5vlrtd9
DImCP4MjnP/LsNZuR1nO6xcCel4QF3q9h3Rzvtjc5CHNdehA1D1cw6aywelddDdB
oGgvo1StDSAEnyZB0hhGnGKIXQtajw==
=b7eA
-----END PGP SIGNATURE-----

--zy7tm2hvwiyorecs--