MIME-Version: 1.0
References: <20220819032706.695212-1-xiehuan09@gmail.com> <20221017154057.78babf40@gandalf.local.home>
 <CAEr6+ECqn7rABE0cJP_oPr6g37B1kXu2xpge7Pg67hxywqyO0g@mail.gmail.com>
 <20221129113006.0d745fae@gandalf.local.home> <CAEr6+EArZtwJPwZnKAB_61a=khPpC1=6ogqEC8r4npaaX0WvjA@mail.gmail.com>
 <CAEr6+EB89otsHVOnYNGQ_gbo_g=2fNiU4+3pk06YWFrpZDy=kQ@mail.gmail.com> <20230131103623.53a4e3a3@gandalf.local.home>
In-Reply-To: <20230131103623.53a4e3a3@gandalf.local.home>
From:   Jeff Xie <xiehuan09@gmail.com>
Date:   Tue, 31 Jan 2023 23:48:02 +0800
Message-ID: <CAEr6+EBdJLZ7pQyxr9uzMMfaUdW4skaaqSD7LtzG14TmtCf2WA@mail.gmail.com>
Subject: Re: [PATCH v15 0/4] trace: Introduce objtrace trigger to trace the
 kernel object
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     mingo@redhat.com, mhiramat@kernel.org, zanussi@kernel.org,
        linux-kernel@vger.kernel.org, chensong_2000@189.cn
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 31, 2023 at 11:36 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 31 Jan 2023 17:55:16 +0800
> Jeff Xie <xiehuan09@gmail.com> wrote:
>
> >  Hi Steve,
> >
> > On Sat, Dec 17, 2022 at 4:27 PM Jeff Xie <xiehuan09@gmail.com> wrote:
> > >
> > > On Wed, Nov 30, 2022 at 12:30 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> > > >
> > > > On Wed, 30 Nov 2022 00:09:51 +0800
> > > > Jeff Xie <xiehuan09@gmail.com> wrote:
> > > >
> > > > > > Now instead of searching the function arguments for "obj", we should just
> > > > > > read the obj value at every function and report when it changed, as well as
> > > > > > the last function it was still the same. The report will be like the
> > > > > > "func_repeats" entry. And instead we can print when the object changes,
> > > > > > something like this:
> > > > > >
> > > > > >               cat-117     [002] ...2.     1.602245: bio_add_page <-ext4_mpage_readpages object:0xffff88811bee4000 value:0x2000 (last value:0x1000 at [002] __bio_add_page <-bio_add_page ts: 1.602245)
> > > > >
> > > > >
> > > > > I'm just curious if we'll see this rewritten version in the next merge
> > > > > window  ;-)
> > > >
> > > > Unfortunately, this ended up getting dropped in priority, as my workload
> > > > increased internally. :-/
> > >
> >
> > I would like to ask if there is any hope that this patchset can be
> > merged into the linux kernel in the end.
> >
> > We spent a lot of time on this patchset, I don't want to give up so easily ;-)
> >
>
> I think we were near the end, but it wasn't quite done, as I want it to be
> integrated with the kprobes indirection interface:
>
>   https://lore.kernel.org/all/20220924160136.5029e942@rorschach.local.home/
>
> Which I started to work on but didn't have time to finish, nor even get
> very far with it.
>
> I think once we can get that implemented, then this can get in. I don't
> want to give up on it either.

Thank you for your positive and fast feedback.

>
> -- Steve


-- 
Thanks,
JeffXie