Message-ID: <0ef7b7be-4132-669a-448d-ce7c9f198d57@nvidia.com>
Date:   Tue, 31 Jan 2023 10:43:55 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 4/5] genirq: Use the common function irq_expand_nr_irqs()
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, Michael Walle <michael@walle.cc>
Cc:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Hans de Goede <hdegoede@redhat.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        linux-kernel@vger.kernel.org
References: <20230130005725.3517597-1-sdonthineni@nvidia.com>
 <20230130005725.3517597-5-sdonthineni@nvidia.com> <87h6w711yc.ffs@tglx>
From:   Shanker Donthineni <sdonthineni@nvidia.com>
In-Reply-To: <87h6w711yc.ffs@tglx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHh3NnZYL3pPVHdPQm1XckZINUpIb1NUN3hMRDkyV3ZBZlZDeEpWMjRrYnQv?=
 =?utf-8?B?UHRjc0YySTJZRWxua0c1OXA0S3NDTWlOQXZBNGlVY0JrUVdHMXJyM3MwZzBJ?=
 =?utf-8?B?VUZWRjRQOHlkVm5LUlBDbmdzRUNIV2s2eGl1cXBvdHMyK3ZZUDhqOXVpbUUw?=
 =?utf-8?B?SHBPbzJyOFIrVzcrR0dIbGVZdWYyT3loL1hucGc1N3h4VktHd0tWNVlWdStj?=
 =?utf-8?B?ZlEydjdZZTVyemdKOC8vSzdVaUh1WHIyUWs2SmVCOXM5K1p5L2JzblpWWlZH?=
 =?utf-8?B?ZWRkZ2F4YUp2Y21sYlJMbWErWEJnV041dEN1bXo0ZGdYdkhGZVVYNjFzMi9K?=
 =?utf-8?B?cDRuWW4zaUNsaTcwRW1seVBrZ2pGeUlPcVVkWVNxcDg5Q0R2dmw5Tm0yU0V6?=
 =?utf-8?B?Ni93bW5ZUURWNzhsbko4bTZRTHlXQWdlcHAzVUt2TFJaOHp6a3F5dmVTZndF?=
 =?utf-8?B?N29OdkVvdDZQMzZ2azRlb2tBa3VWVnpIWjNmWWpiWUw4M3FYc2ZLd0JicW16?=
 =?utf-8?B?c1ZJdHBIWisrS3Z1MU83aE9pVFhIWTB1NGxDZktmd2p6QmxzNWgzaUVGSnVa?=
 =?utf-8?B?dkJHRWEzNVBVNjYxVnhoYVJEVVAwUnJaMmFGd0RmN3AyZU5jMkR6RFZ2ZlJt?=
 =?utf-8?B?QkhLQklTL28wVnpSb0w4K3AxaUZsdjhsT3RsQlBYOXRPNW9WQzBybnlVakNF?=
 =?utf-8?B?blRQaFZ1TGp6enovQ2VOSXdLa1BmZGhRUmhDUVRRRktZTVNtb0tRK0FCelFh?=
 =?utf-8?B?VGdaTnBodXdyNEJhUjJDM0FZRk82NjNPNHNSaXJNUkhyVlY5RDM2MjhtQUlu?=
 =?utf-8?B?VnY5SHRLQWdLZGNDakVyVG4ybUYybWRPTlRaUUwxcnpBbURTbFdJb2pJT3BH?=
 =?utf-8?B?YXVOYWYzbE12MVIvbXBJL3BIMkpHR3FCclR6R1pWaHJEZkdPL0ZPY0kySjhk?=
 =?utf-8?B?bTV1Zlo0cFZmNXp6NVhiVnJuR1VHaG9zaTlqMzRzc2lkNnVFa3Z0MTRWYlZP?=
 =?utf-8?B?ZXNEUkxxWUt3R3JuRXlxaDVybVVsVDh3eGxuaFhuQnAxNlBNWTFqWGVKOHRn?=
 =?utf-8?B?bFFkdmhaRlVzQVNTL3BjRUJrTkI1bmlOUHBSQWgrSUNPZjdoTzBxdGd5dlhm?=
 =?utf-8?B?YU5HRXFwSjZwaDh1NEtkOTkxRFRWUjFDSFd3ZlNUaU9zQTUwamEzak0wVDRJ?=
 =?utf-8?B?cCtmYUFuTU9ZeTRqUVFPdW9wUFc5R0lBdzZFMlNFazVMa2Zqb2pxTGJTR2tO?=
 =?utf-8?B?UE5jRGczWkl1R2haSjhrNjR2aGorcTZveGR4RU83ejR5VmRpVzN3bUkyM0dh?=
 =?utf-8?B?VXdQSC9IT1pxZHFmMER4U0l3VHBha3Z0aFpYNTZNSFZlNi9RbVJYRm9zbThG?=
 =?utf-8?B?a0FxNUh0MlRSYll3WHc1c3FhNS9ZS2NGM1R4YTNEeVhIWHdvOXpUNTc0STl0?=
 =?utf-8?B?YzU1ZjA1WEZkejV6WVNmSlJ2UHM4bDVHd2FVNHFHRXlQdVB6TFpKVWtRUlRJ?=
 =?utf-8?B?c1Vqd1NmczRkTkJVSUZhWStOYkhRcC9pYmhuWXlvYXFCZWlGR2hpek1aVEpz?=
 =?utf-8?B?TmNsY2M5SVdNN2xoZWFGZ2hPakVjUmJyNno1UHdwRjQwOTAwcGM2VzBzc1g0?=
 =?utf-8?B?alNxSlhQRmJrckRKbXhCOGxoY1pDL09BdWNGWUU2ZGJlWHdwNUxBaHBHWlkx?=
 =?utf-8?B?cWsxVTI3Q25MYU5iVnQ1U1VhZGo1NmVBSmFnZk5QT21JYmRMWlkxbDNiSkFp?=
 =?utf-8?B?Vk5mNEtYdnJzWWhtNDNLanRaY213SjFqeWNpeHRqQUl6WlNrWGpEb1N4Z0hE?=
 =?utf-8?B?aWd6MVhVRFM1YWM5WFhJdTBsSDEyWnBnZ1lVcUtrRm5Iai9xREM0UEhwblNW?=
 =?utf-8?B?UzFoR2c1TkZkWGVlSnQxQkVGaHNzVlErM1VYQ1JzNTIwMGNqMzRpUUZPN05u?=
 =?utf-8?B?QjJqdWJCcXJIMFhMaUNpY0w4VzhtajBVb1dPTERJa2tUeVVtTm93dUdRNlYr?=
 =?utf-8?B?S3ZQTWxRRlZRMVdJcTJXbytvanZTeldJM0RFd1h5U0hZU3dZc29PN2JBaklh?=
 =?utf-8?B?MDZ5TlZUWjZqM1M4cjEzUmQ4V2VnSlY1QjdsVGFUY2JlUTRTZ2dnUExBTU5V?=
 =?utf-8?B?Q25VbjEwM3FRU29ZQmJqNVNzNGZJWVBUWEFiL0ZXTUt1NlV0dHg1WlJmaEtW?=
 =?utf-8?B?TVE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb79d9d-e434-4972-d84b-08db03aa58fd
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5762.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 16:43:57.7442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k/QvzuIBpTykLvAxRWeeuiI2ug+yg50kwkKf02j3s8VwPKSma0BYNFPNYuI12DdPVNmyWqwt0tpaz449xhT+JA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4574
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/31/23 03:35, Thomas Gleixner wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Sun, Jan 29 2023 at 18:57, Shanker Donthineni wrote:
> 
>> Subject: genirq: Use the common function ...
> 
>    genirq: Unify irq_expand_nr_irqs()
> 
>    irq_expand_nr_irqs() is implemented as a stub function for !SPARSEIRQ
>    builds. That's not necessary as the SPARSEIRQ version returns -ENOMEM
>    correctly even for the !SPARSEIRQ case as the ....
> 
> 
> But this common function is non-obvious for the !SPARSEIRQ case. It at
> least needs a comment
> 
>> +static int irq_expand_nr_irqs(unsigned int nr)
>> +{
>> +     if (nr > MAX_SPARSE_IRQS)
>> +             return -ENOMEM;
>> +     nr_irqs = nr;
>> +     return 0;
>> +}
> 
> or preferrably something like this:
> 
>          if (!IS_ENABLED(CONFIG_SPARSEIRQ) || nr > MAX_SPARSE_IRQS)
>                  return -ENOMEM;
> 
> which makes it entirely clear and also allows the compiler to optimize
> is down to a 'return -ENOMEM'.
> 

I'll drop this patch since you're suggesting to remove !SPARSEIRQ support.