Message-ID: <cfc3b77b-7e02-d5b7-382c-00cccc4e2914@nvidia.com>
Date:   Tue, 31 Jan 2023 10:45:38 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 5/5] genirq: Use the maple tree for IRQ descriptors
 management
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, Michael Walle <michael@walle.cc>
Cc:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Hans de Goede <hdegoede@redhat.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        linux-kernel@vger.kernel.org
References: <20230130005725.3517597-1-sdonthineni@nvidia.com>
 <20230130005725.3517597-6-sdonthineni@nvidia.com> <87edrb115j.ffs@tglx>
From:   Shanker Donthineni <sdonthineni@nvidia.com>
In-Reply-To: <87edrb115j.ffs@tglx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmkvSVpmT0t5YVh1UE9wN1pHbWEwTEdzRTdIL3JhcXk1eDZQdzdaN3dMSVRM?=
 =?utf-8?B?UmRlTHgxVURlNk5ic0gwZjg1WFdvSXVxRjV3NkFnZzdaZG0vNDkxdU9XMHdO?=
 =?utf-8?B?Z0VnLzNiQnh4YWdFSGdscnNyNGFPTVlRdTNzN01rS0xvYjUvdWFqS2JuL3Iw?=
 =?utf-8?B?SU42V0YwMktJaWp1aGFGZjR1Yk56aklxbVIvSVVITHd4ZXdaZlJGckhqdGtu?=
 =?utf-8?B?QngyRlU5bFFLM2RvRGtsY2lkV2pCRUkveUZkYzU3Q2JiTWcrQVJwYVhMc1V1?=
 =?utf-8?B?UEg5MjNQT2pmeXM3SERNN0pHMERHNTJUaDVZcWlHWXpuWm1kRUgxTVJScWY5?=
 =?utf-8?B?N3dON01IVmRSMFZkSmorWnpOYWhRdkZQaHJGdmdzanZMZ05JMWt6Q2RnU2FR?=
 =?utf-8?B?c1FKd2NBamxqVGE5RGJqb0JVQW9GR1owRFpUNkMvd0hJbStIQWtncVcxelhl?=
 =?utf-8?B?bzUrK3BHK3N5OTVWMDFqRGV2bVl2WTZPUDhxdU8vb2hPYXY5bWMybzNSNFcw?=
 =?utf-8?B?eHdaa28xS1BBZDhkdWN2OHNQRVNCOHNGNUxCamg0WGVnRVdyekhpZHlBL0kz?=
 =?utf-8?B?UWU1UVhmWXJ1RldjdFNrcGFtek11cXhlM09nb3JGWVBZYjVoMVpTeWhpZ1RZ?=
 =?utf-8?B?NGExamgyQ3ZUcnVjbzg5cHZDRXZxSEdnVzdTZHdNU3Bvb3AwN3BPNDZoaGlT?=
 =?utf-8?B?WXN6TWJkY2EvSjBMNVNKcFFjcmRIUmhPejR0NysrcXB6NVBieTZmcWYrRkEv?=
 =?utf-8?B?Yk1rdlRXTkxURkRCSU1FcGhBMERWR2VvbzZxNUZ6UVVkWEg3QkVQUzZ1UnI3?=
 =?utf-8?B?b2l4TjdKTzlqdnpKcFptT0c0cGRDZERPeXpWYWYrTmdxZXNjRmhucjBBMWpm?=
 =?utf-8?B?aGFIcWdqcmxHRXpXUmp2VDIyaTVlS0pKYkNhc3lTMzdZYyt2WGJYakRCZ2hh?=
 =?utf-8?B?eXpLdzFQdEVDaUtTSytPVGZXcWMyZ05rR2hOWVZlNm1BVW5MTnpPNTF4R3Va?=
 =?utf-8?B?SzYwNXBRT0hwakhpOXByVitXdHZ3UTlUMk4vQzdwMEtUMGV3b0JtSGl6MDFV?=
 =?utf-8?B?eCtmQ0ZXQ2QySnR3NURqckl4M2pvMmJDaW0yT25nd2tRYUdPaUc2OWZoRTYy?=
 =?utf-8?B?eU5NK3NhTG8xb0NSL2ZYWElYMTFOM1pFc0M2UTBya3NzVllHS1dHZzFLckI0?=
 =?utf-8?B?UDAvb1RTTjhZRFJkODFYY2VDT0ZoMm9oT25pQUtUZ2lzZVJ6R3ZvZ0grQjdE?=
 =?utf-8?B?d2RpUmExdWFmRndJK010Y1RsTVVWdEVpUzlVNlBWZVNUT2lWMmgvY29PYzVx?=
 =?utf-8?B?dFZNbi8yRlpVOENySWxXSXgxa0NHM2pmMXlESVpsOHY3TnM0SlpxQTM3Q0Yw?=
 =?utf-8?B?UU9hWnF6NExhZzZBMjNmYng3bGFGUTZHcXBSTXRub3ZJWEVVK3Nkbnoxb3Nv?=
 =?utf-8?B?OVRFcVM5S1hRUGdaUm10UVNZRXM4TTZqS2xCM3luQmlTY0NxdVA0eWtORVhk?=
 =?utf-8?B?UjJCYkNOVWZlbWZ0dkF6UndrOEhJYm52VHRuQkJKRGVQKzJubUZLQjcrenZx?=
 =?utf-8?B?b1ZSOE9DaEVhY3JjYUZxZ3RWZ1J0SDkwSG1MQWtuMFVOMXpKT29keFlFSDZN?=
 =?utf-8?B?ekZsTzQ3MWNyOS82OWZjVmJSbDVEZ2NyUG9RaFRBeTNYVXpZZDN5Si9Fa2Nk?=
 =?utf-8?B?WkNPUEtvNURtb25WMHZmVDk0dXJWdlZWYzV2OXE3V3J2dzVvMk1YNXRGQ0li?=
 =?utf-8?B?NnZ2eDRUYTdFSHd5UW1PT3JibGRkUjJ4azgxLzJKeWROSHpvczJGZ1hUNFo3?=
 =?utf-8?B?NFFLUGY0V3dMellTTmF2NkVGWkNnZ1ppNnMxUHRzRmFGMXIrMlcyN2lkZk0v?=
 =?utf-8?B?RmY4RjE1WS8zREJBbmx1Unh6TlFNK3lrNjkya1MySldBdytka3NYZm9vMDJ0?=
 =?utf-8?B?c1JYbk1odjhtVEZJLzJsSG4xazBRM2d4MkV3Wm9rb1ZBNlc4VVRqaGV1WUxQ?=
 =?utf-8?B?NVpvT3hSUlZIbFVwWW1ZZzZqbW9xcFh2WkxmZnpjeDBhWXdKU0o5UGoxVVkw?=
 =?utf-8?B?Y3RtMUU3dzU3TGFQbFl3c0E3RldCam9rb2xYSXpQWjd6eXZxaGMwWFZCVVdy?=
 =?utf-8?B?TEd6S2NXVDdUSkw4RjlTN0ROU2ZLdFo0dHpKc0lnN2lNSjdKMWNtR2FFWUJP?=
 =?utf-8?B?aUE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58e866e7-8e45-4413-4684-08db03aa96a7
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5762.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 16:45:41.1487
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gNE8lGb35411Tpb1DzhazVRThpXIz8V1IJBsZzmK4QGBCmIoGtbO2alBgHBMfN0wbaicPwyvGj4ZurqYdYwx9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4574
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/31/23 03:52, Thomas Gleixner wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Sun, Jan 29 2023 at 18:57, Shanker Donthineni wrote:
>> The current implementation uses a static bitmap and a radix tree
>> to manage IRQ allocation and irq_desc pointer store respectively.
>> However, the size of the bitmap is constrained by the build time
>> macro MAX_SPARSE_IRQS, which may not be sufficient to support the
>> high-end servers, particularly those with GICv4.1 hardware, which
>> require a large interrupt space to cover LPIs and vSGIs
>>
>> The maple tree is a highly efficient data structure for storing
>> non-overlapping ranges and can handle a large number of entries,
>> up to ULONG_MAX. It can be utilized for both storing IRQD and
> 
> IRQD ??. Please write it out: interrupt descriptors
> 
> Changelogs have no space constraints and there is zero value to
> introduce unreadable acronyms.
> 
>>   static DEFINE_MUTEX(sparse_irq_lock);
>> -static DECLARE_BITMAP(allocated_irqs, MAX_SPARSE_IRQS);
>> +static struct maple_tree sparse_irqs = MTREE_INIT_EXT(sparse_irqs,
>> +                                     MT_FLAGS_ALLOC_RANGE |
>> +                                     MT_FLAGS_LOCK_EXTERN |
>> +                                     MT_FLAGS_USE_RCU, sparse_irq_lock);
> 
> Nit. Can we please format this properly:
> 
> static struct maple_tree sparse_irqs = MTREE_INIT_EXT(sparse_irqs,
>                                                        MT_FLAGS_ALLOC_RANGE |
>                                                        MT_FLAGS_LOCK_EXTERN |
>                                                        MT_FLAGS_USE_RCU,
>                                                        sparse_irq_lock);
> 
> Other than that this looks really good.
> 

I'll update in v2 patch.

Thanks,
Shanker