MIME-Version: 1.0
References: <20230127013823.832698-1-trix@redhat.com>
In-Reply-To: <20230127013823.832698-1-trix@redhat.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 31 Jan 2023 12:20:31 -0500
Message-ID: <CADnq5_NpjoaU5+HThA5s5-KANfoYSgwr2Vj6pYuqWKqJrdXRkg@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: reduce else-if to else in dcn10_blank_pixel_data()
To:     Tom Rix <trix@redhat.com>
Cc:     harry.wentland@amd.com, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, Anthony.Koo@amd.com, alex.hung@amd.com,
        aurabindo.pillai@amd.com, Roman.Li@amd.com, wenjing.liu@amd.com,
        Dillon.Varone@amd.com, mwen@igalia.com, dingchen.zhang@amd.com,
        martin.tsai@amd.com, aric.cyr@amd.com, Wesley.Chalmers@amd.com,
        Max.Tseng@amd.com, sivapiriyan.kumarasamy@amd.com,
        Tony.Cheng@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

On Thu, Jan 26, 2023 at 8:38 PM Tom Rix <trix@redhat.com> wrote:
>
> checkpatch reports
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: style:
>   Expression is always true because 'else if' condition is opposite to previous condition at line 2895. [multiCondition]
>  } else if (blank) {
>             ^
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2895:6: note: first condition
>  if (!blank) {
>      ^
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: note: else if condition is opposite to first condition
>  } else if (blank) {
>
> It is not necessary to explicitly the check != condition, an else is simplier.
>
> Fixes: aa5a57773042 ("drm/amd/display: Vari-bright looks disabled near end of MM14")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index bb155734ac93..f735ae5e045f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -2899,7 +2899,7 @@ void dcn10_blank_pixel_data(
>                         dc->hwss.set_pipe(pipe_ctx);
>                         stream_res->abm->funcs->set_abm_level(stream_res->abm, stream->abm_level);
>                 }
> -       } else if (blank) {
> +       } else {
>                 dc->hwss.set_abm_immediate_disable(pipe_ctx);
>                 if (stream_res->tg->funcs->set_blank) {
>                         stream_res->tg->funcs->wait_for_state(stream_res->tg, CRTC_STATE_VBLANK);
> --
> 2.26.3
>