Date:   Tue, 31 Jan 2023 19:48:26 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Juergen Gross <jgross@suse.com>
Cc:     linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net,
        netdev@vger.kernel.org, Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Dominique Martinet <asmadeus@codewreck.org>,
        Christian Schoenebeck <linux_oss@crudebyte.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH 1/2] 9p/xen: fix version parsing
Message-ID: <Y9liesGIeKFkf+tI@corigine.com>
References: <20230130113036.7087-1-jgross@suse.com>
 <20230130113036.7087-2-jgross@suse.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230130113036.7087-2-jgross@suse.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Qzyd5Olj3xLiYN5N9JOzOCEUihyet81wWIl2YYVS0uqMk0GZHy+6rwPzSNL?=
 =?us-ascii?Q?7HmHbiEFlkz5jHWsCzrcKt7nHJCm1RJWnLDS7hNfOIRNGVIsaivAAlU2CNkL?=
 =?us-ascii?Q?6FT5K7Whg6AO/TcrjJHNZ4Aq5TOELHBV34JnN4cIh9M166yD3aAEpK8PW61b?=
 =?us-ascii?Q?9jXq/7BsrzY8hod3hLw1xaqJKUeXtawKqJfKyCKCBL5WcokQ7b54OVaGUSUr?=
 =?us-ascii?Q?FlwiQWsd1HsDkqlmgCx0twMl9ECRCbulAzDqzXW2Yyp7SjaTl14TLml0pvnb?=
 =?us-ascii?Q?KoUxBiZAenZ8EbQzO3b4Qg1nN08GiEgyEIaaEOjwmUdENA93wDJNGr6z1mY+?=
 =?us-ascii?Q?6HecGFo1VjygKuRqKHQTTlcNhRJd4oSGvJSoUTBwfquZ1fFWKQN+23qLANoQ?=
 =?us-ascii?Q?Vf1ELig2DHnAYlIp3WVoytU//6eVA3wF16aPoBTJNCvNuplaw+L0J/yADZCW?=
 =?us-ascii?Q?bKiwERf3bfFKA66yEmHfCuNty+owOVNu6PeufUD2b9smGWTH9HYCMhB2WFh5?=
 =?us-ascii?Q?3ojkKyW0eBhjTm/09i6wzMeWGiebb2iylbPT7hRUZJpawT0LegYZX998TEpd?=
 =?us-ascii?Q?oUJwK7nMDM+il3gfuAp5mx4jBObl9eQ9FnC6akWfaxmVZWaRRxBKC6u2Y6IH?=
 =?us-ascii?Q?z+pBP8rPhxwbYysV0qtH/LA+Y/vfXyGU7s8TtNHNDXxMM4dzqJ8lqHMpjpPc?=
 =?us-ascii?Q?G+rV3gfhiZH/8wVzFTPC1KTAg4h/hHBM/IMDhICEMKXEd18IPpeTslDqVSxe?=
 =?us-ascii?Q?AEPzCL1wKrA6FijMDgWMRA+Tm7c+qjyNM3D9XdUcPDQHf55SNMSMoJ/gFvvq?=
 =?us-ascii?Q?TpKuav5ZrOqxhDkrGXqnmKAjzkpKLRhz7wsytejByfxZ5u5G+iRJ24CT6eI3?=
 =?us-ascii?Q?xLLcnL+et5zy1fUqiTU/wXxBqGmtOyWVuDAy3wjNkUrsRKjy1KTJNI+nv1aR?=
 =?us-ascii?Q?Zn7KxM/aNBPrGlEn2BeyBYjsAJ5H2yY8LcKRZS/XmFUdBlsNFmp+0tiqqxlF?=
 =?us-ascii?Q?jiXZqcqRQS0OyWJiH3/ZTyxxtbBAmZFRmB+VYhDYCRLsaoujRpcYcUkLIPIc?=
 =?us-ascii?Q?BWPifHvo81aBdcKfNEir6OJmgkcllNzQj2ScvkygJ35HW93P5+EM9lhgkqkG?=
 =?us-ascii?Q?H1SLywIWFXQCpFP7fqDPCRjpFbDNPknyLPFZStSW6tXKwlX4xqErnFHWMs/K?=
 =?us-ascii?Q?cl9m4lyCnnpycNAVcc9uyH9KpSMr2RZMXL/x/2hFsxH1eeVt+JJf5ax5GW1e?=
 =?us-ascii?Q?gc20ab2Ofk4l2WTfeCZHWVVWCvVwWS8fcdALi+H+F3oVi4zoKJtJLOuH/RYP?=
 =?us-ascii?Q?2VTT0dVgBclP2I+NAlEugu2llOnv/kRmY+STmWqGZ7PxtCEerdihD2F4Mz/R?=
 =?us-ascii?Q?ybKeHkFs6phlxSNoVHd9+uV8TUCRJzSU8oA94S8P+lDnHSUv3OQPwprc4ggd?=
 =?us-ascii?Q?Kh/X1uTEjNiOpOirlHX+M/ogopTrdfDTpQWLjWprdnI2jaN1umOu2/QySdEl?=
 =?us-ascii?Q?t8g5hFoT86WvDyGS7kntVdWNxS0+aT2ML4Pps+DpsELxV7hHLcjrJhNclWV+?=
 =?us-ascii?Q?Fi29w4iK5lY12MX9o93+SrCjvSNi3mA/0BiJEfEg4s54WiO2c6xRcSwpms5n?=
 =?us-ascii?Q?tVHCc/q1XixRIeXTlzsQm3FDFG5pzSqq+LEEttkBctJLabojCtMihdufrZlq?=
 =?us-ascii?Q?JfCrWw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91d8a6be-d29c-4f15-d994-08db03bbc0df
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 18:48:34.0375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vgo70ZwIHo6aklb6IvN0evPBUuW+ZasV23I9IdvpCS9qcNYVj7WLkDJtsUqXyl64mcyBFZMPs2wMll0xs3xTIGNP9Kjp8+AhSsg98FMxftk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5868
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 30, 2023 at 12:30:35PM +0100, Juergen Gross wrote:
> When connecting the Xen 9pfs frontend to the backend, the "versions"
> Xenstore entry written by the backend is parsed in a wrong way.
> 
> The "versions" entry is defined to contain the versions supported by
> the backend separated by commas (e.g. "1,2"). Today only version "1"
> is defined. Unfortunately the frontend doesn't look for "1" being
> listed in the entry, but it is expecting the entry to have the value
> "1".
> 
> This will result in failure as soon as the backend will support e.g.
> versions "1" and "2".
> 
> Fix that by scanning the entry correctly.
> 
> Fixes: 71ebd71921e4 ("xen/9pfs: connect to the backend")
> Signed-off-by: Juergen Gross <jgross@suse.com>

It's unclear if this series is targeted at 'net' or 'net-next'.
FWIIW, I feel I feel it would be more appropriate for the latter
as these do not feel like bug fixes: feel free to differ on that.

Regardless,

Reviewed-by: Simon Horman <simon.horman@corigine.com>