Message-ID: <194d8448-dde2-3452-7ccf-4e88fddbff75@amd.com>
Date:   Tue, 31 Jan 2023 12:49:54 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v1 3/8] x86/psp: Register PSP platform device when ASP
 table is present
Content-Language: en-US
To:     Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>,
        linux-kernel@vger.kernel.org
Cc:     Brijesh Singh <brijesh.singh@amd.com>,
        "Kalra, Ashish" <ashish.kalra@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org
References: <20230123152250.26413-1-jpiotrowski@linux.microsoft.com>
 <20230123152250.26413-4-jpiotrowski@linux.microsoft.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230123152250.26413-4-jpiotrowski@linux.microsoft.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnJYc0ZDZjdFeGU3R0RIM3Z6cVJ0UXRMdHVFMXNtM1llZ01UTzVGbmxlMFFH?=
 =?utf-8?B?MUpIZG9tSkpZNXVwaXh0R0t4U1U4bkNsVjVEVVdVV0wwOTJoSi8xaXZvVWcw?=
 =?utf-8?B?Q0pSTVZQR1gxcy9zcHA4OTY0S3lqTUdNY3VObG5iVUJ2QjNOaXJBWU83Q29X?=
 =?utf-8?B?SUR1V1dUczF1MzhTWWkvUng1aHhpWWVEd0RFZUkvR2Z0NWlkazBYUzAybVlh?=
 =?utf-8?B?b05LRFZQdDZqVVBjRkJ1c0M4TVA2Y1lDOURscmlaVlJSQ0FoYlVzSS9iUE5D?=
 =?utf-8?B?Umdqc01EUUp6bzRCbmlJOUZzMStqR3gxS3FyWXg4R3BSNnl4Q1VZYk1PZ2Jj?=
 =?utf-8?B?Yk8rVHduZzdoQXZXVG1GdWo1ZkhtdGthRTVEYWp0R2FrN2R3RERET244aWg2?=
 =?utf-8?B?SXVoNEh1U05sZUZsU2ZkcG9VMjF4b0tlQ000dEJHb3lQZHZKQ2lrODkybmw0?=
 =?utf-8?B?OHNJSWY4R2xpR2tXeUxIb0RGUEI0aDVIRXMxL0oxeEg2bklCRW5LeEZtcHFX?=
 =?utf-8?B?TGhEdlJUNTdzRitUaHc5dWw3dDE3U3VuNG5pQnUzRVYrUHY1eWdxUWpna2VC?=
 =?utf-8?B?NVpwZ29yQUE3ZEdITStoYXY0Rm05YWNxbFVWV1o3ZlErTmJtaFdZbDVTNGZ5?=
 =?utf-8?B?YklpU3ZUYWF6cFRUZU41eUwvblAyM2NlNFU3OFNtOVJsYzJyZkpNSjgyMjJB?=
 =?utf-8?B?RUR3ZFJ6Z3FvRUgzbVRDdThQampvTUpUMEczL0VCbGZta1QwSFN2ZUp3cHFI?=
 =?utf-8?B?U3VDdG9Ma3VHQVRZUG1yYlZHa1BNcEN4VjEzbDg1bmhjeGhvTjFTSUMwSS9U?=
 =?utf-8?B?T0U0TnpyYkJjSjBZWnM1djVzRUVxTktKd2ovSE5DUmpUMzdoZFpKU1NEd2xl?=
 =?utf-8?B?ODUyMXRzRURYTU1RL2lXQytkQ1Z3M0ZHdE9wdEcvK0QyYnhkb3k5TkNSUXhO?=
 =?utf-8?B?V1FuYnh0cTNlMXVHV3M4aU5lb2tyUnUzZEZCOCs4VzRPaCtnZ2lTMUgydGNM?=
 =?utf-8?B?YXNGRUlVRlZCS0Vpa0d3V2hsaWZFZi90aW9mc2Y2Z1dwYnpvM0lUOHpFMXRT?=
 =?utf-8?B?cTRoTEQ2SlNRZXVaa2NFUmNaVlN4aEZ6VE96bk45bkVZY29XczhqVzBTWFBU?=
 =?utf-8?B?QWFQaGJRTWhOZGhTNnV3NG5ySVUxTWx0Smd1RUdlbkZSQ2NjN3V1bFRia0VG?=
 =?utf-8?B?dEIxdlRVMjl0VVpJVVpnMitMUWN1ZFVMZmdGSnlDeTc2bGwraWdmUjYzU2RQ?=
 =?utf-8?B?NlgrSisydkh4cjlrVFhBSzVRQ3B0Z0c5bEx3WTJCcS9OMGNGMnpHNkdhTW5a?=
 =?utf-8?B?YmxLeEdWVDJWL1JvWEdBY2YrL29uZnJqV01XWjNMN2RRM2U3SFVuQUN4TFlV?=
 =?utf-8?B?UE5ob2NacGRyTDJPaEhFM0xKSjZrZUZwTzRQY3AyQWhha3lqSWg4d1RmYjB2?=
 =?utf-8?B?amk3aVhtTkI4S2JwOU1uZjZWSTVKWE94bS95UmxKbUh1QUdyRHRhK3lYOUc0?=
 =?utf-8?B?TVhpNUUzcm9Hc2FiczVRYWQ1aTVVejhiNlM2UGVKRHlmM282YjV2YzhVc2RJ?=
 =?utf-8?B?QUhSUFlGWXRpaW4zYkdBVGZBMDhieGpDV0pBMjJEOG9rUDZlRzJydmIzMWNZ?=
 =?utf-8?B?MitFUFhMVk43R0NHbGNIdzlXYXBpQ3JzcUV1RFVJOWVKVHMzNURDRFJtVkhm?=
 =?utf-8?B?NVVhYURyUndtVCtONTR4VS9odUdhd3NVdDZwYmh0OThXR0I4bVBQVENYK1Fl?=
 =?utf-8?B?eHVhbWNQVm8rOUpydGhwTlI4ekh2dlRQbThrTHVsUW54ZUVZRS9aYUVQNzI1?=
 =?utf-8?B?YkVTQ2s2Tlhtcmt5TDI1cjhkUzNHbElTMjhQelNYcFl4T3dUaklPRlhmOWpN?=
 =?utf-8?B?YWowZStlRmlXeGNxNUdrSTM1UzhEcTY5RmlpNWdkVUowQlBsYStrdWhLOUg1?=
 =?utf-8?B?UFZWL2xvRm5jN1lmWVl6aVFYcDdnLzliU1RoUmUyTkg2NXVNUmNOMWhTNWJG?=
 =?utf-8?B?ODhweWwwU0xTNE9sckRmVjRhUFVjSzBKQUh4dmNtMU4zci8zK0pWdlVIOGYw?=
 =?utf-8?B?QTVNMEttWXhwZ2hmUzBRYVFJMnlHbEduaGI5a1YxYzRMeDMzMllUMDZtN09N?=
 =?utf-8?Q?xuZKfwiqV3T84x5rchECINx/6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef4ef536-dbb5-4ad9-7db7-08db03bbf28f
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 18:49:56.7890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DGpTaWmZM77Sw0Q0wQoJQpjIgAUSZzovDazYBS7xKQyRZdkx09Jz7dwq2MVf3FgvmHgS1jzy47R30Poekep2TQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6420
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/23/23 09:22, Jeremi Piotrowski wrote:
> The ASP table contains the memory location of the register window for
> communication with the Platform Security Processor. The device is not
> exposed as an acpi node, so it is necessary to probe for the table and
> register a platform_device to represent it in the kernel.
> 
> At least conceptually, the same PSP may be exposed on the PCIe bus as
> well, in which case it would be necessary to choose whether to use a PCI
> BAR or the register window defined in ASPT for communication. There is
> no advantage to using the ACPI and there are no known bare-metal systems
> that expose the ASP table, so device registration is restricted to the
> only systems known to provide an ASPT: Hyper-V VMs. Hyper-V VMs also do
> not expose the PSP over PCIe.
> 
> This is a skeleton device at this point, as the ccp driver is not yet
> prepared to correctly probe it. Interrupt configuration will come later
> on as well.
> 
> Signed-off-by: Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>
> ---
>   arch/x86/kernel/Makefile |  2 +-
>   arch/x86/kernel/psp.c    | 39 +++++++++++++++++++++++++++++++++++++++

Based on comments about other SEV related items, this should probably be 
moved into the arch/x86/coco/sev/ directory.

Thanks,
Tom

>   2 files changed, 40 insertions(+), 1 deletion(-)
>   create mode 100644 arch/x86/kernel/psp.c
> 
> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> index f901658d9f7c..e2e19f2d08a7 100644
> --- a/arch/x86/kernel/Makefile
> +++ b/arch/x86/kernel/Makefile
> @@ -139,7 +139,7 @@ obj-$(CONFIG_UNWINDER_ORC)		+= unwind_orc.o
>   obj-$(CONFIG_UNWINDER_FRAME_POINTER)	+= unwind_frame.o
>   obj-$(CONFIG_UNWINDER_GUESS)		+= unwind_guess.o
>   
> -obj-$(CONFIG_AMD_MEM_ENCRYPT)		+= sev.o
> +obj-$(CONFIG_AMD_MEM_ENCRYPT)		+= psp.o sev.o
>   
>   obj-$(CONFIG_CFI_CLANG)			+= cfi.o
>   
> diff --git a/arch/x86/kernel/psp.c b/arch/x86/kernel/psp.c
> new file mode 100644
> index 000000000000..d404df47cc04
> --- /dev/null
> +++ b/arch/x86/kernel/psp.c
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +#include <linux/platform_data/psp.h>
> +#include <linux/platform_device.h>
> +#include <asm/hypervisor.h>
> +
> +static struct platform_device psp_device = {
> +	.name           = "psp",
> +	.id             = PLATFORM_DEVID_NONE,
> +};
> +
> +static int __init psp_init_platform_device(void)
> +{
> +	struct psp_platform_data pdata = {};
> +	struct resource res[1];
> +	int err;
> +
> +	/*
> +	 * The ACPI PSP interface is mutually exclusive with the PCIe interface,
> +	 * but there is no reason to use the ACPI interface over the PCIe one.
> +	 * Restrict probing ACPI PSP to platforms known to only expose the ACPI
> +	 * interface, which at this time is SNP-host capable Hyper-V VMs.
> +	 */
> +	if (!hypervisor_is_type(X86_HYPER_MS_HYPERV))
> +		return -ENODEV;
> +
> +	err = acpi_parse_aspt(res, &pdata);
> +	if (err)
> +		return err;
> +	err = platform_device_add_resources(&psp_device, res, 1);
> +	if (err)
> +		return err;
> +
> +	err = platform_device_register(&psp_device);
> +	if (err)
> +		return err;
> +	return 0;
> +}
> +device_initcall(psp_init_platform_device);