Date:   Tue, 31 Jan 2023 19:56:30 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     "Hans J. Schultz" <netdev@kapio-technology.com>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" 
        <UNGLinuxDriver@microchip.com>, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Russell King <linux@armlinux.org.uk>,
        Christian Marangi <ansuelsmth@gmail.com>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" 
        <linux-renesas-soc@vger.kernel.org>,
        "moderated list:ETHERNET BRIDGE" <bridge@lists.linux-foundation.org>
Subject: Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: implementation of
 dynamic ATU entries
Message-ID: <Y9lkXlyXg1d1D0j3@corigine.com>
References: <20230130173429.3577450-1-netdev@kapio-technology.com>
 <20230130173429.3577450-6-netdev@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230130173429.3577450-6-netdev@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?59CTpl4TQV/v720D2tBpKYjSs/4oq31pISbjOsrdQbIXVTbQ34ME/6Szf0fs?=
 =?us-ascii?Q?Ogln8IXnJ5VPlziw1IueeN9rC1aDUw22m97nqz1kz2C6ImYh/YGIWPYCcrgQ?=
 =?us-ascii?Q?6+Yb4Qnp/QcqpFfGK6TcJhls35gfXGT2cs53RY0WmZVFASoA5ut0vxbsydzN?=
 =?us-ascii?Q?+DJngslK8w+lKBdj7skrVdgGaMZHusqywu2mBar5awTuSVw6L6ClJr20XeeC?=
 =?us-ascii?Q?dwk6C8GZCSpT+5dinUeLvws7laXP20vcHThfe9iJ+PNCJApnVAJCukzB4xvZ?=
 =?us-ascii?Q?0X0hBJXVvz075biZDmzKeKsONzVsVTQl7AHHkfNKctISnUwWdNg4iG6WXg1M?=
 =?us-ascii?Q?B2BFKOU3TaIX7dun56/5mLxrFMj9SnLDeLABlapQHnoQ6SLceCgZutuZYr49?=
 =?us-ascii?Q?3GBya/rzTAHEwpgQ1j2a6YYpb+AVyb/NIfUvK1xlTY0jnm6U+ZAphp89Cnwu?=
 =?us-ascii?Q?3RH5OanyxLklXN/FFidqRkLNK5T9/fGZoAXRdhg4B1xrKp2yf1T4E9ZBGyZq?=
 =?us-ascii?Q?307ai39zRd/ZxDAnrklQ6Oe3CHqyG/ZuqR0iTOPkkvvg77zS9X7qxo1Y2XsC?=
 =?us-ascii?Q?tbx1JZldlfoXgDlOZRSFPOKzPt7eJ+QpZ2ETO/ktP0YXcXJx9OnUL3HSUPpg?=
 =?us-ascii?Q?EDJPr2kyeqtdEZxq+1DUCOJx4gwVNTxC8xUU792VhRrPL0ZnZkv1IKr8NkU4?=
 =?us-ascii?Q?i1J9AhG+ps08hd/kjBKD7Qr0YlVJ5dGNCPiXt9s458fT2xyh6peW/c+M9Jly?=
 =?us-ascii?Q?34Vns9lyo4NlHn5P97lJPpjpogAceIz7hhaRH+tIHAoeDF4AGkxW7ZXGYrXW?=
 =?us-ascii?Q?UVZd6jp3dgKjpmqbLb2sHXTFXQOFypelfeqE4vsgdqeYoD//JjL0iz/I2ro8?=
 =?us-ascii?Q?D7DMl4P0HcX+k6C0csQv5dDYjHBf0B/+R68NopJYvqYkZqISSf82s1NQVna/?=
 =?us-ascii?Q?cs0tdn5ZUuUQ9vmmKDiB68Xxl/JOpParMa5Sl98zS4mQoq3p8lM0H4+eQwnh?=
 =?us-ascii?Q?/wCokgva8O1yZoXvhjTgttHK8pGV5BnKTCf58WiHqW/p7wK36n/QUJlXTimW?=
 =?us-ascii?Q?SUn6Oztpdxzmg7EmlA/EWmYMR90efHT+l79kCzMxLCcxY7i1xN92oPc3ZqD4?=
 =?us-ascii?Q?CRjHmfWk2BSalSeZix3Q7lQwyH04GF0IuoOnyYmBXCNCEcAtSHmHV2+xXjwP?=
 =?us-ascii?Q?zlcyo2LivTMtjBnqfvtPnu6zmJ3NLkS14ua8mtPrnb9PuT1SUBECACifqosU?=
 =?us-ascii?Q?y4AyQV3maQ6Ks/3kw0LCDeh7oPvmujqdzp7g8jCXivFuGUcfdpYlMUV62wbH?=
 =?us-ascii?Q?u/1l6NbAbwgJ49XpdtApZy73sEuEExNjMKA0Ju/ltl8sLRPRQ3jfSbXVy7bJ?=
 =?us-ascii?Q?BfeeEgDIC30gPHvmJVljV7chrrbwc1KPNfHTTPNBGJDVEZEoAmCbfhJLXI8B?=
 =?us-ascii?Q?AfV96IH/AgHTVICGueHq8MDTCSNgxxR6zLicXewSVK8gMo+HLCCNTL7Y+1v2?=
 =?us-ascii?Q?VDQpj/VNdasAqi96gQagpl0RyU1GoChkiHmWChXw6IrjxWRpIeVK/H7YK2B4?=
 =?us-ascii?Q?QM0x2eWK4ldj1+979ae/EWNg+ymVIhdsWWKvA3FADF4U5Btu6uzQj1w/O5y4?=
 =?us-ascii?Q?FrSEjKTzj2iFmM/YL/QKkKN2xhwlluS1K1Rw0lSxG2054IMoMKNVwPFf1fBz?=
 =?us-ascii?Q?kklb5Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0498741e-0211-4ed2-55e9-08db03bce3a8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 18:56:41.3439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hd6ym8lC5j1YRE9xYmLJPB2pi8VfqXVFfS2iglmlGbwujUo8nXuYScB0sxPGMza8AP8vDLNZ3GUeOEeMuz+iBo9YANCY2+a+2Q7hDfpZA8A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5775
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 30, 2023 at 06:34:29PM +0100, Hans J. Schultz wrote:
> For 802.1X or MAB security authed hosts we want to have these hosts authed
> by adding dynamic FDB entries, so that if an authed host goes silent for
> a time period it's FDB entry will be removed and it must reauth when
> wanting to communicate again.
> In the mv88e6xxx offloaded case, we can use the HoldAt1 feature, that
> gives an age out interrupt when the FDB entry is about to age out, so
> that userspace can be notified of the entry being deleted with the help
> of an SWITCHDEV_FDB_DEL_TO_BRIDGE event.
> When adding a dynamic entry the bridge must be informed that the driver
> takes care of the ageing be sending an SWITCHDEV_FDB_OFFLOADED event,
> telling the bridge that this added FDB entry will be handled by the
> driver.
> With this implementation, trace events for age out interrupts are also
> added.
> 
> note: A special case arises with the age out interrupt, as the entry
> state/spid (source port id) value read from the registers will be zero.
> Thus we need to extract the source port from the port vector instead.
> 
> Signed-off-by: Hans J. Schultz <netdev@kapio-technology.com>
> ---
>  drivers/net/dsa/mv88e6xxx/chip.c        | 18 ++++++--
>  drivers/net/dsa/mv88e6xxx/global1_atu.c | 21 +++++++++
>  drivers/net/dsa/mv88e6xxx/port.c        |  6 ++-
>  drivers/net/dsa/mv88e6xxx/switchdev.c   | 61 +++++++++++++++++++++++++
>  drivers/net/dsa/mv88e6xxx/switchdev.h   |  5 ++
>  drivers/net/dsa/mv88e6xxx/trace.h       |  5 ++
>  6 files changed, 110 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 61d5dc4680e3..a0007d96b2a3 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -42,6 +42,7 @@
>  #include "ptp.h"
>  #include "serdes.h"
>  #include "smi.h"
> +#include "switchdev.h"
>  
>  static void assert_reg_lock(struct mv88e6xxx_chip *chip)
>  {
> @@ -2726,18 +2727,25 @@ static int mv88e6xxx_port_fdb_add(struct dsa_switch *ds, int port,
>  				  const unsigned char *addr, u16 vid,
>  				  u16 fdb_flags, struct dsa_db db)
>  {
> +	bool is_dynamic = !!(fdb_flags & DSA_FDB_FLAG_DYNAMIC);
>  	struct mv88e6xxx_chip *chip = ds->priv;
> +	u8 state;
>  	int err;
>  
> -	/* Ignore entries with flags set */
> -	if (fdb_flags)
> -		return 0;
> +	state = MV88E6XXX_G1_ATU_DATA_STATE_UC_STATIC;
> +	if (is_dynamic)
> +		state = MV88E6XXX_G1_ATU_DATA_STATE_UC_AGE_7_NEWEST;

What if flags other than DSA_FDB_FLAG_DYNAMIC are set (in future)?

> +	else
> +		if (fdb_flags)

nit: else if (fdb_flags)

> +			return 0;
>  

...