Message-ID: <cc2c8b52-43ce-48a0-600b-ada5fd67b8b8@linuxfoundation.org>
Date:   Tue, 31 Jan 2023 13:07:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2] ver_linux: add missing software to checklist
Content-Language: en-US
To:     Alexander Kapshuk <alexander.kapshuk@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230124204324.33858-1-skhan@linuxfoundation.org>
 <CAJ1xhMU3CPK9nLyx0ejqMt6KKcaeewsstQzUA7KKExumJ7hYzQ@mail.gmail.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <CAJ1xhMU3CPK9nLyx0ejqMt6KKcaeewsstQzUA7KKExumJ7hYzQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/26/23 01:02, Alexander Kapshuk wrote:
> On Tue, Jan 24, 2023 at 11:04 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> Update to add missing software checks to bring it in sync with the
>> Documentation/Changes list. Make improvements to the output with
>> separator between different sections.
>>
>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>> ---
>> Changes since v1: addressed review comments
>>
>>   scripts/ver_linux | 28 ++++++++++++++++++++++++----
>>   1 file changed, 24 insertions(+), 4 deletions(-)
>>
>> diff --git a/scripts/ver_linux b/scripts/ver_linux
>> index 1a8ee4ff0e32..2daee7e88c45 100755
>> --- a/scripts/ver_linux
>> +++ b/scripts/ver_linux
>> @@ -6,20 +6,29 @@
>>   # differ on your system.
>>
>>   BEGIN {
>> -       usage = "If some fields are empty or look unusual you may have an old version.\n"
>> -       usage = usage "Compare to the current minimal requirements in Documentation/Changes.\n"
>> +       usage = "Minimum required software versions to build and run current kernel version.\n"
>> +       usage = usage "If some fields are empty or look unusual you may have an old version.\n"
>> +       usage = usage "Compare with the current minimal requirements in Documentation/Changes.\n"
>>          print usage
> 
> The usage message is followed by three new line characters, the 1st is
> embedded in the last line of the usage message, the second is output
> by the print function, and the third by the leading new line character
> in the separator string.
> All other sections use two trailing new line characters instead.
> If the formatting of this section is desired to be consistent with all
> the other sections, this print function may be substituted with the
> printf function, which does not append a new line character to its
> argument.
> 

> 
> Other than that, LGTM. Thanks.

Thanks for checking this. Make sense to keep it consistent. Will
fix it in the next version.

thanks,
-- Shuah