Message-ID: <d48c157e-73d0-17c6-85c9-8753643ed03b@oracle.com>
Date:   Tue, 31 Jan 2023 14:51:03 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 1/6] vdpa: fix improper error message when adding vdpa dev
Content-Language: en-US
To:     Eli Cohen <elic@nvidia.com>, mst@redhat.com, jasowang@redhat.com,
        parav@nvidia.com
Cc:     virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <1675110643-28143-1-git-send-email-si-wei.liu@oracle.com>
 <1675110643-28143-2-git-send-email-si-wei.liu@oracle.com>
 <07f5a4cb-2a55-c774-6b23-d3fa6605cb43@nvidia.com>
From:   Si-Wei Liu <si-wei.liu@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <07f5a4cb-2a55-c774-6b23-d3fa6605cb43@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEVHZlk2dXdZUllFS2pHRUhENVluVitGRmU0emJaNkFobm11NE4wbWJONHVk?=
 =?utf-8?B?ZUJnc3lRUHhmbGZtZmttTkNNTWtPQ09EeUlpVlJXTVozUDF3ZTFQYXduUUxN?=
 =?utf-8?B?b0JrNWR0MlU5L1JqWDZSVzk3WFp1TjN1V0xadXRJVE1IT2Y3QUJRS0lORkpa?=
 =?utf-8?B?VGNhTGkrcjZtMUV5dGRWRTNMWm1kWVJIQWc4WDdQQWtudTlwaldIVGtGUDhQ?=
 =?utf-8?B?Wlpua3pzeXdPaHBJbE5acWdibjdqcDRWRUhlMytsZjNYMElFdnRYWG91Y0hy?=
 =?utf-8?B?bnc3bk54ZFFNTVZNc09XODNNVi9iY0JjV1hMeGNpa3NINGJoUzJLd2VxK2d2?=
 =?utf-8?B?aFZZSVNLdHZJcnhrb0ZNSjh6dnNGOW95RE5sSU5uQW1TT1Ivcm1LMU5ibmpJ?=
 =?utf-8?B?dzZlWDU2ZllZRUhuazJxRlMrdmJSM01aOWJELzlkOFdnNEN0M3JFRGhoNG42?=
 =?utf-8?B?dTFkQmUrd1NSaW40SGNEYUN5VmlnRTEwdVMySXF0UTk3Wmh0bThXT2dGOWdl?=
 =?utf-8?B?VXo2cUozRjJmTmNYSFZTaTlweG5sR20rbGhhYUNRaVdUYW5DVzlncGthRlpG?=
 =?utf-8?B?anNET1d4VzE3VnNoOXppaHNMNGhjMmJVR2t4SFpWMXhtTnB4L1l6N0ROaVpK?=
 =?utf-8?B?Rzcya0ZMSE9JNmJvWHlqTzlhOUk0ajU1UmtvMXFtNWRyTWJnb2I5SDNSNWN4?=
 =?utf-8?B?N2d4bU9WTDBkTkI2enJabDU1NWoreEtUS0x0OEJuemhFa2NPbm10L0wra2tD?=
 =?utf-8?B?RjFQYmgyRURkSStNdU9oYjNlTlNMUVZKaXlabk5GS3hqaVVyazI4YVV5RWZY?=
 =?utf-8?B?RVMzSFNzTXI3NFB1NTRlSWoraWFsTDJtNGc4QnVMZ0QwQWdpeGxMMHFEWmVx?=
 =?utf-8?B?ejJ5Yk13ejhHTWJRZWVKUWJsa2VFN1J4d2FuRnQ0di93Ulowblc1eUxvVEJI?=
 =?utf-8?B?TnpCRW5LMUxHU1djTDFpajVHMTdKa2VrUys4d1RrUmx0akhGb3kyaEtZamdx?=
 =?utf-8?B?ZTg2SFFIcFY0dTJab01rdVNpWmQ5Wk5jQmhkMFZwem16RHJGaEpDRWJyaEJE?=
 =?utf-8?B?TEVnTE0vYmplSTZFV1hnU3IwQ3J6SHdENUNzQ294WGdwbVkrMGkxLzc3Ymo5?=
 =?utf-8?B?OTRaMklQb3EwV3Fib2EzemFhZ0ljenhIU3JoeDFySW5KR29XYStTSkc3aUow?=
 =?utf-8?B?dHBCcE1aaEQwWU1DenhWZk5aVGlYTjNQbXZTWDJTK0tNTnZkcGtZMlkrTGs0?=
 =?utf-8?B?bHdZbW90TW9CS3I1UVFOMTNvMlVlVythaVkyOGhVTCtkenk0YytuM2E1d1R1?=
 =?utf-8?B?eW9zR1ZGckdvT0tKUFY0NXJUOTNlTmU3bHcxRjRZb1ZMQ2Y2cERqTFV6U1Ru?=
 =?utf-8?B?TzY2T1Z3QnEwOUx5VHRKMHhVZE9jc2YweE0rSlJZc2RnSW16ZjduM25YU0du?=
 =?utf-8?B?bXRqMEIrYnpyUFhGSTd0MHYwRmlJZEIyTldCU1dndCtEeUNFTGY2YzQ4Tms1?=
 =?utf-8?B?ZWlsWjRDdjQxTDJpYm1zN2cxbm1QWkxsWHBmakc2OUhwWU4wN1hScWhLV3ll?=
 =?utf-8?B?Z2Zjb21JQWJaZGVjVWZoUzFXV1NTR1MyK2lDMGFTb2VTaGlyWksreW55eDFs?=
 =?utf-8?B?UVRiN2ZiUUFYeU00YUJvekpFdkhUUXhTcHV2MVdmQi9sT3EvR3huL29xM1ZM?=
 =?utf-8?B?cUJnNXNIdXlxQ0FJaGh4NTljTUJaVXFOSkw3V1JIdmFyZnlxSTJRUldWelR0?=
 =?utf-8?B?b2JyMXdFRWxzWFNpNUM5blRyQlkzcDhaa0s3T2JJYldrcVpncDIzNWRnRVVy?=
 =?utf-8?B?T015UTc2Z2M5b0lrNXVLNWU4TlU1MllIRUFPSW5LbFBrWXlRU0N6RFFyWnU2?=
 =?utf-8?B?MmJHaEM0UWNLanJmaFo2dVMraGhZaWpoK2xLNDJ6NlhERG5CUXNUQjk5d0VL?=
 =?utf-8?B?ZXRCbnJqbm9OZlJRaUV4SnRxYkxVSUFvRnR0Vyt2R3Z3VmNpYWV0N0hXTTlh?=
 =?utf-8?B?V000OGJPOTk3bzlJQ3RwS3dtbk1QSHNGOHNZM3hMbkYwYXNxYzZDbjQ4OUpZ?=
 =?utf-8?B?bW4zdzQ4SzF5U2FUYTBmd3g0bjNZdXFVUlIrMnhPMktmRVNOWkdyamxJemQ3?=
 =?utf-8?Q?IIvaxe2w/JHYbJc0ALMUIQgcC?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: l93HzhxY3NJ3cTZK8G7ddbXJ95tgeiznLZ5pVdbek7aXfat72+TiyhfZcr5LK8vbXpkNLXE396L6hmFHBJ4Vfl3JJNghtwF8Iqbs6xQyDF94+4qu3ExOSSSPFwy2HSmvuPz3dZHvSo8v0SsVRKDCLEflv4r8iEmMwvS2b7EYDqdg1/5PV2/bVM4NC0bqVpaET7HTZhXBxQI/GRP/Q7XGL63GTL7nv6TdSmipSFMguKkjlFEcrKl17UlU/RWjVOLI9Kkpk/8fcFcUTSoXf6HmJBZdGPfLqtAnWG2EmecEF7NfZ8xvhVWwmSrfEXlpSzl4SXZVeHHGCfAuGNWsaH3ClFwNFPrZyj/fnxLN1x0Jf+rM+izdFJQR5Z0FnsY9sn6axnLMcW3PYxpvn9N98wU0XugYJEcxjsMOfXFbHjFcOyOO0iGIXL3WwPhBSBMGGmJT8f6IVprtUD8WksaawDkp+CJIJW7hB/yCaEJhpcfulwnLZwe2CKdMyh/ZGt8zRWA8jEsV+gVWV994aD8Y63nelzIVf0aKvhyrFfMjL7dtUw6QhsAejU7zfGBNIOco0ag0HkgQHEEcK7lqejowA+Cr4oITyGadQbuiHgOEpSH0mv72pUF2e5ixToXiULBDt31w9O9JHXY8XxTiJu3DzXDYi5Lw/Oxklqx9XhBJcqUd9uMi/BmdacXzlR5Jmue2bT0zCG6Han7ViOMT29WV/WycgtrRk/vBclihng0AQGM+nNwMJZXe+Ve0l4dJ1odLt9dYVyzpswwqksd9w+PGKnoztQJAHWiaFWEFByTQNkXfS717qAAunNWD6gQs/x2uTqP9kVEaHR23MHNc4H0eMFa1fSnwr9bPHhSrwN/u+5gaQ3Rp3or/ldU7LSy6SWEj1ZL5kgqcfwV2anE4F39Qn6Qs6Q==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c532f54-6297-4088-4971-08db03dda40c
X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6535.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 22:51:07.9699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aPSXFzidDLsOrjsAR+065a15qPNg/qtoX/anPJ0JQEfVE2pxuxQhWyWUkYDupO4ABqsxkJ8nDJ53uZT1/YNb/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4639
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-31_08,2023-01-31_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 malwarescore=0
 spamscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301310196
X-Proofpoint-GUID: L4_AXiD_t9KdMT71gMi5Qg63Fv34RVyB
X-Proofpoint-ORIG-GUID: L4_AXiD_t9KdMT71gMi5Qg63Fv34RVyB
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/31/2023 3:42 AM, Eli Cohen wrote:
>
> On 30/01/2023 22:30, Si-Wei Liu wrote:
>> In below example, before the fix, mtu attribute is supported
>> by the parent mgmtdev, but the error message showing "All
>> provided are not supported" is just misleading.
>>
>> $ vdpa mgmtdev show
>> vdpasim_net:
>>    supported_classes net
>>    max_supported_vqs 3
>>    dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 
>> ACCESS_PLATFORM
>>
>> $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000 max_vqp 2
>> Error: vdpa: All provided attributes are not supported.
>> kernel answers: Operation not supported
>>
>> After fix, the relevant error message will be like:
>>
>> $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000 max_vqp 2
>> Error: vdpa: Some provided attributes are not supported.
>> kernel answers: Operation not supported
>>
>> $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 max_vqp 2
>> Error: vdpa: All provided attributes are not supported.
>> kernel answers: Operation not supported
>>
>> Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
>> Acked-by: Jason Wang <jasowang@redhat.com>
>> ---
>>   drivers/vdpa/vdpa.c | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
>> index 8ef7aa1..5e57935 100644
>> --- a/drivers/vdpa/vdpa.c
>> +++ b/drivers/vdpa/vdpa.c
>> @@ -622,13 +622,20 @@ static int vdpa_nl_cmd_dev_add_set_doit(struct 
>> sk_buff *skb, struct genl_info *i
>>           err = PTR_ERR(mdev);
>>           goto err;
>>       }
>> -    if ((config.mask & mdev->config_attr_mask) != config.mask) {
>> +    if (config.mask && (config.mask & mdev->config_attr_mask) == 0) {
> If config.mask is zero than the condition is false even without the 
> change so I don't see why is this change needed.
This way it spews error message when none of the attributes provided by 
user is supported by device.
I can remove the check if improving error message for the other check 
right below, but that is the expected conditional if the same error 
message has to be kept.

>> NL_SET_ERR_MSG_MOD(info->extack,
>>                      "All provided attributes are not supported");
>>           err = -EOPNOTSUPP;
>>           goto err;
>>       }
>>   +    if ((config.mask & mdev->config_attr_mask) != config.mask) {
>> +        NL_SET_ERR_MSG_MOD(info->extack,
>> +                   "Some provided attributes are not supported");
> Changing the message is needed but maybe list the attributes that were 
> specified but are not supported?
If you can live with numeric representing the attributes instead of 
straight attribute string, certainly I can do that. Or else I anticipate 
userspace to query and fail the command rather than present attribute 
strings in kernel.

-Siwei

>> +        err = -EOPNOTSUPP;
>> +        goto err;
>> +    }
>> +
>>       err = mdev->ops->dev_add(mdev, name, &config);
>>   err:
>>       up_write(&vdpa_dev_lock);