IronPort-SDR: xawAdefHAW4EOUsoci011izY4NK95B9nDQ6l7AbVWh5vQCr0B0e8m1PHh9DXUw+xUhAy0VizPR
 GjEUS9oeOeZ/8EnX6PEkUJEYD85UP1kCg9/fJPUUkdOwiOMlbZdVL3NDvSinFyHb7UK05ssvx+
 4QK38V2WfTJgApNAiGtKxoArApqs70y5mw8souYJTk2B6obvuPbxPFHUlFUnUvU//ZeQwxPnSH
 7LXOewOlUPPM5Mfg+QJdOILaOG+9LKjKF+NGKE1bN5gU2e/HHSGycl+r0+uM5wGyoVzrmFAz+s
 4ac=
IronPort-SDR: hYX6ILSbjbdXZxPA5OGKQsFwy+duiN2oND7ylrJu1PXb0gpqkNSVCUqAxETg+YT2iPuoGJlBkN
 iCcJ0m6iBpqbQcIDQLtYiaHqiqXR1UvY90FQobx+jhdq5zFTX7BhXUioyB3/dtarEHODTh1YJf
 800ODWMLhy2bGbq1QcRNNJmca6ZJL4u7zu0JdQiuqHS0AoV+55gtObQC3hdMorl6IW+y/V5VTg
 us/QvBkhRwfelqrcTIQgftkmEmjLXeyfjD3/EWaPkODUxR01F55hlHHe7FVqOme7CMdEPuqo11
 Emc=
WDCIronportException: Internal
Message-ID: <ec536f74-00d7-1f25-e903-278809e33ed9@opensource.wdc.com>
Date:   Wed, 1 Feb 2023 08:45:43 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH] libata: clean up some inconsistent indenting
Content-Language: en-US
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20230131085431.30549-1-jiapeng.chong@linux.alibaba.com>
 <d8d117bf-4ab1-3473-85e2-00f1b1a85cba@opensource.wdc.com>
 <d5a59ca8-1b17-9cf2-80d0-3e267e558fd5@omp.ru>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <d5a59ca8-1b17-9cf2-80d0-3e267e558fd5@omp.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/01/31 21:33, Sergey Shtylyov wrote:
> On 1/31/23 2:26 PM, Damien Le Moal wrote:
> [...]
>>> No functional modification involved.
>>>
>>> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.
>>>
>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
>>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>>> ---
>>>  drivers/ata/pata_serverworks.c | 7 +++----
>>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
>>> index c0bc4af0d196..c6bd9e95d4e8 100644
>>> --- a/drivers/ata/pata_serverworks.c
>>> +++ b/drivers/ata/pata_serverworks.c
>>> @@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
>>>  		 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
>>>  		 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
>>>  
>>> -		 /* If the returned btr is the newer revision then
>>> -		    select the right info block */
>>> -		 if (rc == 3)
>>> -		 	ppi[0] = &info[3];
>>> +		/* If the returned btr is the newer revision then select the right info block */
>>
>> Very long line. Please make that a proper multi-line comment.
> 
>    Perhaps the material of a separate patch?

Since this patch touches this comment, the fix should be correct from the start.
I do not see the point of having a different patch fixing a patch that was ideal
to start with...

> 
>> And the patch title should be:
>>
>> ata: pata_serverworks: clean up indentation
> 
>    Yes!
> 
> [...]
> 
> MBR, Sergey

-- 
Damien Le Moal
Western Digital Research