MIME-Version: 1.0
References: <20230130131024.695212-1-arnd@kernel.org>
In-Reply-To: <20230130131024.695212-1-arnd@kernel.org>
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date:   Tue, 31 Jan 2023 15:57:37 -0800
Message-ID: <CAKdAkRRnjdsQC_4qsjtHY1FfuPZ9vmV6gjDOeCzp7CZQATcUrw@mail.gmail.com>
Subject: Re: [PATCH] rtc: moxart: convert to gpio descriptors
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Arnd Bergmann <arnd@arndb.de>, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 30, 2023 at 5:29 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The conversion is fairly simple as the driver only has DT based
> probing, and all the gpio calls have a direct replacement.

This is plain broken :( You cannot directly replace
of_get_named_gpio() with non-standartly-formatted GPIO name with
devm_gpiod_get().

Thanks.

-- 
Dmitry