Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCECBC636CC for ; Wed, 1 Feb 2023 00:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231513AbjBAACx (ORCPT ); Tue, 31 Jan 2023 19:02:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbjBAACv (ORCPT ); Tue, 31 Jan 2023 19:02:51 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 904ECBBBB for ; Tue, 31 Jan 2023 16:02:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B2666174F for ; Wed, 1 Feb 2023 00:02:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 569E7C433EF; Wed, 1 Feb 2023 00:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675209769; bh=5Srq1O2KuNIxWH0+F/0WWOchIrwFyeA9St4yKoY3ayQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qga3HTCCxVHmJ0VWi2DXf9Bta7EyB/LmEI5FnCHtol8Ub/xWoiI24u9rgir8SfXA6 GPMPuPq+mQfE3ul1saD+Qoz5X50VsHWXhUNZQGHAEkemk6yUh0U3p1boumbtFsN6MK O6sjC903CUADrM7JnqaXUTIDAHTZAlfw88wC6zxZZW2gRsVFHgLq2CSRJM+V7RZ3uK 0r7vwtSU8pT8HBma9RuSFg20vsyALFooiTDZrSTerOK+AyPbIbpIBNZUETaMcl4VIW lM9AUsTUo65s/HtjYky1o607OuZSjqsSHWi0wwOMHEi2PdiV0i2UfgnIDiNc+V40NT KJDfTSfOwTxjA== Date: Tue, 31 Jan 2023 16:02:47 -0800 From: Josh Poimboeuf To: "Paul E. McKenney" Cc: Peter Zijlstra , sfr@canb.auug.org.au, linux-kernel@vger.kernel.org Subject: Re: objtool warning for next-20221118 Message-ID: <20230201000247.3x3jev6xxxxkfrnm@treble> References: <20221122051605.4hcbslwxez2trdvt@treble> <20221123002258.GR4001@paulmck-ThinkPad-P17-Gen-1> <20221123014812.7gptbvvndzemt5nc@treble> <20221123174951.GZ4001@paulmck-ThinkPad-P17-Gen-1> <20221123181941.fh4hrr3pazelwtxc@treble> <20221123191242.GG4001@paulmck-ThinkPad-P17-Gen-1> <20221123223214.gxwyrakfj7nbs2fb@treble> <20221123230612.GM4001@paulmck-ThinkPad-P17-Gen-1> <20230128190634.GA1043262@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230128190634.GA1043262@paulmck-ThinkPad-P17-Gen-1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 28, 2023 at 11:06:34AM -0800, Paul E. McKenney wrote: > Sorry to be a nag, but I am still seeing this. Not a huge problem because > I now filter it out so that it does not get in the way of other bugs, > but I figured that I should follow up. Does this fix it? (works for me) If so, I'll need to extend it for all arches. diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 40d156a31676..5db0daba750f 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -712,6 +712,7 @@ void arch_cpu_idle_enter(void) void arch_cpu_idle_dead(void) { play_dead(); + BUG(); } /* diff --git a/include/linux/cpu.h b/include/linux/cpu.h index 314802f98b9d..7fbbd1572288 100644 --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -185,7 +185,7 @@ void arch_cpu_idle(void); void arch_cpu_idle_prepare(void); void arch_cpu_idle_enter(void); void arch_cpu_idle_exit(void); -void arch_cpu_idle_dead(void); +void __noreturn arch_cpu_idle_dead(void); int cpu_report_state(int cpu); int cpu_check_up_prepare(int cpu); diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c index f26ab2675f7d..921b8b3e3d0c 100644 --- a/kernel/sched/idle.c +++ b/kernel/sched/idle.c @@ -71,7 +71,7 @@ static noinline int __cpuidle cpu_idle_poll(void) void __weak arch_cpu_idle_prepare(void) { } void __weak arch_cpu_idle_enter(void) { } void __weak arch_cpu_idle_exit(void) { } -void __weak arch_cpu_idle_dead(void) { } +void __weak arch_cpu_idle_dead(void) { while (1); } void __weak arch_cpu_idle(void) { cpu_idle_force_poll = 1; diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 4b7c8b33069e..a9cb925bf095 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -167,6 +167,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, "__reiserfs_panic", "__stack_chk_fail", "__ubsan_handle_builtin_unreachable", + "arch_cpu_idle_dead", "cpu_bringup_and_idle", "cpu_startup_entry", "do_exit",