From:   Song Liu <songliubraving@meta.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Song Liu <song@kernel.org>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Kernel Team <kernel-team@meta.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v4] module: replace module_layout with module_memory
Thread-Topic: [PATCH v4] module: replace module_layout with module_memory
Thread-Index: AQHZNNeuHVNEhGQ600u3kQvatUZkaq64YMyAgADgNYA=
Date:   Wed, 1 Feb 2023 00:37:33 +0000
Message-ID: <DE7832AA-27B1-4C06-A82C-5FA4EF7CF7E6@fb.com>
References: <20230130182109.3571524-1-song@kernel.org>
 <Y9j4LYijtFZzkKHa@hirez.programming.kicks-ass.net>
In-Reply-To: <Y9j4LYijtFZzkKHa@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HLKjhmoEwfePjSEppGMoss0d4dfOEDZa1/BsiJPl63QFBQ2L5J73YP+Ttz3v?=
 =?us-ascii?Q?I9gJqc7rqJCv4NlGID1c7qpagXG0johBTNMCcXzMmUOdZSWIIYTxqIwnrt5g?=
 =?us-ascii?Q?jJ1IgdgcLG3Hzo6Mvm2MBTYeDSv66GBwe86ZH8O0crOqgDC1A6fLfuVurJen?=
 =?us-ascii?Q?R/EKTfBvtyd/ZwUlhyWO5STfKc4slL70OCwmXo9plMWyDirfP3QZUyp44k7u?=
 =?us-ascii?Q?D5+0cR5i/S/kXbRdbythZukf8E7iyJyt0fet77GMNOPtkD0bLsx4Rxfjlkuz?=
 =?us-ascii?Q?HkxKW8M7NHr4UxpkQnD6JJfuhLHhgUnes9pVCO/0lMvc0dKSHxmA69sw2hJI?=
 =?us-ascii?Q?Yn5pnz85YbCqxzT7GpkaaD3dhpXIeZaUhrO21MAG36xTIPKVbwn+zX9fNJC+?=
 =?us-ascii?Q?to1sx2N5CN+KfJ9QGQlJOPe3qK/Pkkdm+cKVRJLytjdYOEpt6T8x07qotq4W?=
 =?us-ascii?Q?9cKbEDaffk5r+vP/JC+7TOtwZwDPfRURxuTrrOOW3SLa9vTLmYNT0zt5AeyU?=
 =?us-ascii?Q?f+sQsVmfdxsrzotlyr3fDDK4/R1sLMvLEkxYpbHRA9uvb1tNxSwzDebs3p1a?=
 =?us-ascii?Q?h0MPfbo5HhzaBXxgSq5dxTNu5wP+o/Onvi0sRnYUFvNpdTujiwf8DfYTLkes?=
 =?us-ascii?Q?x77izAtPUd9jhP7Xu7F8S2+994T3kct0s1e3KLbotm4wNZ4CLsYxXYUxxG5f?=
 =?us-ascii?Q?eSuLA1b+KW+DF1kmxbcfjgYJ1E4QNcpNMvyALxYxxHLTLoTs7B56K1hwsfPv?=
 =?us-ascii?Q?lJ0L/cI+06PYZCDQCEAPhwfEI2te2nP/O2KLgsW1UprHeigeyI0N8cLUxiHP?=
 =?us-ascii?Q?dbK+9kPDVQtO5vChSWRUWhwXDyWn9wWw2sIpsHZrObhL75HWNOECy1vEeMT5?=
 =?us-ascii?Q?t+i3MkFPHCIwh1BEMKZDXBrKRlYeTi3lQGNv/PWawB5J5kyjmtsDi06V6kTL?=
 =?us-ascii?Q?sNAo0TNXhosmPHYBMvvwsJUXyp4hqcqBTbA2oMxKQRCGnCwvr9+JmJnHUPbi?=
 =?us-ascii?Q?mDIfnEOCCXLO8IHwt7PZC16nivEgvNsgU9NwE5zLT5s4fZlxhmNZR3Lv6LOr?=
 =?us-ascii?Q?5LXADazI/rzxcKR1VVNzVtrCP5CsFKkI7iVFsMqtOVi2r++aCSRfpPKYTP30?=
 =?us-ascii?Q?HsrRl2Lj/T0nQ065GEbbnhZqFlaEecVjbz3ChgbFRKWVpbgrzaa1/DYU8wLC?=
 =?us-ascii?Q?jmV/pVhf8lq/tuQom0/EmwNMGqCZ3ed7YYnLzZYgLkj+SrVLsH70CC0GGPWx?=
 =?us-ascii?Q?s61I+47lUCYDownfB/ZmJF5YSvWCoy/V8JAIKWJ2cwD/TTum6mlGK0pTk/jb?=
 =?us-ascii?Q?nT2sRHV1o6DSbgpySVr2L/eEf+bBEryV57G01g7Kc/iIvqTs/h+p46Ol2tUI?=
 =?us-ascii?Q?WWppEIr7XK++5Xxrt3G8jpeLJbXPgTnPwFLklLYIn1mqji2cDB74nxTUngfq?=
 =?us-ascii?Q?+9ZELLoBxZOnlFCYej6oMYVVs3clqw1d8IZPTehxsdzN0CC6ITG5sGcSkEDj?=
 =?us-ascii?Q?9h4vJuTNnjfh6fz1D/76UOUwIfY7jSmlgX7BhkD+rx3cZLvbtRhKnP5Gbeb8?=
 =?us-ascii?Q?XQxhc9nPpdnm8+2aGeVh3vN/QLohsypV824rviGOhAZkJUBE6SGkGv7WJe8j?=
 =?us-ascii?Q?mLg9clLFsEz/R/Y96qz2uhntiL4qtfrjjcYKGfZlK72G?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E3AA0D76578837458BED1D4B2F86BF99@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f9e2464-b741-4717-f5c5-08db03ec8218
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 00:37:33.2271
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +pGvj1F0wW3ycA2pQ6CUyCZYzJ95djDk84bwYLN1E0FDuGHwKW7zBQFqgt9QLRac7+OCxhJRzpamITlNE+kaJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR15MB4043
X-Proofpoint-GUID: AA_5uyTyY8GP3eJAQVoZweYtUIbm_19v
X-Proofpoint-ORIG-GUID: AA_5uyTyY8GP3eJAQVoZweYtUIbm_19v
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-31_08,2023-01-31_01,2022-06-22_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks to all for these feedbacks. I will fix the code and send v5. 

> On Jan 31, 2023, at 3:14 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Mon, Jan 30, 2023 at 10:21:09AM -0800, Song Liu wrote:
>> +#define for_each_mod_mem_type(type) \
>> + for ((type) = MOD_TEXT; \
>> +     (type) < MOD_MEM_NUM_TYPES; (type)++)
>> 
>> +#define for_core_mod_mem_type(type) \
>> + for ((type) = MOD_TEXT; \
>> +     (type) < MOD_INIT_TEXT; (type)++)
>> +
>> +#define for_init_mod_mem_type(type) \
>> + for ((type) = MOD_INIT_TEXT; \
>> +     (type) < MOD_MEM_NUM_TYPES; (type)++)
> 
> #define __for_each_mod_mem_types(type, _from, _to) \
> for (enum mod_mem_type type = _from; type <= _to; type++;)
> 
> also to be used in the previously suggested within_module_mem_types()
> function.
> 
> also note the C99 variable in for-loop decl thing

Aha, I didn't realize we started using C99 for-loop decl. 

Thanks,
Song

> 
> #define for_code_mod_mem_type(type) \
> __for_each_mod_mem_types(type, MOD_TEXT, MOD_RO_AFTER_INIT)
> 
> #define for_code_mod_mem_type(type) \
> __for_each_mod_mem_types(type, MOD_INIT_TEXT, MOD_INIT_RODATA)
> 
> 
>