Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966204AbXHaS4Y (ORCPT ); Fri, 31 Aug 2007 14:56:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965634AbXHaS4P (ORCPT ); Fri, 31 Aug 2007 14:56:15 -0400 Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5]:52988 "EHLO grelber.thyrsus.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965547AbXHaS4O (ORCPT ); Fri, 31 Aug 2007 14:56:14 -0400 From: Rob Landley Organization: Boundaries Unlimited To: Satyam Sharma Subject: Re: [PATCH] Documentation/00-INDEX notice ecryptfs.txt moved. Date: Fri, 31 Aug 2007 13:56:10 -0500 User-Agent: KMail/1.9.6 Cc: Randy Dunlap , Linux Kernel Mailing List , Andrew Morton References: <200708301446.18024.rob@landley.net> <200708302016.12133.rob@landley.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708311356.10826.rob@landley.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2085 Lines: 61 On Friday 31 August 2007 7:10:00 am Satyam Sharma wrote: > Hi Rob, > > On Thu, 30 Aug 2007, Rob Landley wrote: > > On Thursday 30 August 2007 2:04:37 pm Randy Dunlap wrote: > > > Please use the expected (canonical) patch format. > > > > > > See Documentation/SubmittingPatches: > > > 14) The canonical patch format > > > > from Rob Landley > > Signed-off-by: Rob Landley > > > > ecryptfs.txt moved into filesystems, make 00-INDEX follow. > > That's still not quite right :-) What Randy meant is that the sign-off > must come /after/ the patch description: Randy emailed me about it offline and I updated my wrapper script. I've always had a bit of a blind spot when it comes to filling out forms (I suck at bureaucracy), so I made a script to do it, currently: #!/bin/bash echo "From: Rob Landley " echo echo "Signed-off-by: Rob Landley " echo "---" echo cat $1 | diffstat echo cat $1 I note that the example uses "From:" but the summary refers to it as the "from" line with no capital letter or colon, and unix being case sensitive I reproduced the quoted string verbatim. (See "I suck at bureaucracy", above.) > [ All this is not too important, admittedly, but causes least amount of > processing time to be wasted on the recipient's end, and also does not > confuse scripts that may be used to extract patches (and git commit > command-line arguments) from mails automatically. ] If it's going to be parsed by a script, it might as well be generated by a script... I've got another dozen of these patches to send, but I'm waiting to see which ones Jesper Juhl has queued up first. :) (Between the two of us, we'll get this updated eventually...) Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/