Message-ID: <6cd98ec5-3d0e-eb91-b2a5-9781439ae483@linaro.org>
Date:   Wed, 1 Feb 2023 08:23:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 5/6] dt-bindings: hypervisor: Add dt-bindings for VMBus
Content-Language: en-US
To:     Saurabh Singh Sengar <ssengar@linux.microsoft.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, daniel.lezcano@linaro.org, tglx@linutronix.de,
        virtualization@lists.linux-foundation.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org, mikelley@microsoft.com,
        ssengar@microsoft.com
References: <1675188609-20913-1-git-send-email-ssengar@linux.microsoft.com>
 <1675188609-20913-6-git-send-email-ssengar@linux.microsoft.com>
 <9a3bbaf0-eb1d-613a-a8ba-272896ef2da8@linaro.org>
 <20230201015723.GB20379@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230201015723.GB20379@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01/02/2023 02:57, Saurabh Singh Sengar wrote:
> On Tue, Jan 31, 2023 at 07:54:56PM +0100, Krzysztof Kozlowski wrote:
>> On 31/01/2023 19:10, Saurabh Sengar wrote:
>>>
>>> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
>>
>>> +  - |
>>> +    / {
>>> +        compatible = "foo";
>>> +        model = "foo";
>>> +        #address-cells = <0x02>;
>>> +        #size-cells = <0x02>;
>>
>> Except previous comments (all of them were ignored),
> 
> Thank you for your comments, I have tried to address them all in this version
> but I may have missed few. I will go and look again all the emails, but if
> there is any thing which you can point again and we can start a new dicussion
> from here will be very helpful.
> 
> I think one concern was related to use of 'reg' or 'ranges', and I 
> thought this patch will give clarity that I intend to use 'ranges'
> without any child node. Is this acceptable ?

There were several comments.

> 
> 
>> also:
>> Drop entire part. Not related, not correct, not helping and you cannot
>> have top level nodes in example.
> 
> If I dont use the top level node, the parent address cells are assumed to be 1,
> and I get below warning. If there is better way to address this warning, please
> suggest I will work on it.
> 
> Warning (ranges_format): /example-0/vmbus@ff0000000:ranges: "ranges" property has invalid length (20 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1)

Then use soc just like every other example.


Best regards,
Krzysztof