Date:   Wed, 1 Feb 2023 10:38:45 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Ajit Khaparde <ajit.khaparde@broadcom.com>,
        andrew.gospodarek@broadcom.com, davem@davemloft.net,
        edumazet@google.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, michael.chan@broadcom.com,
        netdev@vger.kernel.org, pabeni@redhat.com,
        selvin.xavier@broadcom.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH net-next v9 0/8] Add Auxiliary driver support
Message-ID: <Y9olFRJCY980EuRX@unreal>
References: <20230131052557.99119-1-ajit.khaparde@broadcom.com>
 <20230131211228.78dae343@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230131211228.78dae343@kernel.org>
Precedence: bulk

On Tue, Jan 31, 2023 at 09:12:28PM -0800, Jakub Kicinski wrote:
> On Mon, 30 Jan 2023 21:25:49 -0800 Ajit Khaparde wrote:
> > Add auxiliary device driver for Broadcom devices.
> > The bnxt_en driver will register and initialize an aux device
> > if RDMA is enabled in the underlying device.
> > The bnxt_re driver will then probe and initialize the
> > RoCE interfaces with the infiniband stack.
> > 
> > We got rid of the bnxt_en_ops which the bnxt_re driver used to
> > communicate with bnxt_en.
> > Similarly  We have tried to clean up most of the bnxt_ulp_ops.
> > In most of the cases we used the functions and entry points provided
> > by the auxiliary bus driver framework.
> > And now these are the minimal functions needed to support the functionality.
> > 
> > We will try to work on getting rid of the remaining if we find any
> > other viable option in future.
> 
> Better :)
> 
> Leon, looks good to you as well?

Good enough, we beat this horse to death already.

BTW, it still has useless NULL assignments and variable initializations.

+       aux_priv->edev->en_ops = NULL;
+       kfree(aux_priv->edev);

Thanks

> 
> Note to DaveM/self - this needs to be pulled rather than applied:
> 
> > The following are changes since commit 90e8ca0abb05ada6c1e2710eaa21688dafca26f2
> >  Merge branch 'devlink-next'
> > and are available in the git repository at:
> >  https://github.com/ajitkhaparde1/net-next/tree/aux-bus-v9