Message-ID: <30b1aa51-2fac-16b8-8fba-e82a88e3219d@nxp.com>
Date:   Wed, 1 Feb 2023 10:41:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2] remoteproc: imx_dsp_rproc: add custom memory copy
 implementation for i.MX DSP Cores
To:     Peng Fan <peng.fan@oss.nxp.com>,
        "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "S.J. Wang" <shengjiu.wang@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Paul Olaru <paul.olaru@nxp.com>,
        Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Cc:     linux-imx <linux-imx@nxp.com>, linux-remoteproc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Pengutronix Kernel Team <kernel@pengutronix.de>
References: <20230131170436.31280-1-iuliana.prodan@oss.nxp.com>
 <abd74bb6-9131-3769-513f-954234981403@oss.nxp.com>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <abd74bb6-9131-3769-513f-954234981403@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmEyblNWeUcyQ2FFOHBCRkY3RWR1WVltekZ5UmFVb2lqNmc3K3BOeWRRSkJM?=
 =?utf-8?B?STR1V3V5dE8yYUgyZGZEc2Q5L2tPT1NubFZmbndsVml1WjYyOFVtaEpaaTFi?=
 =?utf-8?B?bXRlVUMzemM1RGFJS1lXZVo0VXhDSDErU3duRERPQ3JaV3RLTytHclh2MHZD?=
 =?utf-8?B?WVJRL0NWTzNGTHlOdGs1NFZOVGRZSHRQa3Z1eHFLR1VITU4zRTcwZHNxTnVX?=
 =?utf-8?B?UnBIUFBJMVQydkhaRSsvWGNya0tsWTJ1aVREZ1kxZEp5d0RBTkxCM2pXNWQr?=
 =?utf-8?B?ZGNiSEMwU0UvZ2FHcnRpWjRCSE5zdFVNUHFqbHpXSkdQa2hQRnFrMWV0VE1N?=
 =?utf-8?B?YlZ4dktOc0FyeWNBa25sbkttcHJwZlkxQllFTVo1NTF3UzExVmFqNXJvczd5?=
 =?utf-8?B?Q3dYNWsrOFNCM0JOOUlRM3J3bUxmQmdZeWZqVVZ1eUFiS0I1YkpOOGFoRU1s?=
 =?utf-8?B?eDI5L2M4QTIxMjltWHhhK3JVQ2FralI5RHRwbWlaQmpGQW9BdDJudmZaY0xB?=
 =?utf-8?B?N1dmQTM5RDZvbEJjejBNK091UHNManhCSHVWWE0valE1L2hjTlo3SDlHUnVV?=
 =?utf-8?B?QXV4Z1NIcENOUlNYMVN1c1Zxc0xzR1B6Z21Qcy95bEwwUGNRK2JBbnQ3YS94?=
 =?utf-8?B?WENGMVBtVHlpNXVFZUhKUFVIdURGeXY5VHRFcDNNNWYxVWlzTm94NlpBUE9m?=
 =?utf-8?B?M1hqQkFJaFBpRG5Eem5teHNkaEtpcVRNc1BocW93KytMZzkvNXNKQ1c4bFdi?=
 =?utf-8?B?bXZlZmFISXM1aXoxcW01WUJkd1dFTkdmVjY3L2lJVzlnbkszVmlhVnArdGlP?=
 =?utf-8?B?MGpUUE1uUWZQT2ZXVXhWdjE2N3dzQWRNQzhkaE4rY3cvbU95cUZnMGxRUjU5?=
 =?utf-8?B?amRpQ09PL1NLWGR4UTdWWGUzOXIrOGhGMVk3eExYZlJvMGZESjlvRG16R2JN?=
 =?utf-8?B?cll5L00xVnFHSngyMzh5bnc1MG1Ub0lDQkR1d1VvMlk3QjZZUS8zc3RqVkxt?=
 =?utf-8?B?NG9jNjQwWVpUNVdJeUp6bmF5SFlsdU0xWkdhMS82cDhPNHdGeVk4eHVLa3Iy?=
 =?utf-8?B?Qjk1dFVUY2ZQUUlRTWN0a0N0ZVlBTW9VSmJWWVE1MUZLZm9NbnVHSFRtckE2?=
 =?utf-8?B?QzR2SEJnWFdEcHI1a3FaMWFWSDAxK1dCTW9sVmREZFpWdzNMd2tWUlRaRi8w?=
 =?utf-8?B?NVIwNkJsc1BPSHJyTVJCaUpQNWFwelFlUUU2QzE2UW1YRENTT25mQWtETlh1?=
 =?utf-8?B?SVg3VTBtN2FjcXF6UTE5cVNhZmI4ZnFGNUpuMGdPc0Q3S1JwOVBWWmJnRE13?=
 =?utf-8?B?bm5wWWRVY1dXdm1nTFdmNVlYdEM5V3FTSHVFWXFRQ200d2hBdnVPbXI4YjJD?=
 =?utf-8?B?REFLUWV2YkFCbnY5d01FbWVoeGhNKy9BaDArWDh2WHB2RmgyWkxJR20rOGF2?=
 =?utf-8?B?WW14STlDRzNLWW5FcHQvMHNLelpjZDVhYzMxWm5wZzRNMFpMZ21NY0NSUWNa?=
 =?utf-8?B?THgvOG5QYXh4ajl5cmNpUlhhNGloMFhqRW9LOGNvLzJ0bHBaSkQ2VjlQMjhP?=
 =?utf-8?B?eFlQUVhhaDF6Uyt6MUVCRjgzYkRVY0NOTTQ2akZvSy9lWWxIQUdKY25pK2th?=
 =?utf-8?B?Qmxpa3NLRy9iMk5WeUJlYjB1RHo0ZCtaM1pIYml0dG1xOFI2ZzEzSlpLdE9m?=
 =?utf-8?B?SzJERXZyQnE0N1RCd0RuMHNrMm4zSk9kTHFoTGJac3Q0Tml3MlptRlo1d1Fx?=
 =?utf-8?B?cmV6cUhsczcyVkpaeURvS2Q2aW9EZHR2REVZcFBaZWZQSHVSYkxabk1uV3Ax?=
 =?utf-8?B?L0s1VUZmdVhXMXowQmhkN2IvWXVIdVJJU29kSnRwSVFaYkgxTTRaVFNUTDVl?=
 =?utf-8?B?VHJCNWhmajNTMENKS1laVjBQc1Z2WHVCMlZpdGRQM3I4YmJ1Y2Z2aGI0eU1K?=
 =?utf-8?B?THMvQkU0YmU0SjFCTW5VT2pZcDFOa283cjZ6b2NEcVZaTnhOZ0lieWNuOVNu?=
 =?utf-8?B?d2FrTUFjR3NsdFlWYkkvUllWTHd1cmt0OFFSanN1K21EamJ2cURxbmtBei9p?=
 =?utf-8?B?NDJQZFdIOFRUNSs5Q2pUa1Y0a2dQZEdlSVhRSlNZbEhoeXhoWlZ2Q05ldFAx?=
 =?utf-8?B?MU1VNUN0Ylg4SEVDSjdsUDBGellLQllhZXlsL0llQ0pJZmdLVjQ1OEpLZDY1?=
 =?utf-8?B?QUE9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64189862-a671-449c-c12a-08db043020b6
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9628.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 08:41:35.8252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /SiwY3+LAkEvrQoOBRjiQdIRhlZIpi00TRjhgJp+y3h5nWp+BMRa7wh9ONx78tFzsH9fOLBsc331mkNN+xt9zg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9449
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peng,

On 2/1/2023 2:27 AM, Peng Fan wrote:
>
>
> On 2/1/2023 1:04 AM, Iuliana Prodan (OSS) wrote:
>> From: Iuliana Prodan <iuliana.prodan@nxp.com>
>>
>> The IRAM is part of the HiFi DSP.
>> According to hardware specification only 32-bits write are allowed
>> otherwise we get a Kernel panic.
>>
>> Therefore add a custom memory copy and memset functions to deal with
>> the above restriction.
>
> Which platform has this limitation? This driver has been landed for
> quite some time, is there any specific condition to trigger the issue?
>
> Regards,
> Peng.
>
Any platform with HiFi DSP.

As I explained in the previous version, until now, it was used in a 
limited scenario and the firmware was correctly built to respect the 
write restriction - having the IRAM sections size a multiple of 4bytes.

Now, I was trying a simple hello_world sample from Zephyr, compiled with 
GCC and I crashed the Kernel trying to load it on the hifi4 DSP.

Thanks,

Iulia