Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF00C05027 for ; Wed, 1 Feb 2023 11:18:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232396AbjBALSJ (ORCPT ); Wed, 1 Feb 2023 06:18:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231995AbjBALSC (ORCPT ); Wed, 1 Feb 2023 06:18:02 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D9F93AA5; Wed, 1 Feb 2023 03:18:02 -0800 (PST) Date: Wed, 1 Feb 2023 12:17:58 +0100 From: Pablo Neira Ayuso To: Gavrilov Ilia Cc: "leon@kernel.org" , "coreteam@netfilter.org" , "davem@davemloft.net" , "edumazet@google.com" , "fw@strlen.de" , "joe@perches.com" , "kadlec@netfilter.org" , "kuba@kernel.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" , "netdev@vger.kernel.org" , "netfilter-devel@vger.kernel.org" , "pabeni@redhat.com" Subject: Re: [PATCH v2] netfilter: conntrack: remote a return value of the 'seq_print_acct' function. Message-ID: References: <20230123143202.1785569-1-Ilia.Gavrilov@infotecs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230123143202.1785569-1-Ilia.Gavrilov@infotecs.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2023 at 02:31:54PM +0000, Gavrilov Ilia wrote: > The static 'seq_print_acct' function always returns 0. > > Change the return value to 'void' and remove unnecessary checks. > > Found by InfoTeCS on behalf of Linux Verification Center > (linuxtesting.org) with SVACE. Applied, thanks