Message-ID: <d6297aae-7f9e-1b4e-d2f3-da5664804ab0@nxp.com>
Date:   Wed, 1 Feb 2023 13:50:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] bus: fsl-mc: don't assume child devices are all fsl-mc
 devices
Content-Language: en-CA
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        ioana.ciornei@nxp.com
References: <20230127131636.20889-1-laurentiu.tudor@nxp.com>
 <Y9kB8F3Nls8d1Koi@kroah.com>
From:   Laurentiu Tudor <laurentiu.tudor@nxp.com>
In-Reply-To: <Y9kB8F3Nls8d1Koi@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGE1SDJpYWlXQzJOUHlNQTYzalBCUnFLdFN3V3duKytEQ0tpSkF2cGYyK2Fw?=
 =?utf-8?B?Q0hhZll1Z042SVVjbFQ3NDY5RlhPbmRBTjE2M0lGckRydFpLZ3BaVEQxRjNX?=
 =?utf-8?B?L1FrYTBwMVN4ZGFrYU5Ma09sem1pV3B5aEc2WEhwV2pwTFFYTERLclNmeU9L?=
 =?utf-8?B?aEQ2OE5ta3FvVk9GZ3o2MjFOR0x3SmJMM1NNSWV0dk5ETHZNMUNWelZQb2hC?=
 =?utf-8?B?T0pNZ1R2NTc4VHdIMDg5MkdDQ2IwTlFvRE9XRkdZcWx1MitUMGQvMDFqelFJ?=
 =?utf-8?B?NnlhOWgrNjNqQkZ6djdjNCtSbUtYQkRHWGxtMVJ6VHFoaUdsU3phclNidVpI?=
 =?utf-8?B?eTZDTUhLMUt4NWVxdjY5TkcwaFBtbHltY3FXbXNXZzVIcWRyVjFMOGtvcWhQ?=
 =?utf-8?B?T3ZqUHVRam5JRlU2Ri82WG5xZ0NnNWc2QmpLZGo3eTJIQzA0K05ML2tGZzNN?=
 =?utf-8?B?UlVRQWwvMDJVcXNzTW1YL3ZzdktaTXBlbmVhVmNjUUx3UjNZS0JkdlEraTBw?=
 =?utf-8?B?UG9SVXNtZk5zbGlGVGI5RWsxNVhjVE92MEY4R1RUWmdGRVpuUXMvOUZFM2xB?=
 =?utf-8?B?T1RPWVFRZGhxODVVSW5FTzhualNHT3BNZXVWRVFmUFRBdE92RlpmNWZWSThp?=
 =?utf-8?B?OGE4cXNyZ21hNGtlcGI2Z3BIUWxkY3lVTU1DS3RWM2prK0g4RGNwWXpUdnZ5?=
 =?utf-8?B?Zzh1Sy9RTGRvOUVBWWRaTUtwSSthVTV5YnN6TzRZTVp2L2RqRlR1KzlnTU1X?=
 =?utf-8?B?SGp0VUhiSEFpbU12bnBQaUZ6Mi9TTWxDSjBwQVIzQWRIRnQ1eWRWM2tZU1lS?=
 =?utf-8?B?RXVkRnlUL0Z5OU9BaVB5V2pNRjZCbHYzeEpDb0xtcEdrQVZJL0h5cFcvTFdS?=
 =?utf-8?B?aW1PYXRtRDF5cFVxenAvaHVqc2RNVHhLd2NaL0R5dFVlbnZ0ZGFrWE9KZGRz?=
 =?utf-8?B?MEFzYytzYWpHLy9ndXpIbkxJNGpVekhiTS9tcTFDNHFzVWNUNk9MQVYxYnR2?=
 =?utf-8?B?ZTZ2RVR5WWdTQUVlZThQRmpMTlNwSmFiaW5TbkJQNGNpYVRjQ3BEZGFEZEJk?=
 =?utf-8?B?RTAwUldMQm5nSjlWblRyKzF1RmtlVC9YMTEzcFpwanFrYncwekdZcVhWakZm?=
 =?utf-8?B?bTBORDZTZEF2RjhDcDRacnZHRE1NbEp1cVdHVlJTK0F1QjU4VzdsOE44VS9p?=
 =?utf-8?B?N3ZiMjJUZXBsSnM1R1VsNXV6OVI2ZUVoOU9GdytoS1FSL2lsV0pXOVNIY3cz?=
 =?utf-8?B?eFE3ZDl2N0dxVUtxbUZuV3JpalIxdUZzdlRIUkZvTGx1V0RhRlMySFpDT1hF?=
 =?utf-8?B?YWFyc2NaMmM3My9KUzcraW5jS0VPWGo2U0RkTCt4eVIwOVl0Nk9mdEdIMDVK?=
 =?utf-8?B?b1Rxb0NIN201NU11UFVQa2VqZlNtb1J5QW1DT1BPR1AzZm91MTE4aWtkMHpR?=
 =?utf-8?B?dlVNRDJUNGhzQllGbEJXZ29LRERvcGV6VnlMekkrS1RlaGo3N1FRaDRaYTJK?=
 =?utf-8?B?TlgyTkszQ1dNMGlZQk9ONW1HVnRsek5GOXQxRkRUbkdYQjJqQ3hQTE50L3lI?=
 =?utf-8?B?czFJZzBkbFVCZWVYWXNGUW52NjkwTENGeEdwZTdmWXJVdFllbWFDMUV0V3RH?=
 =?utf-8?B?b29oYkVjUld0aGsrNUFKbEJQb2dpMmQvRXFRVzJkNk9Udk5kZmFQdmVvRDM2?=
 =?utf-8?B?ckh0cWJYOTJOUTI3Ny91NzZoUGIyWTR5MkRvbEQ0ZndMYTdoM0JnQWJpWTcz?=
 =?utf-8?B?eWtYc3M1ZW5qNldLdGZzUlUvOFViVmQvZTFNSXBpWEdvUVVPYnpKRE8yQWgv?=
 =?utf-8?B?UDVieTJ1RW44UWpVcmc0eXJkdnhWR0ZnT3BRLzk3TjJjZnJJdTJEZGRlQlV3?=
 =?utf-8?B?OWtQQmFoVlg1YjVyVVczdXBNQXBZelFicVlaS1MzUU5TelhjWFBKVGxMRVdl?=
 =?utf-8?B?LzVOTnFub3BhRGJEK0p1OWp0ZHJ5bEJXa3hYWTMrdXhJQkhLMEdJSC9MMlJM?=
 =?utf-8?B?d0VTSzN3UStnaEF3ZVQwYTlSbytmZ202Z0RxcnFKZlY1RDhqaVR3VGFyRmZU?=
 =?utf-8?B?UHVCbmUrU1RzWkcyV251YWZNWEt1RkQzamMyVDd1NFZiU1RnVXpKSDhwd2Uv?=
 =?utf-8?B?OGUvcTlNUWRISkNhNkdXLzM1aEZ2R0ZOSm5weG5vVjBrQzF0RFZFRVowcnZZ?=
 =?utf-8?B?RFE9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3a571f-08c8-45a3-1091-08db044a7b53
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3405.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 11:50:14.9001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HfmyTgOTRAI6+jNNT/c4TZwViy8QViLSl1zvLIjw2UrL+iJdup1CP/sKLyPLzfl3OSKpQ0N6tDKsa0gUqOflbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8452
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

On 1/31/2023 1:56 PM, Greg KH wrote:
> On Fri, Jan 27, 2023 at 03:16:36PM +0200, laurentiu.tudor@nxp.com wrote:
>> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>>
>> Changes in VFIO caused a pseudo-device to be created as child of
>> fsl-mc devices causing a crash [1] when trying to bind a fsl-mc
>> device to VFIO. Fix this by checking the device type when enumerating
>> fsl-mc child devices.
> 
> What changes?  What commit id does this fix?  Does it need to be
> backported?

There were a lot of changes in the VFIO area but I'd point at this 
commit [1].

I'll resend the patch with a "Fixes:" tag pointing at this commit if 
that's ok with you.

> And what type of "pseudo device" is being created? 
> Why would it be passed to this driver if it's the wrong type?

It's not passed to the driver per-se. The problem shows up when the 
implementation of the driver does a device_for_each_child() [2] and the 
callback blindly assumes that all enumerated children devices are fsl-mc 
devices. The patch just adds a check for this case.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3c28a76124b25882411f005924be73795b6ef078
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/bus/fsl-mc/dprc-driver.c?#n96

---
Thanks & Best Regards, Laurentiu