Date:   Wed, 01 Feb 2023 13:12:28 +0100
Message-ID: <87a61xy47n.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] ALSA: emu10k1: clean up some inconsistent indenting
In-Reply-To: <20230131084304.12920-1-jiapeng.chong@linux.alibaba.com>
References: <20230131084304.12920-1-jiapeng.chong@linux.alibaba.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 31 Jan 2023 09:43:04 +0100,
Jiapeng Chong wrote:
> 
> No functional modification involved.
> 
> sound/pci/emu10k1/memory.c:446 snd_emu10k1_synth_free() warn: inconsistent indenting.

How is this warning generated?  Does it come from clang or any other
compiler, or is it just some tool?

In general, I take such a white-space-fix-only patch when it's tied
with other real fix patches.  But if the compiler warns, it's worth to
pick up, of course.


thanks,

Takashi

> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3903
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  sound/pci/emu10k1/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/emu10k1/memory.c b/sound/pci/emu10k1/memory.c
> index edb3f1763719..6a7406014f81 100644
> --- a/sound/pci/emu10k1/memory.c
> +++ b/sound/pci/emu10k1/memory.c
> @@ -443,7 +443,7 @@ snd_emu10k1_synth_free(struct snd_emu10k1 *emu, struct snd_util_memblk *memblk)
>  		unmap_memblk(emu, blk);
>  	spin_unlock_irqrestore(&emu->memblk_lock, flags);
>  	synth_free_pages(emu, blk);
> -	 __snd_util_mem_free(hdr, memblk);
> +	__snd_util_mem_free(hdr, memblk);
>  	mutex_unlock(&hdr->block_mutex);
>  	return 0;
>  }
> -- 
> 2.20.1.7.g153144c
>