Date:   Wed, 01 Feb 2023 13:23:10 +0100
Message-ID: <878rhhy3pt.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Dan Carpenter <error27@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Maxime Ripard <mripard@kernel.org>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: pci: lx6464es: fix a debug loop
In-Reply-To: <Y9jnJTis/mRFJAQp@kili>
References: <Y9jnJTis/mRFJAQp@kili>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 31 Jan 2023 11:02:13 +0100,
Dan Carpenter wrote:
> 
> This loop accidentally reuses the "i" iterator for both the inside and
> the outside loop.  The value of MAX_STREAM_BUFFER is 5.  I believe that
> chip->rmh.stat_len is in the 2-12 range.  If the value of .stat_len is
> 4 or more then it will loop exactly one time, but if it's less then it
> is a forever loop.
> 
> It looks like it was supposed to combined into one loop where
> conditions are checked.
> 
> Fixes: 8e6320064c33 ("ALSA: lx_core: Remove useless #if 0 .. #endif")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> v2: In the first version I just deleted the outside loop but that was
> not the correct fix.  Combine the conditions instead.

Thanks, applied.


Takashi