Message-ID: <77b78287-a352-85ae-0c3d-c3837be9bf1d@datenfreihafen.org>
Date:   Wed, 1 Feb 2023 13:42:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] [v2] at86rf230: convert to gpio descriptors
Content-Language: en-US
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Arnd Bergmann <arnd@kernel.org>
Cc:     Alexander Aring <alex.aring@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        linux-wpan@vger.kernel.org, netdev@vger.kernel.org
References: <20230126162323.2986682-1-arnd@kernel.org>
 <CAKdAkRQT_Jk5yBeMZqh=M1JscVLFieZTQjLGOGxy8nHh8SnD3A@mail.gmail.com>
 <CAKdAkRSuDJgdsSQqy9Cc_eUYuOfFsLmBJ8Rd93uQhY6HV8nN4w@mail.gmail.com>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
In-Reply-To: <CAKdAkRSuDJgdsSQqy9Cc_eUYuOfFsLmBJ8Rd93uQhY6HV8nN4w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Dmitry.

On 01.02.23 01:50, Dmitry Torokhov wrote:
> On Tue, Jan 31, 2023 at 3:52 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>>
>> Hi Arnd,
>>
>> On Thu, Jan 26, 2023 at 8:32 AM Arnd Bergmann <arnd@kernel.org> wrote:
>>>
>>>          /* Reset */
>>> -       if (gpio_is_valid(rstn)) {
>>> +       if (rstn) {
>>>                  udelay(1);
>>> -               gpio_set_value_cansleep(rstn, 0);
>>> +               gpiod_set_value_cansleep(rstn, 0);
>>>                  udelay(1);
>>> -               gpio_set_value_cansleep(rstn, 1);
>>> +               gpiod_set_value_cansleep(rstn, 1);
>>
>> For gpiod conversions, if we are not willing to chase whether existing
>> DTSes specify polarities
>> properly and create workarounds in case they are wrong, we should use
>> gpiod_set_raw_value*()
>> (my preference would be to do the work and not use "raw" variants).
>>
>> In this particular case, arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
>> defines reset line as active low,
>> so you are leaving the device in reset state.
>>
>> Please review your other conversion patches.
> 
> We also can not change the names of requested GPIOs from "reset-gpio"
> to "rstn-gpios" and expect
> this to work.
> 
> Stefan, please consider reverting this and applying a couple of
> patches I will send out shortly.

Thanks for having another look at these patches. Do you have the same 
concern for the convesion patch to cc2520 that has been posted and 
applied as well?

Arnd, if you have any concerns about the revert please speak up soon as 
I am going to revert your patch and get these patches into my tree later 
today.

regards
Stefan Schmidt