MIME-Version: 1.0
References: <20230122141428.115372-1-masahiroy@kernel.org> <20230122141428.115372-7-masahiroy@kernel.org>
In-Reply-To: <20230122141428.115372-7-masahiroy@kernel.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Wed, 1 Feb 2023 22:09:43 +0900
Message-ID: <CAK7LNARHak6v_YGqwf-vohKZJx7nAc4jAzzCwhrvioboXVsFEQ@mail.gmail.com>
Subject: Re: [PATCH 7/7] kbuild: do not re-run setlocalversion for kernelrelease
To:     linux-kbuild@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jan 22, 2023 at 11:14 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Revert:
>   - 7b8ea53d7f18 ("makefile: not need to regenerate kernel.release
>     file when make kernelrelease")
>
>   - 01ab17887f4c ("Makefile: "make kernelrelease" should show the
>     correct full kernel version")
>
> I think the original behavior was better - 'make kernelrelease' should
> print $(KERNELRELEASE) used in the last build, not the one that will
> be used in the next build. Therefore, it is an error if you run it in
> the pristine source tree.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>


I locally got a question about this, and
on second thought, this might be annoying
because you need to build something to get kernelrelease.

I will drop this commit.


--
Best Regards
Masahiro Yamada