Date:   Wed, 1 Feb 2023 16:22:43 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     David Laight <David.Laight@aculab.com>
Cc:     'Guru Mehar Rachaputi' <gurumeharrachaputi@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: pi433: modify bit_rate from u16 to u32
Message-ID: <Y9pno7gZHa+r/Rg3@kadam>
References: <Y9h42l/8EcPqn63x@combine-ThinkPad-S1-Yoga>
 <Y9ilj812USHrSXe+@kroah.com>
 <Y9jrOKMGl7ITKxhP@combine-ThinkPad-S1-Yoga>
 <19e492521b4a4d31aa13c45e8616689b@AcuMS.aculab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <19e492521b4a4d31aa13c45e8616689b@AcuMS.aculab.com>
Precedence: bulk

On Wed, Feb 01, 2023 at 12:34:50PM +0000, David Laight wrote:
> In reality having a uapi structure with embedded padding should
> be banned.
> But that would need a compiler attribute to enforce it.

It would be simple enough to grep the names of all the UAPI struct and
use pahole to make a list of the existing structs which have holes.
Then re-run the script every week and complain when new holey struct
types are added.

You could do a similar thing with Smatch looking at copy_to/from_user()
struct types.

regards,
dan carpenter