Date:   Wed, 1 Feb 2023 05:35:13 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     David Howells <dhowells@redhat.com>
Cc:     Steve French <smfrench@gmail.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Shyam Prasad N <nspmangalore@gmail.com>,
        Rohith Surabattula <rohiths.msft@gmail.com>,
        Tom Talpey <tom@talpey.com>,
        Stefan Metzmacher <metze@samba.org>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jeff Layton <jlayton@kernel.org>, linux-cifs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Steve French <sfrench@samba.org>
Subject: Re: [PATCH 03/12] cifs: Implement splice_read to pass down ITER_BVEC
 not ITER_PIPE
Message-ID: <Y9pqke68UH9N0Qtd@infradead.org>
References: <20230131182855.4027499-1-dhowells@redhat.com>
 <20230131182855.4027499-4-dhowells@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230131182855.4027499-4-dhowells@redhat.com>
Precedence: bulk

On Tue, Jan 31, 2023 at 06:28:46PM +0000, David Howells wrote:
> Provide cifs_splice_read() to use a bvec rather than an pipe iterator as
> the latter cannot so easily be split and advanced,

What exactly are the issues?  If cifs is running into them others will
as well, so we might better fix them in the infrastructure.

>  (1) Bulk-allocate a bunch of pages to carry as much of the requested
>      amount of data as possible, but without overrunning the available
>      slots in the pipe and add them to an ITER_BVEC.

And that basically makes the splice_read entirely pointless and you
might as well simply not support it.