Message-ID: <d7cb61b8-7403-a240-d2bb-97fe082a10a4@oracle.com>
Date:   Wed, 1 Feb 2023 19:57:13 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 2/2] spi: intel: Add support for controllers
Content-Language: en-US
To:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Mauro Lima <mauro.lima@eclypsium.com>
Cc:     broonie@kernel.org, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230201050455.505135-1-mauro.lima@eclypsium.com>
 <20230201050455.505135-3-mauro.lima@eclypsium.com>
 <Y9n9fhc6YbdPe08f@black.fi.intel.com>
From:   ALOK TIWARI <alok.a.tiwari@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <Y9n9fhc6YbdPe08f@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUdKMDQ1S2JvditKekViTDd1MXEvOGZJODduYkNoTUVOK1VwUDNiTHpsVDBi?=
 =?utf-8?B?OTFsdE00ZmloVWE5VmhpN1FSUWZ0Y3htQ25qYlEwTGsweGxRd1ZJYUtWUjlF?=
 =?utf-8?B?N21UK2MzVGIva1QrWk5vMkpQZ21YZ3RlL0NXemNhVENPMUVHVERqclE1WVJ0?=
 =?utf-8?B?ams4RmdTMFVoSXd0eGtodkV6L3JDSk1pUko1bnZpaGZXTGhKcWZ6QWVzNXlu?=
 =?utf-8?B?VkI5cW5DSVZLNjd1dmhXVkkwWXFIQzV4MWNhaVFNaGJHMDR3UDVtMkRNaUxW?=
 =?utf-8?B?dS9TcE51L2NucnVORE1kU0wxRXA0Szh1NncrTUdldVpkUVlDaFBTbzI4WnpP?=
 =?utf-8?B?K1NScktONS9XVWREbzRNMjBLejRoblhVMzluQ0dOVWdjdzh5bmZJSVJwaVkr?=
 =?utf-8?B?dE1UU3pFM29qaEZLOTQ2ZUhjL0ZwSjRaZnN5bk45S0FvVjBjdkJZV0hhMjVQ?=
 =?utf-8?B?YkhMUnM5NFliQm9KQ0lyemdMWGJ3cGEwTXgveUpJeDYxZnM1VlU4dVh1NGJk?=
 =?utf-8?B?ZklDeUJ4YXBRN1JJN0dka3dIN2EvV04yclZHTTJ2TkV6RUNNTU5aaWNtOGVT?=
 =?utf-8?B?VDVjL2RqRGdtZ3F5c21OdDRtcjNkcFhlWmxVK3hudGp5L0lWYTFFWk5mNW1w?=
 =?utf-8?B?R2dJd0RDMlJscFF3QWd0Lzh5Ylh1Mng0L2ZFZzV5cC95S2p2dFdCMGtXZkpF?=
 =?utf-8?B?VTNLZ2pjKzk3SmY5UFNUSyt2TGxvUnA0bkJuMGR3R001QkdDRVdNN0hsazdU?=
 =?utf-8?B?RDdLTk03c0VQcGxWMmxQVDdGSXBLTnQ5MjN5ZVRmV1NyQjViVml4dWVrNVVW?=
 =?utf-8?B?VlhNNmZ6dUVmTForYWVmMHl0RmZ0Z0hSU3pGSFd0Z3pRSjc2ZlE4RGYzME44?=
 =?utf-8?B?OGMvRy9mQXFQKytUWTRmNlArSmZtcU9BMzRLek5UOVJLZGoreEhNdGhiR3Fw?=
 =?utf-8?B?R3RHbDVoblNFc3lEYUdEQ0hSMHNWSnpoWENVSnJ4ZnY1TFpNeWthZVM2ckFV?=
 =?utf-8?B?Tms4b0pKK1RkU1BMY3VBVWM0WEhHQThJdHhhaDNJUHU0UmpMSVlkdERheUhY?=
 =?utf-8?B?S3NDZWRRRWViUmJFVjdSa2VBSnp4SzFjdndWdnVldDByaFdZbk5Za2pqRkVq?=
 =?utf-8?B?NWJHSENrVjNsWFBjYnNJOGUySWJLN3p6RmtEYnJ4S0YwR3g5T2l5M05zTTJa?=
 =?utf-8?B?SVpXbjBCWGlpZ0dXNW5QQjRFb0hlb1MrQmFqcFNoNnhNMlV0UXJIeW9SSGRS?=
 =?utf-8?B?U2x3M0Z0SW5LczZBR1NDN2JMYkZmeTVIbG5FN1VkSDdLQ2pOSDgzRXg1MjlC?=
 =?utf-8?B?YUVkQk9sQ0ZvSldLUDhWMHpObUhtaWtySUo0ZkFYRXYyaVM2V0liZ21BUHdG?=
 =?utf-8?B?YWF1WGsrMVhkWTVEVjVhb2Nhbk1hUFA5YkJyUFhyNEtOOVBCT21nbklaOEpa?=
 =?utf-8?B?RkpCNS9EdGFObnhvZmdXM2htbDR1OGZwM1k3UytIazhtQy96QzhKaDhuODFr?=
 =?utf-8?B?V2puWnpHcnJEZ0NMbU5VNjgrOWErakdTTkZKY1NzZ0JkeVlQL2R6MWhFVFd4?=
 =?utf-8?B?ajRiRjRFY0JEZ1FRMVlrVTBjZk9GRlhmM0xQTFBISUZEZVpwMjhKM1AzaFNT?=
 =?utf-8?B?ajNlZklPdGVuVktLeVo3LytRbVBCQjBvdDdyUjNQQ2tZZWE5bmdwaXZ0V3dK?=
 =?utf-8?B?YTlFUEw4SU5ZeTJkWUlYQXJ2RjU1aEh3ZDAxYjhRS1p0ditHd3hxSjJGK0gw?=
 =?utf-8?B?MlcvNmVFYmlwSElhN3FsZzA0UmZuY0J4T1p2NFRxQktySWZiQjMwNmlnWmdp?=
 =?utf-8?B?Y2loeWQ1MlU3ZTlzK3pzckxLTFFhdEVzMXp3SDdZMHZXNUczWXRSUHl1bXdv?=
 =?utf-8?B?RlkwTDNwUFhFZFNVTU96K1M3bEVDcjYycG1WR0xGS1lxUzFKTzRWZ3Jsc3Vt?=
 =?utf-8?B?RzJLQS9QcC9rUjB1UmdTYkFxQzJvQlRJSnU0OFk4TDNTWjFxUmRsZmQycEFi?=
 =?utf-8?B?aFRiVXQwNTNVMG02c3BvMjM3ZzRldmszbjRWdDNmSjhqNEREU2FUcWhTTmN6?=
 =?utf-8?B?TVRCOEdtamNmNnhGNm9VbWNSWFI4UkpoMHhQbHpRakluYkhGTWtjWUxaa003?=
 =?utf-8?B?WlZwL2h2N2NYVXhCNDJyMDJwWTcvU3djblc0d1Jhb3BGa1hscFpacG1aaldx?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5Q7oC/Y3o5Q5m8H/SvSgPxj7wQY6t5IwEy08mwGPPa7kVDq/9Gh15EdbeE/B+f9XwZGVMYkKQWj+u+8KsYkmZKByDDhUcVpSAonLctRl8pFVFBQObk5pVqZ6q9zGiSc+rAaHY8/h21tCAA+T78NTthqu/7/7UvILH/yRxx2Tj1S5qpxFPavmoWbnmF4PwlH3CcwQLRyM990aK7NVNFVDXzpfIitsGwYptl85SDdtz4xXvnaiWaDEpNDZrvvELZpi02wz+QUC+P4+3/0jV2JI7CtHH+tE3tnl5JogfH3fIfHf9MRnMb2LMYNY1e/msQo7KudXjC1VBOuUp2ODhmRiLPkH6h+SgoNWNubzI0lbRm/3RNiatTwa9quKsMhkyx4WsJyvX62mTUjopXeLakbxy/Vp9FXmceb2itnf3C1lq4rUHZAkIUurJDXNCmFYxvoOFnT412YkzwRLNVid/cIk6UX6A7jXNaq0/vvWIHm7KmK6ee42FTqkB5uhdkMxHMBjylz5Ur35djB69uDV1TvEJUXVmtxMtzDQgkCbbF9yunSKdqfK67WACOsHLFNICtRlGrLwD5HD3RVtTyvTm/NAfwKT27NFQXMwXq/ntedaVr6QT1cOklpljNjK6PTaAzl3jakjNtcujU+MyJ8YNj817QBWPvJgy0hYPeVIQJGdtlaBh9dFGfWXUkZtEwVYfzAvmJ65bG7HOCdBLuVzdmkz1wMCaT4OraiSb7b4k7g4CLiNjOiE6CrRnDZvjB5+rbSaQ/XdcN4RxMPBe9ubb8vlWp3e1wtn2d79z4eG4iSR/otDdTaZn720+sHR8sS8DXrnfDuo9+dy0bME2UpuZjXEaB7X7x7X7jn5Ztm0wPsVBaYg8Pia1JuhOKzGUIzt0EeM
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bc93601-ed59-4c47-6805-08db04606eb5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4581.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 14:27:22.7261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b2JZBgO0v/WuSei3fZlDTTd5PPsGoApbbFmSEYrrHC0XCLMwQvb7BC9fDJvcD5n+0OBQSUklbz+puE016im8DYMMLk/tlj/M8bJAkIe5Vho=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6917
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-01_04,2023-01-31_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302010124
X-Proofpoint-GUID: q88foieltFDsDiaRy-_SM9Muxm9NWK0i
X-Proofpoint-ORIG-GUID: q88foieltFDsDiaRy-_SM9Muxm9NWK0i
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

9d24 and 9da4 should come after { PCI_VDEVICE(INTEL, 0x7e23), (unsigned 
long)&cnl_info

and a2a4  should be after { PCI_VDEVICE(INTEL, 0xa224), (unsigned 
long)&bxt_info }

Thanks,

Alok

On 2/1/2023 11:19 AM, Mika Westerberg wrote:
> On Wed, Feb 01, 2023 at 02:04:55AM -0300, Mauro Lima wrote:
>> Add Device IDs to the module table for the following controllers:
>> 	- 9da4  Cannon Lake 300 Series On-Package
>> 	- a2a4  200 Series/Z370 Chipset Family SPI Controller
>> 	- 9d24  Intel® 200 Series Chipset Family (Including Intel® X299),
>> 		Intel® Z370 Intel® H310C,B365,
>> 		also Intel® B460 and H410 Chipset Platform Controller Hub
>>
>> Signed-off-by: Mauro Lima <mauro.lima@eclypsium.com>
>> ---
>>   drivers/spi/spi-intel-pci.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/spi/spi-intel-pci.c b/drivers/spi/spi-intel-pci.c
>> index 10fa3a7fa4f5..ba08f64e56eb 100644
>> --- a/drivers/spi/spi-intel-pci.c
>> +++ b/drivers/spi/spi-intel-pci.c
>> @@ -80,6 +80,9 @@ static const struct pci_device_id intel_spi_pci_ids[] = {
>>   	{ PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info },
>>   	{ PCI_VDEVICE(INTEL, 0xa324), (unsigned long)&cnl_info },
>>   	{ PCI_VDEVICE(INTEL, 0xa3a4), (unsigned long)&cnl_info },
>> +	{ PCI_VDEVICE(INTEL, 0x9da4), (unsigned long)&cnl_info },
>> +	{ PCI_VDEVICE(INTEL, 0xa2a4), (unsigned long)&cnl_info },
>> +	{ PCI_VDEVICE(INTEL, 0x9d24), (unsigned long)&cnl_info },
> Make sure these are sorted numerically.
>
> Otherwise looks good, thanks for doing this!
>