Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <Y9ooW52m0Afnhj7Z@gondor.apana.org.au>
References: <Y9ooW52m0Afnhj7Z@gondor.apana.org.au>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     dhowells@redhat.com, smfrench@gmail.com, viro@zeniv.linux.org.uk,
        nspmangalore@gmail.com, rohiths.msft@gmail.com, tom@talpey.com,
        metze@samba.org, hch@infradead.org, willy@infradead.org,
        jlayton@kernel.org, linux-cifs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        sfrench@samba.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 05/12] cifs: Add a function to Hash the contents of an iterator
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <312907.1675262203.1@warthog.procyon.org.uk>
Date:   Wed, 01 Feb 2023 14:36:43 +0000
Message-ID: <312908.1675262203@warthog.procyon.org.uk>
Precedence: bulk

Herbert Xu <herbert@gondor.apana.org.au> wrote:

> > Add a function to push the contents of a BVEC-, KVEC- or XARRAY-type
> > iterator into a symmetric hash algorithm.
> 
> There is no such thing as a symmetric hash.  You're using shash
> which stands for synchronous hash.

Sorry, you're right.

> In any case, as I said in the previous review this is abusing the
> shash API.  Please use ahash instead.

It's already abusing the shash API, this doesn't change that, except where it
gets the data from.

I can have a go at conversion to ahash, but that will have to be a separate
patch set as it isn't trivial.  The problem is that the current code just
assumes it can push bits into the hash as it gets them - this is not possible
with ahash.

David