Date:   Wed, 1 Feb 2023 14:40:46 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Cc:     krzysztof.kozlowski+dt@linaro.org, agross@kernel.org,
        andersson@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org,
        quic_plai@quicinc.com, bgoswami@quicinc.com,
        srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com,
        linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, swboyd@chromium.org,
        judyhsiao@chromium.org, devicetree@vger.kernel.org,
        konrad.dybcio@linaro.org
Subject: Re: [PATCH 02/14] ASoC: qcom: SC7280: audioreach: Add sc7280
 hardware param fixup callback
Message-ID: <Y9p57qn9+Pig9igE@sirena.org.uk>
References: <20230201134947.1638197-1-quic_mohs@quicinc.com>
 <20230201134947.1638197-3-quic_mohs@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="It/vzamgdtamVvYL"
Content-Disposition: inline
In-Reply-To: <20230201134947.1638197-3-quic_mohs@quicinc.com>
Precedence: bulk


--It/vzamgdtamVvYL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 01, 2023 at 07:19:35PM +0530, Mohammad Rafi Shaik wrote:

> +#define DEFAULT_SAMPLE_RATE_48K	48000

Why are we bothering with a define here given that the define also
encodes the value and it's only used in once place?

>  	for_each_card_prelinks(card, i, link) {
>  		link->init = sc7280_init;
>  		link->ops = &sc7280_ops;
> +		if (link->no_pcm == 1)
> +			link->be_hw_params_fixup = sc7280_snd_be_hw_params_fixup;

We only set the fixup in the case where there's no PCM but we removed
the constraint in all cases - isn't the constraint needed otherwise?

--It/vzamgdtamVvYL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPaee0ACgkQJNaLcl1U
h9CiNgf/SDWbO2koQKvCH5xT7veA8uFDK7FX/PmIQ0kAWddbyKY2R+povhqysfIW
wg9TAzbz60wfmDhq+NTTeiHrB4TqbEhpOsRS9E5GyA5+D64d8JEc6iNju+SUhb8x
XjyRIKFntWKqSxgEDiw3ZSPj+unDqfJjsW9JSj06gMzYBM58mvXiDKIUm1PkXwdz
1CjZSKA4Yq1Oy8JXCJulti9SkgzaFI/ylXPK/+zqXR6BjZ/uWY0xicLF4W6nGfkQ
wRoXtjAMfcK9LKLAf2U0i0Lmb6tJdP7waq0qaGQIB/2kT4GDtPGcgCCqROqMjXFT
90ffHxNOpdMnd0EQSrSTUWQBwYTaCg==
=Ge6o
-----END PGP SIGNATURE-----

--It/vzamgdtamVvYL--