Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63514C6379F for ; Wed, 1 Feb 2023 14:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232607AbjBAO4C (ORCPT ); Wed, 1 Feb 2023 09:56:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232320AbjBAO4A (ORCPT ); Wed, 1 Feb 2023 09:56:00 -0500 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47AE669B28 for ; Wed, 1 Feb 2023 06:55:56 -0800 (PST) Received: by mail-yb1-xb29.google.com with SMTP id 123so22613002ybv.6 for ; Wed, 01 Feb 2023 06:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ImenvlSZqiGev30iuxYAHjcK6h9wKIIw7n5ZxJIaiEE=; b=XeYXkN6WVPXsft03P0rMvKPq+E3BcQJujz9ahCDeXJBQojMzmpke9ee/87gOlo6R+q AmNxvXXdhLC87eMDUNSg3txvpXPxMeib8k2Y9ZyQ+dmk4v7QEwFDRke3YOqJvucAFyzZ zGg3YIVSHfwIf49BxGmb/55XB+JwJG8oytXS7u7T/BLDj5XC9nVHvgDWR9CYFtcIUD8q H8BU/LggqhsjFbPz55oMTrWNJEP750/83iHW7wfaMigIvRvzNLLfryQF8ijoB0OgOIL+ p6m1DQchPAWBha99z8H4nnQxaKKlKFvPIq8cS/h4IbK71RUZMsdkOz2uWDYUqR6OiX8h mRmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ImenvlSZqiGev30iuxYAHjcK6h9wKIIw7n5ZxJIaiEE=; b=OZMYtKPzy6oJmp6GoeqlkOhZBKTECEaZ3vezcNmPNfqIMXWBMN920Bt3ATFczNllmx iulkCCDdnJmk4urZxdd+ji0zAca45RUnTg2hkOlgtLLmsqohB88DCeZMMzENx5NqDZbb 2M2KcXyQRGn8OezYMBFWOObSvSENHVTAHKtU+IS1xk46fBV6JqsVC8HQIa/KoqxNwwKc nNy2WOdQ1eE7mRiaSV2UOWUPTnd3TZsWdfDglg2fjFIW7wpNJh/zdrQXe89a0AH8GjPO WBK65vJvtzCvzNL0kjdZDyDXGJKaTYutmlnnPLJcA/uPEPqu2SqbfbxBiEsup3KcXR7k ArVw== X-Gm-Message-State: AO0yUKX25lINz8y/oB5JqKfoWEm3YWlMDjXoqtCigL6anG2EMx+n/2Gk fPD0NM1QalPOiPawUyg0Ko8S91L24VmZQeski7TlCA== X-Google-Smtp-Source: AK7set9/L7JjIO4yxEh5pQVxm13Hxl0z5wGOlkXzvLASyBLSIuKlydGv98i7nshVimvXehTYwx4AW5qTxPMuo+Zvp5w= X-Received: by 2002:a05:6902:181a:b0:80b:8d00:d61 with SMTP id cf26-20020a056902181a00b0080b8d000d61mr407295ybb.180.1675263355464; Wed, 01 Feb 2023 06:55:55 -0800 (PST) MIME-Version: 1.0 References: <20230201001612.515730-1-andrei.gherzan@canonical.com> <20230201001612.515730-2-andrei.gherzan@canonical.com> In-Reply-To: <20230201001612.515730-2-andrei.gherzan@canonical.com> From: Willem de Bruijn Date: Wed, 1 Feb 2023 09:55:19 -0500 Message-ID: Subject: Re: [PATCH net v4 2/4] selftests: net: udpgso_bench_rx/tx: Stop when wrong CLI args are provided To: Andrei Gherzan Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2023 at 7:18 PM Andrei Gherzan wrote: > > Leaving unrecognized arguments buried in the output, can easily hide a > CLI/script typo. Avoid this by exiting when wrong arguments are provided to > the udpgso_bench test programs. > > Fixes: 3a687bef148d ("selftests: udp gso benchmark") > Signed-off-by: Andrei Gherzan > Cc: Willem de Bruijn Reviewed-by: Willem de Bruijn