Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E80C636CD for ; Wed, 1 Feb 2023 15:25:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbjBAPZP (ORCPT ); Wed, 1 Feb 2023 10:25:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230245AbjBAPZL (ORCPT ); Wed, 1 Feb 2023 10:25:11 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F0701BF7 for ; Wed, 1 Feb 2023 07:25:10 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 983F01EC068D; Wed, 1 Feb 2023 16:25:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1675265108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=xqBD1diBO+309ccHmPR55RkzaJWb/8G+BwdeVmy+Fa0=; b=byuouQVU2TBUXXxu4R+zqyH7vXpeo9m0te0+ejY4bQiG6dsGv4dXrLI21VZoubPd9NCW9W LryDf5o1DAjgeskcqwkKfjuwHJZ0cH59+2RxCF8NO+cwQlczCARfyPfQHhz3+VlWvp7cjn 76dPL4j4oVaeG3hLr1uwEWqGKQ+9tm0= Date: Wed, 1 Feb 2023 16:25:04 +0100 From: Borislav Petkov To: Ashok Raj Cc: "Luck, Tony" , Thomas Gleixner , LKML , x86 , Ingo Molnar , "Hansen, Dave" , "Schofield, Alison" , "Chatre, Reinette" , Tom Lendacky , Stefan Talpalaru , David Woodhouse , Benjamin Herrenschmidt , Jonathan Corbet , "Rafael J . Wysocki" , Peter Zilstra , "Lutomirski, Andy" , "andrew.cooper3@citrix.com" , "Ostrovsky, Boris" , Martin Pohlack Subject: Re: [Patch v3 Part2 3/9] x86/microcode/intel: Fix collect_cpu_info() to reflect current microcode Message-ID: References: <20230130213955.6046-1-ashok.raj@intel.com> <20230130213955.6046-4-ashok.raj@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2023 at 07:13:30AM -0800, Ashok Raj wrote: > If the purpose is only to update the revision, using the collect_cpu_info() > which seems more appropriate for that purpose, collect_cpu_info() is not called "update local revision" so no, it is not appropriate. I can't understand the rest of your handwaving so I'll give you the usual spiel: first, define exactly what the real-life problem is you're trying to solve. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette