MIME-Version: 1.0
References: <20221111093702.80975-1-zhangjiachen.jaycee@bytedance.com> <CAFQAk7isS3AgkU_nMum8=iqy8NgLdGN5USq4gk_TE8SUzRr4tQ@mail.gmail.com>
In-Reply-To: <CAFQAk7isS3AgkU_nMum8=iqy8NgLdGN5USq4gk_TE8SUzRr4tQ@mail.gmail.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Wed, 1 Feb 2023 16:54:21 +0100
Message-ID: <CAJfpegtqGDt4fnDsLtLEhg3ysw5TtfPamJ18TGSpSJve94KNzQ@mail.gmail.com>
Subject: Re: [PATCH] fuse: initialize attr_version of new fuse inodes by fc->attr_version
To:     Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 17 Nov 2022 at 09:52, Jiachen Zhang
<zhangjiachen.jaycee@bytedance.com> wrote:
>
> On Fri, Nov 11, 2022 at 5:37 PM Jiachen Zhang
> <zhangjiachen.jaycee@bytedance.com> wrote:
> >
> > The FUSE_READDIRPLUS request reply handler fuse_direntplus_link() might
> > call fuse_iget() to initialize a new fuse_inode and change its attributes.
> > But as the new fi->attr_version is always initialized with 0, even if the
> > attr_version of the FUSE_READDIRPLUS request has become staled, staled attr
> > may still be set to the new fuse_inode. This may cause file size
> > inconsistency even when a filesystem backend is mounted with a single FUSE
> > mountpoint.
> >
> > This commit fixes the issue by initializing new fuse_inode attr_versions by
> > the global fc->attr_version. This may introduce more FUSE_GETATTR but can
> > avoid weird attributes rollback being seen by users.
> >
> > Fixes: 19332138887c ("fuse: initialize attr_version of new fuse inodes by fc->attr_version")
>
> Ping..., and the Fixes tag should be:
>
> Fixes: fbee36b92abc ("fuse: fix uninitialized field in fuse_inode")

Do you have a reproducer?

Thanks,
Miklos