MIME-Version: 1.0
References: <20230201054522.162611-1-shahuang@redhat.com>
In-Reply-To: <20230201054522.162611-1-shahuang@redhat.com>
From:   Vipin Sharma <vipinsh@google.com>
Date:   Wed, 1 Feb 2023 08:00:00 -0800
Message-ID: <CAHVum0eH_XrrPiviYYWEu=FouhEXeWq1mcx0=BoiF8NaoyVj_g@mail.gmail.com>
Subject: Re: [PATCH] selftests: KVM: Replace optarg with arg in guest_modes_cmdline
To:     shahuang@redhat.com
Cc:     kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Shuah Khan <shuah@kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 31, 2023 at 9:46 PM <shahuang@redhat.com> wrote:
>
> From: Shaoqin Huang <shahuang@redhat.com>
>
> The parameter arg in guest_modes_cmdline not being used now, and the
> optarg should be replaced with arg in guest_modes_cmdline.
>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> ---
>  tools/testing/selftests/kvm/lib/guest_modes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/guest_modes.c b/tools/testing/selftests/kvm/lib/guest_modes.c
> index 99a575bbbc52..1f2dca4520ab 100644
> --- a/tools/testing/selftests/kvm/lib/guest_modes.c
> +++ b/tools/testing/selftests/kvm/lib/guest_modes.c
> @@ -127,7 +127,7 @@ void guest_modes_cmdline(const char *arg)
>                 mode_selected = true;
>         }
>
> -       mode = strtoul(optarg, NULL, 10);
> +       mode = strtoul(arg, NULL, 10);

While you are at it, can you also change strtoul to atoi_non_negative()?

An underflow negative number will print an error message with a wrong
positive guest mode ID not passed by the user.

>         TEST_ASSERT(mode < NUM_VM_MODES, "Guest mode ID %d too big", mode);
>         guest_modes[mode].enabled = true;
>  }
> --
> 2.39.0
>