Feedback-ID: iac594737:Fastmail
Date:   Wed, 1 Feb 2023 11:18:54 -0500
From:   Demi Marie Obenour <demi@invisiblethingslab.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] block: Support creating a struct file from a
 block device
Message-ID: <Y9qQ9i6rNvJWPbV+@itl-email>
References: <20230126033358.1880-1-demi@invisiblethingslab.com>
 <20230126033358.1880-2-demi@invisiblethingslab.com>
 <Y9d692WEX/ZvBhXI@infradead.org>
 <Y9gZAJGgdjFtsm9I@itl-email>
 <Y9jW73uAtE3HdCou@infradead.org>
 <Y9lBlKD3U/jMug9j@itl-email>
 <Y9oYs+KycfdFYlu2@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pHrCnqjgacOmsNWC"
Content-Disposition: inline
In-Reply-To: <Y9oYs+KycfdFYlu2@infradead.org>
Precedence: bulk


--pHrCnqjgacOmsNWC
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 1 Feb 2023 11:18:54 -0500
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] block: Support creating a struct file from a
 block device

On Tue, Jan 31, 2023 at 11:45:55PM -0800, Christoph Hellwig wrote:
> On Tue, Jan 31, 2023 at 11:27:59AM -0500, Demi Marie Obenour wrote:
> > While it is easy to provide userspace with an FD to any struct file, it
> > is *not* easy to obtain a struct file for a given struct block_device.
> > I could have had device-mapper implement everything itself, but that
> > would have duplicated a large amount of code already in the block layer.
> > Instead, I decided to refactor the block layer to provide a function
> > that does exactly what was needed.  The result was this patch.  In the
> > future, I would like to add an ioctl for /dev/loop-control that creates
> > a loop device and returns a file descriptor to the loop device.  I could
> > also see iSCSI supporting this, with the socket file descriptor being
> > passed in from userspace.
>=20
> And it is somewhat intentional that you can't.  Block device inodes
> have interesting life times and are never directly exposed to userspace
> at all.  They are internal, and only f_mapping of a file system inode
> delegates to them or I/O.  Your patch now magically exposes them to
> userspace.

The intention is that the file descriptor is equvalent to what one would
get by first creating the device and then opening it.  If it is not,
that is a bug in one of my patches.

> And it then bypasses all pathname and inode permission
> based access checks and auditing.  So we can't just do it.

Accessing /dev/mapper/control is already enough to panic the kernel, so
presumably only fully trusted userspace can make the ioctl to begin
with.  Furthermore, this only allows a userspace process to get a file
descriptor to the device-mapper device it itself created.

> > blkdev_do_open() does not solve any problem for me at this time.
> > Instead, it represents the code shared by blkdev_get_by_dev() and
> > blkdev_get_file().  I decided to export it because it could be of
> > independent use to others.  In particular, it could potentially
> > simplify disk_scan_partitions() in block/genhd.c, pkt_new_dev() in
> > pktcdvd, backing_dev_store() in zram, and f2fs_scan_devices() in f2fs.
>=20
> All thse need to actually open the underlying device as they do I/O.
> Doing I/O without opening the device is a no-go.

blkdev_do_open() *does* open the device.  If it doesn=E2=80=99t, that=E2=80=
=99s a bug.
In v2 I will add the same access control checks that blkdev_get_by_dev()
does.  Is this sufficient?
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--pHrCnqjgacOmsNWC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPakPYACgkQsoi1X/+c
IsGKyw/9Hs+s8xlrXGrh/7V99Ied9nhGpUllLF37lmssb7at6VDvhQQSI+KqMDWD
NgFet7GmBJlNc7Hd8dJm7aLUxd/i7YqOJMD3vQabso0lTxcOtTZPilfwoqlmmeTn
04C90lumgPgvCiRWkscLU0sNGb0zPxnbOw+jDSAjFfgWJ3ppU+D6gM7nYx09T7fG
q4b6MQhVNRsJ80oo+70/kePnea9+pLJTmH+kSJ7aOEfggp7Zn2F2kZFT7Q+J/ES0
gEUmcuVM6gqRXgfOPxyMDrxorU3kniuhBWeNB8ZtTie8u7ZY+5gEVhvY/gMLurYO
B+DP1noCXsjC4c76dLX5igAznMbRZoSnttAHXqkZ+eV1mN8Vc/B9C5BtL1BDqSne
YoFfPp8XCIZZVKyBQIxmbGHBSb/uQYaCZ3EtYekhftgTp4akrsVyu7aj6U/ivOSz
0HY0nrip3HgaTqSpr138JIX4QsDyE+CFpvqXDOlTNOaVq/jIPMw2EEOOFYjC1nOB
hy/qfiXHwj9ZGEKpMzIzht2ZWhRlPUa7uEui35UpWeSc/Oo6mEa2sqq3sXcTPr6W
npUtkt+qHBs4udmVWahxR7GLmSq403GCRjS6VABu7WKTSV4AVZ/bLDfF73vGRbm6
Iczu88uhIha88Q27yEnEkbszzwRWwPjYS2NqMRo0YUkiIv8ykXA=
=TOo+
-----END PGP SIGNATURE-----

--pHrCnqjgacOmsNWC--