From:   Song Liu <songliubraving@meta.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Song Liu <song@kernel.org>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Kernel Team <kernel-team@meta.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v5] module: replace module_layout with module_memory
Thread-Topic: [PATCH v5] module: replace module_layout with module_memory
Thread-Index: AQHZNgkbMNiiPNNmR0Sa/FwZeHqHYq653d+AgABwqwA=
Date:   Wed, 1 Feb 2023 16:50:47 +0000
Message-ID: <8F559BD9-D7D4-4669-9C87-0582F06E730F@fb.com>
References: <20230201064720.1949224-1-song@kernel.org>
 <Y9o52aAC33YlRueI@hirez.programming.kicks-ass.net>
In-Reply-To: <Y9o52aAC33YlRueI@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xAftoRL8hEKG+EFDPrFImvEkFxr1rBHjyyVZ+UE995Y2TqJ9VWZppro2hY35?=
 =?us-ascii?Q?BpjZrBY/UTg32sUwXUZT9GFJkpAuCzww6Ibi+kyP3RGFvf6b+pe9LFR1Bwhn?=
 =?us-ascii?Q?Ldb+y5LMdNLa/jTdKscTuVqM88cmmbOPzRycOr+0VUpoj+xuQSb+6RoOCB62?=
 =?us-ascii?Q?35FZ7t5TJaumi8iHQv6C66gxolABe1Lg5F2REz4fN9jcyb+5rTfO56re58R/?=
 =?us-ascii?Q?k23nRZvFSJyX83/Lxlu5go/a2d6iHG63l5422DjtS2LwSm2+mx6fpLQGo3F7?=
 =?us-ascii?Q?EoVAZSGpQghZzbQDizjvfkEblL7unWsfFVuGMnc5TWe8kbrWMrxQeoxKJq/L?=
 =?us-ascii?Q?382vEdx1J1iGGw+FyNal40hkAC3RU7dylz8ayYnsXlu4WDAxE67CtOS1c8PR?=
 =?us-ascii?Q?mzfPnW0NNimavlpiYTz2uRX248igOh/03PMzV/csjy/MfMJvkXI0vblBZHv0?=
 =?us-ascii?Q?iLLvaNcJ5otR6aQkEarbm2rVYP2IpANYGxwSOLJ8TISdyMCxWHtnmkWuMmcf?=
 =?us-ascii?Q?1f5rRO/l0F65YN9ZC7c8ablj4lc4gqGTK/dyr1hEg1uGAUuionWVp3LyjbsZ?=
 =?us-ascii?Q?exADaUnLBSIpBqBD2MIiweJMirefyCuRpgh10CXPcPudqR6JjSN+SKuSOv98?=
 =?us-ascii?Q?DPGXp5qDMDs6gJAysBp9xFfwcnSE6axtPBMRG+XJ19HEUALI+oIMBldl0mkS?=
 =?us-ascii?Q?HRXQApnIBln+Eh573lhWwYY9RpTq1bG6V4hOSAq80t6OdUz9O6v8yw6bF3Co?=
 =?us-ascii?Q?ZWVT0gy5Ec0asFsl2RG/c/JZuueZ0E9DFU5XDYxdK7o3diX9ET9lmceOUkMl?=
 =?us-ascii?Q?zkskzvM24UsFJ6DLOwT/LCRJ6lvYhtPtaH0XqeXQ1Voo64uHzT+V4aE5MM92?=
 =?us-ascii?Q?grEapPFkl0nDIgWWNeYsiQyXXy1BN5ixf0MiW4UtWPQGoUr10wgYKEFB++n+?=
 =?us-ascii?Q?vGR7g/IKifeT1AxbWMUIV9EUykFaVThWfaSmuN8aiMONgJtE9EWlxlqh25oq?=
 =?us-ascii?Q?2p1BJuYWNGXRJQb7YtLeiy7fg1r5Pi1fZ2h4Vdlk6VqCDUFYPWckzW6eVAR6?=
 =?us-ascii?Q?TvaCt3cCrJmt1398H1J9ybUrvxRyzEhpwIctKWV6BCIdK5OrVGLvTGzhqpIY?=
 =?us-ascii?Q?HJaynOg0ArGlgrszvcw3RQXIvZmeOO198vlqg2anzULeJ0gH7i3Jqw0434wx?=
 =?us-ascii?Q?c76WhPhtBlCavnGTzVia93S7BNelPCtTw7fTNlrStBFPskS0aZXxc0qBXWt5?=
 =?us-ascii?Q?IJttQXk8cn9Gr2cgM0C/Gt3DRW3f1HD4H0YC55PrOh3dm8z8+HE5WJTEqzTR?=
 =?us-ascii?Q?pQ+zimcQLJETWdCqHXaPb0PjR+77YyBARMBmZMwbc2M8xIS/VcYo7vNAGOoC?=
 =?us-ascii?Q?aXaBcI3otTh6WnnvsmPuWIfoKUkSnDS6eRLUjOJZMf/t5PYmw3iVRrE72daE?=
 =?us-ascii?Q?AxtfF+AOMP5val5KkH6SxCtsxB1c6yqwj81l8R1ml5B/PRivOp4vxwkz63Y/?=
 =?us-ascii?Q?VIs2NUbwY9dPUITav3l7HO68XkZQsu0bRNZND3Uie1YcBrOmOd/p19EHpqpF?=
 =?us-ascii?Q?l43XLuhzUtjx1hEOmmzwdzbxP3DVcXKXg2Iqq2xMs8VisjHpJThvt2eeYHhM?=
 =?us-ascii?Q?+ZE/F/XakI7eJbi+4O4/3+brjnXGuPAcpgbTB4/ilcpo?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6B56A8A3F2C4BF409675286CFF500959@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4bb4083-b9bc-481d-7e0b-08db0474779e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 16:50:47.2181
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VIIPsWSiyCW1Ahdx1W37GK1Z+6C46fBSH74YZFpnPmcNywvENcpZ3RPs+3M+fR6XCiwn+KX00q7/45eUTipDRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR15MB4237
X-Proofpoint-GUID: H2z2WLq2zrTs2rWRCCjGFqnDG45QLko2
X-Proofpoint-ORIG-GUID: H2z2WLq2zrTs2rWRCCjGFqnDG45QLko2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-01_04,2023-01-31_01,2022-06-22_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 1, 2023, at 2:07 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
[...]

> 
> ... you write something like:
> 
> #define for_class_mod_mem_type(type, class) \
> for_each_mod_mem_type(type) \
> if (mod_mem_type_is_##class(type))
> 
> Then we can write things like:
> 
> for_class_mod_mem_type(type, init)
> for_class_mod_mem_type(type, data)
> 
> and
> 
> for_class_mod_mem_type(type, core_data)
> 
> (this last could be used in show_datasize() for example).
> 
> Does that make sense?

It sure does. Let me give it a try. 

Thanks,
Song