Feedback-ID: i51094778:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-107-g82c3c54364-fm-20230131.002-g82c3c543
Mime-Version: 1.0
Message-Id: <b7462a4f-c64e-4517-86f4-574dc1de9612@app.fastmail.com>
In-Reply-To: <20230201124257.7801-1-ecurtin@redhat.com>
References: <20230201124257.7801-1-ecurtin@redhat.com>
Date:   Wed, 01 Feb 2023 18:00:09 +0100
From:   "Sven Peter" <sven@svenpeter.dev>
To:     "Eric Curtin" <ecurtin@redhat.com>, asahi@lists.linux.dev
Cc:     "Dan Carpenter" <error27@gmail.com>,
        "Hector Martin" <marcan@marcan.st>,
        "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
        "Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        "moderated list:ARM/APPLE MACHINE SUPPORT" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
        "open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iommu: dart: DART_T8110_ERROR range should be 0 to 5
Content-Type: text/plain
Precedence: bulk

Hi,

On Wed, Feb 1, 2023, at 13:42, Eric Curtin wrote:
> This was detected by smatch as one "else if" statement could never be
> reached. Confirmed bit order by comparing with python implementation [1].
>
> drivers/iommu/apple-dart.c:991 apple_dart_t8110_irq()
> warn: duplicate check 'error_code == ((((1))) << (3))'
>   (previous on line 989)
>
> Link: https://github.com/AsahiLinux/m1n1/commit/96b2d584feec1e3f7bfa [1]
>
> Fixes: d8bcc870d99d ("iommu: dart: Add t8110 DART support")
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Eric Curtin <ecurtin@redhat.com

You're missing a ">" here but I hope Joerg can fix that when
merging it!

> ---
> Changes in v2: Remove DART_T8110_ERROR_ADDR_HI change
> ---

Reviewed-by: Sven Peter <sven@svenpeter.dev>


Thanks,


Sven