Message-ID: <dfacbc3f-beb3-73f3-7e44-f3d919839d7f@mailbox.org>
Date:   Wed, 1 Feb 2023 18:15:47 +0000
MIME-Version: 1.0
Subject: Re: [PATCH v3 0/6] amd_pstate: Add guided autonomous mode support
Content-Language: en-US
To:     Wyes Karny <wyes.karny@amd.com>
Cc:     Rafael J Wysocki <rafael@kernel.org>,
        Huang Rui <ray.huang@amd.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Mario.Limonciello@amd.com, Perry.Yuan@amd.com,
        Ananth Narayan <ananth.narayan@amd.com>,
        gautham.shenoy@amd.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Bagas Sanjaya <bagasdotme@gmail.com>, santosh.shukla@amd.com,
        Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Borislav Petkov <bp@suse.de>
References: <20230119115017.10188-1-wyes.karny@amd.com>
 <8c09f806-b00d-515b-bd1d-2f433e44b1a4@mailbox.org>
 <20230131053427.cdpg5zaqyxf7ou2f@beas>
From:   Tor Vic <torvic9@mailbox.org>
In-Reply-To: <20230131053427.cdpg5zaqyxf7ou2f@beas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 31.01.23 05:34, Wyes Karny wrote:
> Hi Tor Vic,
> 
> On 24 Jan 20:40, Tor Vic wrote:
> --------------------------------->8-----------------------------
>>
>> The "active" mode seems to be broken here on a Zen2 3900X running Linux 6.1.
>> Frequency remains stuck at minimum which is +-500 MHz.
> 
> I've fixed this in v4.
> 
>>
>> Some queries of the new /sys devices lead to I/O error:
>>
>>    # LANG=C cat /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_*
>>    166
>>    cat:
>> /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_lowest_nonlinear_freq:
>> Input/output error
>>    cat: /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_max_freq:
>> Input/output error
>>
> This issue I'm not able to reproduce. Is this issue seen with only EPP
> patches also?
> Could you please check if this issue still there with v4?

No, it's gone. Could have been a mismerge, I'm sorry.

> 
> Thanks,
> Wyes

Thank you!

> 
>> The "guided" mode seems to work fine with no stuck frequency, but also
>> produces I/O error on some /sys files.
>>
>> I haven't tested "passive".
>>
>> Cheers,
>>
>> Tor Vic