Date:   Wed, 1 Feb 2023 20:47:12 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc:     linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>,
        Hans de Goede <hdegoede@redhat.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux Kernel Functional Testing <lkft@linaro.org>,
        Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH] maple: remove unneeded maple_bus_uevent() callback.
Message-ID: <Y9rBwMf6p6QmkVPp@kroah.com>
References: <20230201125642.624255-1-gregkh@linuxfoundation.org>
 <2f10003fcf3671ccdd285952ba76153f5c2d5307.camel@physik.fu-berlin.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2f10003fcf3671ccdd285952ba76153f5c2d5307.camel@physik.fu-berlin.de>
Precedence: bulk

On Wed, Feb 01, 2023 at 08:05:21PM +0100, John Paul Adrian Glaubitz wrote:
> Hi Greg!
> 
> On Wed, 2023-02-01 at 13:56 +0100, Greg Kroah-Hartman wrote:
> > The driver core recently changed the uevent bus callback to take a const
> > pointer, and the maple_bus_uevent() was not correctly fixed up.  Instead
> > of fixing the function parameter types, just remove the callback
> > entirely as it does not do anything, so it is not necessary.
> > 
> > Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> > Cc: Rich Felker <dalias@libc.org>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > Fixes: 2a81ada32f0e ("driver core: make struct bus_type.uevent() take a const *")
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > sh maintainers, I'll take this through my tree as that's where the
> > offending commit is that causes the build breakage.
> > 
> >  drivers/sh/maple/maple.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c
> > index e24e220e56ee..e05473c5c267 100644
> > --- a/drivers/sh/maple/maple.c
> > +++ b/drivers/sh/maple/maple.c
> > @@ -760,12 +760,6 @@ static int maple_match_bus_driver(struct device *devptr,
> >  	return 0;
> >  }
> >  
> > -static int maple_bus_uevent(struct device *dev,
> > -			    struct kobj_uevent_env *env)
> > -{
> > -	return 0;
> > -}
> > -
> >  static void maple_bus_release(struct device *dev)
> >  {
> >  }
> > @@ -782,7 +776,6 @@ static struct maple_driver maple_unsupported_device = {
> >  struct bus_type maple_bus_type = {
> >  	.name = "maple",
> >  	.match = maple_match_bus_driver,
> > -	.uevent = maple_bus_uevent,
> >  };
> >  EXPORT_SYMBOL_GPL(maple_bus_type);
> 
> Through which tree is this supposed to be picked up?

As the comment below the --- line said above:

	sh maintainers, I'll take this through my tree as that's where the
	offending commit is that causes the build breakage.

So I took it :)

thanks,

greg k-h