IronPort-SDR: HafJkjajxr1VQAEEZsj3UxLHR3XI7euhDvrTN2uz6ow+DR06DtQL0ggVs8dWlJU5xvTtzZfPbv
 al/Uks977tkbajLVoIMGQ7O8eHNu1SrLPRGCfVYfswagvqbe//vrRHVST5KxyvmJmLhZq7qZtq
 OwdEqDg6q9XhP6YnBkVAF/aR6qgfaNb8ll75vziZr0Cl+48NhTjyDzxI/LZD3Zbvq1rswkAaCI
 Frz2Zeksi54w6QZ3qKll6b5aAIadmhrF8gd8xDe9L/Sv9MakNLmZNtKnzu7HyArGpir7X9szWM
 LA4=
IronPort-SDR: u9W9PsjArgFd61KGPAVTbaDgbwTue9mq0OnM4yLoOxLdaDh9hDVnz0bCp5YWWPo6D9kJAGtwtH
 TLvGWdBbX9nDRTdSk0Ahtl27gipFdWfyAQDvC6j4i52RCsYg57l3F7Q+XMMjqp2uUW7Mr7IQ4S
 0ZrZZkPDFZptqCcs24Vx7n4jdajzxSJEKggOuhvT39fLkuQ5410g618H4VVpO90rGBPdz6tWxL
 2Tg6ue+9ZldGg+DCkVgrNvYXuqcUZBYgOCeklpEJoP38MPrpK9ioMrNjfOvkUR0NYL9T2lOXlA
 saA=
WDCIronportException: Internal
Message-ID: <7cf17a27-13dc-e6b4-c34c-47454239af30@opensource.wdc.com>
Date:   Thu, 2 Feb 2023 06:06:25 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver
 void returned
Content-Language: en-US
To:     Dawei Li <set_pte_at@outlook.com>, mpe@ellerman.id.au
Cc:     npiggin@gmail.com, christophe.leroy@csgroup.eu,
        linuxppc-dev@lists.ozlabs.org, linux-ide@vger.kernel.org,
        netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <TYCP286MB232391520CB471E7C8D6EA84CAD19@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <TYCP286MB232391520CB471E7C8D6EA84CAD19@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/1/23 23:36, Dawei Li wrote:
> Commit fc7a6209d571 ("bus: Make remove callback return void") forces
> bus_type::remove be void-returned, it doesn't make much sense for any
> bus based driver implementing remove callbalk to return non-void to
> its caller.
> 
> This change is for macio bus based drivers.
> 
> Signed-off-by: Dawei Li <set_pte_at@outlook.com>
> ---
> v2 -> v3
> - Rebased on latest powerpc/next.
> - cc' to relevant subsysem lists.
> 
> v1 -> v2
> - Revert unneeded changes.
> - Rebased on latest powerpc/next.
> 
> v1
> - https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/
> ---
>  arch/powerpc/include/asm/macio.h                | 2 +-
>  drivers/ata/pata_macio.c                        | 4 +---
>  drivers/macintosh/rack-meter.c                  | 4 +---
>  drivers/net/ethernet/apple/bmac.c               | 4 +---
>  drivers/net/ethernet/apple/mace.c               | 4 +---
>  drivers/net/wireless/intersil/orinoco/airport.c | 4 +---
>  drivers/scsi/mac53c94.c                         | 5 +----
>  drivers/scsi/mesh.c                             | 5 +----
>  drivers/tty/serial/pmac_zilog.c                 | 7 ++-----
>  sound/aoa/soundbus/i2sbus/core.c                | 4 +---
>  10 files changed, 11 insertions(+), 32 deletions(-)

For the ata bits:

Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research