Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62E2C05027 for ; Wed, 1 Feb 2023 21:19:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbjBAVTD (ORCPT ); Wed, 1 Feb 2023 16:19:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjBAVS6 (ORCPT ); Wed, 1 Feb 2023 16:18:58 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDAD36F216 for ; Wed, 1 Feb 2023 13:18:57 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id n2so13540964pfo.3 for ; Wed, 01 Feb 2023 13:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=F3Si1tu8Y5DMEWT7C6ejyq5oRsygCb4wYMBHPF2K2lA=; b=SW5j2FTMCq4xN/ZHt8opiZ+KLLwOWAJ2FnVwcGrxqL1LQjt4qD+GAWqwZW6er0NX2O Pdtc9A5zDHYYC2x0fjlAHZlSJqUjKGIh8CxzCeK+CObDVQzhduFhHLbErmg/T8Aueed/ KozoCFOGKaqhpemc7wgDLauGzMe0PV2oK6Z3db1qldLWQnxiPv1LyaZCvvtPz0zZ+DR6 m6/qAnPgfuV8ddKoYakO7sMiOyjb+O4RVeOPhNdyGgs+1/k5oXwIGkVaCVqpwBZtoVoO GyFmg4o8F2FGuwNlMFsUf7bBc+s2DVTtiexVEUQDNn8n8a6mB1aApdyWzbufQBf8UM15 bvlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F3Si1tu8Y5DMEWT7C6ejyq5oRsygCb4wYMBHPF2K2lA=; b=d1u4TrfhczPZ7/UjF+QFwJZfEKgLbQHG51XLKpalR7qSR6ks3wyp5IZChQvi+dQ+0A /sVmsog0LVtN1N7p/m8q76G3ZwJ+GIl4/U+s/fbDWI+fgVG7SJ69gA1V1rSRYockSvO+ 62LQK0tM5JpSORWaJXN2DIJWV/UjBPnuiqmcskoLZPZBOjZ5QtfLfT+7ikC7su2eelEr W2Yakyw7ex3XE3ETwltdHA8Ndaja5CNFVnUgAdCuLWFonugvURfQPjzk5DK/wHroi+9K Nj3dT9Jso6K1wS4HfHWjlDNaS3k7ch7I0DCwwqBlJXDtodGFXjXTlQnXAg8d5VkUEsW8 phfA== X-Gm-Message-State: AO0yUKX3jC8LbXokgNkqywRApZemg73VzyXSevIDC2aQvOl1Op49ehJx aCpJZo0MJVKWPKk3qwq9j5uu3H7W0abiFNbUrtbU0i3ZPllCz+E= X-Google-Smtp-Source: AK7set8KFiT3geprutCvgeL1UVJzcV0oWaLCKtVMWA4z7XEEhBP6lnqjZbY8983tNJa3ZMbsaFJBUBd95GbvabSseFU= X-Received: by 2002:a05:6a00:bd1:b0:593:b491:40ba with SMTP id x17-20020a056a000bd100b00593b49140bamr914989pfu.7.1675286337234; Wed, 01 Feb 2023 13:18:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul Moore Date: Wed, 1 Feb 2023 16:18:46 -0500 Message-ID: Subject: Re: [PATCH v2] io_uring,audit: don't log IORING_OP_MADVISE To: Richard Guy Briggs Cc: Linux-Audit Mailing List , LKML , io-uring@vger.kernel.org, Eric Paris , Steve Grubb , Christian Brauner , Stefan Roesch Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 1, 2023 at 3:34 PM Richard Guy Briggs wrote: > > fadvise and madvise both provide hints for caching or access pattern for > file and memory respectively. Skip them. You forgot to update the first sentence in the commit description :/ I'm still looking for some type of statement that you've done some homework on the IORING_OP_MADVISE case to ensure that it doesn't end up calling into the LSM, see my previous emails on this. I need more than "Steve told me to do this". I basically just want to see that some care and thought has gone into this patch to verify it is correct and good. > Fixes: 5bd2182d58e9 ("audit,io_uring,io-wq: add some basic audit support to io_uring") > Signed-off-by: Richard Guy Briggs > --- > changelog > v2: > - drop *GETXATTR patch > - drop FADVISE hunk > > io_uring/opdef.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/io_uring/opdef.c b/io_uring/opdef.c > index 3aa0d65c50e3..d3f36c633ceb 100644 > --- a/io_uring/opdef.c > +++ b/io_uring/opdef.c > @@ -312,6 +312,7 @@ const struct io_op_def io_op_defs[] = { > .issue = io_fadvise, > }, > [IORING_OP_MADVISE] = { > + .audit_skip = 1, > .name = "MADVISE", > .prep = io_madvise_prep, > .issue = io_madvise, > -- > 2.27.0 -- paul-moore.com