Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D026C05027 for ; Wed, 1 Feb 2023 21:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231302AbjBAVum (ORCPT ); Wed, 1 Feb 2023 16:50:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjBAVuj (ORCPT ); Wed, 1 Feb 2023 16:50:39 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 277264C1E; Wed, 1 Feb 2023 13:50:37 -0800 (PST) Received: (Authenticated sender: didi.debian@cknow.org) by mail.gandi.net (Postfix) with ESMTPSA id 7B04F240008; Wed, 1 Feb 2023 21:50:32 +0000 (UTC) From: Diederik de Haas To: Carsten Haitzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: [PATCH 1/2] perf test: Replace 'grep | wc -l' with 'grep -c' Date: Wed, 1 Feb 2023 22:49:44 +0100 Message-Id: <20230201214945.127474-2-didi.debian@cknow.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230201214945.127474-1-didi.debian@cknow.org> References: <20230201214945.127474-1-didi.debian@cknow.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To count the number of results from grep, use the '-c' parameter instead of piping it to 'wc'. See also https://www.shellcheck.net/wiki/SC2126 Signed-off-by: Diederik de Haas --- tools/perf/tests/shell/lib/coresight.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/tests/shell/lib/coresight.sh b/tools/perf/tests/shell/lib/coresight.sh index 45a1477256b6..7e27e5c5bc9c 100644 --- a/tools/perf/tests/shell/lib/coresight.sh +++ b/tools/perf/tests/shell/lib/coresight.sh @@ -58,9 +58,9 @@ perf_dump_aux_verify() { # compiler may produce different code depending on the compiler and # optimization options, so this is rough just to see if we're # either missing almost all the data or all of it - ATOM_FX_NUM=`grep I_ATOM_F "$DUMP" | wc -l` - ASYNC_NUM=`grep I_ASYNC "$DUMP" | wc -l` - TRACE_INFO_NUM=`grep I_TRACE_INFO "$DUMP" | wc -l` + ATOM_FX_NUM=`grep -c I_ATOM_F "$DUMP"` + ASYNC_NUM=`grep -c I_ASYNC "$DUMP"` + TRACE_INFO_NUM=`grep -c I_TRACE_INFO "$DUMP"` rm -f "$DUMP" # Arguments provide minimums for a pass -- 2.39.1