Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A683C05027 for ; Wed, 1 Feb 2023 21:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231371AbjBAV7D (ORCPT ); Wed, 1 Feb 2023 16:59:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjBAV7B (ORCPT ); Wed, 1 Feb 2023 16:59:01 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F0D8721D2; Wed, 1 Feb 2023 13:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=W9SUVgiDKQB3AC/th2+dgOo9sEGOeO1QB0KsbOvXuNU=; b=f6ZmReIRFRtjB1AnNOXtDIwaeK c7qOV9R32cxAtqpIpiIz0DHkdSm96IK5+6ev1OHxY8pAMQnP7ev5pj1WVjXjYE1NWRd3Zhc/jPnXP bINdWbwQ+1gv5G2/ditLHAIk94XamrBX0V8I6wE8kwAzf3ztDq7kM7IcC5ozCIRLkt3o=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pNL7t-003q5U-1L; Wed, 01 Feb 2023 22:58:45 +0100 Date: Wed, 1 Feb 2023 22:58:45 +0100 From: Andrew Lunn To: Dmitry Torokhov Cc: Wei Fang , Jakub Kicinski , Arnd Bergmann , Shenwei Wang , Clark Wang , NXP Linux Team , "David S. Miller" , Eric Dumazet , Paolo Abeni , Marc Kleine-Budde , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] net: fec: restore handling of PHY reset line as optional Message-ID: References: <20230201215320.528319-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230201215320.528319-1-dmitry.torokhov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2023 at 01:53:19PM -0800, Dmitry Torokhov wrote: > Conversion of the driver to gpiod API done in 468ba54bd616 ("fec: > convert to gpio descriptor") incorrectly made reset line mandatory and > resulted in aborting driver probe in cases where reset line was not > specified (note: this way of specifying PHY reset line is actually > deprecated). > > Switch to using devm_gpiod_get_optional() and skip manipulating reset > line if it can not be located. > > Fixes: 468ba54bd616 ("fec: convert to gpio descriptor") > Signed-off-by: Dmitry Torokhov Reviewed-by: Andrew Lunn Andrew