Date:   Wed, 1 Feb 2023 14:19:43 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Stefan Talpalaru <stefantalpalaru@yahoo.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Peter Zilstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Andrew Cooper <Andrew.Cooper3@citrix.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Martin Pohlack <mpohlack@amazon.de>,
        "Li, Aubrey" <aubrey.li@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch v3 Part2 1/9] x86/microcode: Taint kernel only if
 microcode loading was successful
Message-ID: <Y9rlfzcVlH/AMgvj@a4bf019067fa.jf.intel.com>
References: <20230130213955.6046-1-ashok.raj@intel.com>
 <20230130213955.6046-2-ashok.raj@intel.com>
 <Y9kAlKFfdek2rq6g@zn.tnic>
 <Y9lHDWjjnqdletL3@a4bf019067fa.jf.intel.com>
 <Y9l4FdvytLqMc3jm@zn.tnic>
 <Y9mcCxYK/VPB0ATM@a4bf019067fa.jf.intel.com>
 <Y9perwfaheZqAJWl@zn.tnic>
 <Y9reDitxHgzcrsOY@a4bf019067fa.jf.intel.com>
 <Y9riTY4KOK+6tMt5@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y9riTY4KOK+6tMt5@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6HXtF5VOnKIGuNbrFD4skdKFcbjpKEGKEtdUV+5+hUZR0T6BG6HYduGHUVq3?=
 =?us-ascii?Q?FWzm9SoftVVqP5Y3wFwwEPtm7iZSBSnEMI73wOnVbnvcaF0snbjL6OMrOXdw?=
 =?us-ascii?Q?eZ7EzNpsaGJwIVkDxOjpTOneQSejggCC51U/9rP9uWRT91jODOAJeOQBlHjG?=
 =?us-ascii?Q?Vqrw/XUwRww65cHXf453wnPH8nsg0itOFYJhhQjtXZkaC+WjBr59xI2uYJDS?=
 =?us-ascii?Q?cO95tJpg9Y0juMuoR0alG7UbAqd7+EUXeX6WwWUhSZw7sPgu2CaRhsRp8Ob4?=
 =?us-ascii?Q?C0EVHQRgON+WcP9TW4ex82a5JpFdjjNm8QyYtdvkNJ2ddGF2gDJ1s0e88YU0?=
 =?us-ascii?Q?aB2UwA777fe95xckQ2HRbGgp7wrhgo2rx56CuLn84xzBzkPk+kpbEBcIlv8D?=
 =?us-ascii?Q?HLuxTKY3nmvP7k+3vxvnrrmCOM8Cvu+RFidQvBUx04FhVox+m61gCk+eno9C?=
 =?us-ascii?Q?IQeB7iWk3E7vF1c9R87YQ5/ZEbhPPbPQQIKZS3QKkQdh+Ce/4fWa7vAqAYTi?=
 =?us-ascii?Q?G8kPKHConaoa/9R//mI+onkBLeMrwa28fD4qy9IwQWCVcc8+KTpA3e1R2uwq?=
 =?us-ascii?Q?9BsSJ0ML7+YFxTVbfVY//wvPS/QgVaFzddNdafkIhzprhOib5wz+WonUReTy?=
 =?us-ascii?Q?U0oUIZ8psikdV//6ewiDS7tML2GXP0KjznJ5mhlkikPKGIusq6zEJD4bBGjl?=
 =?us-ascii?Q?iMSYM/wKzlJYX+XCUT3sFZe75P0kKtdXRS8OGSIUPpJmUJFlWrtsAUryvhkr?=
 =?us-ascii?Q?pXkE2xlTUPVaSuGZsk7Yt5CJ+uHPbZ37efbRyR4HAurYlaUiyv0aK0B44DQx?=
 =?us-ascii?Q?CQPHa5sTseUU3kcWUgTZCroiVekkkYqyQlCTWt+GDEelyY2l7xTyl3CqLP1T?=
 =?us-ascii?Q?SpaMj3MWsu6xdb9Kp6VybuZ7z3NjTAw6lIVgX9ht5ZDyl6gkaW97/5fU+l8m?=
 =?us-ascii?Q?oLLbtkVedtTy+RGFtEJOwJg7nQSV5CJJhwwVpA9Llhu36CuezltlE/ocvrLC?=
 =?us-ascii?Q?tqRy5P2lLUR8EiklUUM7EzHhS8RDP6h2Hxebk6rUXI3ssoPxD6y/Evfw2S0U?=
 =?us-ascii?Q?Ak2s4LTWL57HwLBAPx0RXn/jg9L31GnAp45dpexoNg9pvb5Yhb+oiLT5ndEZ?=
 =?us-ascii?Q?xfmoQA3yCwj6Q8y+1IpV9JfOZaW5H3ZLuKIc8VsD7Y626vhd+L+Nfhq/oljY?=
 =?us-ascii?Q?9Hd+uN5CDZ/nxsiqe8JNpPR09QUQ4NTo9Ys2fE9KfB2cXGtzvfxzojs1FEn8?=
 =?us-ascii?Q?Xu9Rk7Hm7oHzs/lo0a/ESxtzOE6DpDoSgOybNp6DiC/LSBOQlqrCL4E0kUUK?=
 =?us-ascii?Q?K8eb1fzJHkL1ig2b4FUEZwKKC0jNtgVj7EUcbemRrmsywjfriF9ZDtHpUUwA?=
 =?us-ascii?Q?Ek/uioO0XoRcn8V7hJX44eXaVs6WuSmxY9SL9F8iTGHD9a+8qjx+oryE2bSD?=
 =?us-ascii?Q?WgN/SIybyH01Uni5yKHzhI2gzVyeLbMMEEuGUR8+yHkZCRulpMuh9aMiiwUj?=
 =?us-ascii?Q?MMszOnmFMQIYOGzIcSLCA4vKcn+/m1r4c8w9WbVVBd1FEKJgZ6mmpasyT4Gx?=
 =?us-ascii?Q?63si+g6N2Q6JVFmZ8tyAhwRO8mr3r53WPV/scEuCQRMqW3iijvUT7U5d2CB+?=
 =?us-ascii?Q?oA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 50c8d0b1-39ff-4b5d-9c13-08db04a27fc0
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 22:20:18.0255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mzk9ekgPukOXTeolZFLeorQOZNXVj7BTTpXD6CyUrVLTkC16SHg8OeboEkA7Wd/d+JmxFiExIOwUdfLu5zq8Yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7454
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 01, 2023 at 11:06:05PM +0100, Borislav Petkov wrote:
> On Wed, Feb 01, 2023 at 01:47:58PM -0800, Ashok Raj wrote:
> > While reworking I thought while at this, there is a chance to fix other
> > things.
> 
> Your call. The more you're "fixing" other things, the longer it takes
> for your minrev thing.

My original patch for minrev was 4 patches :-)

But when Thomas finds all the other cleanups, it turned into 9. And now
stuck in review.. 

I expected the change from apply_microcode() -> collect_cpu_info() to
be straight forward..