From:   Song Liu <songliubraving@meta.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Song Liu <song@kernel.org>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Kernel Team <kernel-team@meta.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v7] module: replace module_layout with module_memory
Thread-Topic: [PATCH v7] module: replace module_layout with module_memory
Thread-Index: AQHZNm1FE2ZdhJK2y0iTaXPlD6FODa66micAgAAR1YA=
Date:   Wed, 1 Feb 2023 22:28:01 +0000
Message-ID: <BBCAAD9D-245A-4068-B7C7-01DA4E02261C@fb.com>
References: <20230201184422.2932156-1-song@kernel.org>
 <Y9rYcvPx4MhA+c+u@hirez.programming.kicks-ass.net>
In-Reply-To: <Y9rYcvPx4MhA+c+u@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?790JIULRrvuthA6SDWSd6dJ3XPYzy680Lljj4pS1pBhOPUQdCergoOYLxsSA?=
 =?us-ascii?Q?1fGkrVk2zFQSbTRHBpBHuGotSTj41IsBqJWEiJ7gpikPawJL/Xp4+EE+P7N5?=
 =?us-ascii?Q?yzBQJy2YjQiCqSJVPNrHS9RPNFb5gxN4X/a3+g5bF9K+zz8jibOhMvtxLs8G?=
 =?us-ascii?Q?godyVmxLX+1VBG1ZqRKfDvrrwvtq2axxlqR3JU8VuNoH0w2TNxws7TSosBwt?=
 =?us-ascii?Q?Ak+6jV2oHb9XssjFBM+8TzmEn02VmQLwSKDkP4f7U4UxA+InlhCW0o3wzepK?=
 =?us-ascii?Q?Cyw4LCKk3xWNXHjPS/jRVCQj5VZD1kOpUKSRMjxJOe3uO4E0+zjgpryg4zcc?=
 =?us-ascii?Q?+6PdDGb4fSVBg0h51KB+oBl9+n4L89Gj0qHvYvIDAwWYFdB5+Efca+GaJVIi?=
 =?us-ascii?Q?fPbzTM1t+9va5FscrVVLs+9rE49rAMF8kP6mvTM2XRv4pOQY7gXA+0Ak0NvP?=
 =?us-ascii?Q?LrmW4ve+NfdED5pDEJvEL9nz3nYrOV/rluJrfMSMglCVUETiYprOrnUljybp?=
 =?us-ascii?Q?9b4UD5WfasE7b59xgXAMLLvVeeVk98Xpru0bUllNcY5YwaMr4gMO/swc0Ayn?=
 =?us-ascii?Q?m8A4eCtjlQ2bzwXFl35+iN6F6wjyr1eDOnDulcLqfFtvF2oYGCUaLdV4wKjY?=
 =?us-ascii?Q?vc9FMQ2fasVipPsMXf2xRuUDKUfzlRuMELEKP2WUo/rJX+0tvYCU6+8OjMh+?=
 =?us-ascii?Q?TdYGUXmW+NwvDjTMk/APTZ9ePOr/Q8zsSd0tKTsq+mjxf99od+XIG+B/1nXw?=
 =?us-ascii?Q?3XrTDaOMQ+gD3XattwmDmNUy/PBjShvNiyhDmmbvw1KFqZkQPKVxzjwuuKLo?=
 =?us-ascii?Q?3dBl+l/fbKXun7qm3LY1NhNfOzr0y/lRVrvGGXEaWOVNLyAbsUsDSw6+4M8m?=
 =?us-ascii?Q?z26Hq6sy7ua2xW+YO/2taqnFFxQUmssRlrN+Cv4/T0BEvs+S+vA9uch1liT/?=
 =?us-ascii?Q?wWDTkOvlUO2c15BGhGjAcEPIGAzPuXOtD7QNv05eAbSiuQM1mjeLxRImMN17?=
 =?us-ascii?Q?Zx9KiBIpkXYYQ59MSgnOcdHEXomb+Lz34c2/B9lObkUqmKOtU9d+U4tU7EGL?=
 =?us-ascii?Q?eGU4jBF+fU+Zz191GRSqhwQZdRrJkmZ/cJa/ZCjbP+XjuoK+dT76kAdjksIx?=
 =?us-ascii?Q?+Q5JNqajkmou9prZONgTsCQXKZ7l6araZYpcKzHFB8r9T0ku0Bkq4h+iz9Sx?=
 =?us-ascii?Q?z5CCjZEFCn458/2uynvvJTfxFumMRjQTzj5bUhfvs+mamTi7y7Jstoq6ibcY?=
 =?us-ascii?Q?9xE/5wfSSY7IoZzlrXV3Rnw6qX4M1UNkDriJ4HymEPHzWEtKxArYtAhdvzFd?=
 =?us-ascii?Q?lbAdo5oCR/9PXTXwqlPGApkRZvG9BM9knt1n0Am07cbr4VKkLLQze0LtFO8S?=
 =?us-ascii?Q?zf8f47u3Z0Xgjo6ffoyHhoORaQ6Hjp/jhUasJBPpQ4opfiFEWT8myvmBHMgG?=
 =?us-ascii?Q?bpqKf/nSYIHp8phHPh62Gr3lkHZtdnVc3w+MJDtlmRkAF826s+DXAsbvADFz?=
 =?us-ascii?Q?RSqpvhnI+Q7cwB5XRnWHOwdESuUWXVMu3SnTB+JybQRL4+6PG3F0q9jNc0vN?=
 =?us-ascii?Q?R6GpjT8FooSLQ4WtCAMttHdhQCAOVHY9PHSnZM3A1rMxGcCWF3qk56QKUTpM?=
 =?us-ascii?Q?qmzO2iYs16o+fXwu1wduRCdCBLp2Bhvx/ljn8E3DpFP5?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3C01A47D8EC90B41B3D7DED8A0E93C1B@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd03d6e1-3d71-47fa-7a74-08db04a39465
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 22:28:01.8603
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: il03Z9kXh29ZRX2OavxaeNZAmqNnui3n889r6bd7O+a7nvkKykIZrbzbQWqDpNypmYgBjBFP7bussfbCzJ0DoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR15MB5490
X-Proofpoint-GUID: 0D_YUblXRWxaF6mDH_e2vTHJdOMfgq8t
X-Proofpoint-ORIG-GUID: 0D_YUblXRWxaF6mDH_e2vTHJdOMfgq8t
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-01_04,2023-01-31_01,2022-06-22_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 1, 2023, at 1:24 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Wed, Feb 01, 2023 at 10:44:22AM -0800, Song Liu wrote:
> 
>> static ssize_t show_datasize(struct module_attribute *mattr,
>>     struct module_kobject *mk, char *buffer)
>> {
>> - return sprintf(buffer, "%u\n", mk->mod->data_layout.size);
>> + unsigned int size = 0;
>> +
>> + for_class_mod_mem_type(type, core) {
>> + if (type == MOD_TEXT)
>> + continue;
> 
> isn't this the same as:
> 
> for_class_mod_mem_type(type, core_data)
> 
> ?

Great catch!

> 
>> + size += mk->mod->mem[type].size;
>> + }
>> + return sprintf(buffer, "%u\n", size);
>> }
> 
> 
>> - lockdep_free_key_range(mod->data_layout.base, mod->data_layout.size);
>> + for_class_mod_mem_type(type, core) {
>> + lockdep_free_key_range(mod->mem[type].base,
>> +       mod->mem[type].size);
>> + }
> 
> Why the core_data to core change? Specifically the difference seems to
> be you now include text. Now, we shouldn't be having lockdep keys in
> text, so it's harmless, still a bit weird.

Will fix!

Thanks,
Song