Date:   Wed, 1 Feb 2023 22:53:13 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Diederik de Haas <didi.debian@cknow.org>
Cc:     Carsten Haitzler <carsten.haitzler@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Script style improvements in lib/coresight.sh
Message-ID: <Y9sXiRPNoo03YRyq@kernel.org>
References: <20230201214945.127474-1-didi.debian@cknow.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230201214945.127474-1-didi.debian@cknow.org>
Precedence: bulk

Em Wed, Feb 01, 2023 at 10:49:43PM +0100, Diederik de Haas escreveu:
> These 2 patches improve the efficiency and quality of the
> lib/coresight.sh script.
> 
> The first one uses grep's `-c` parameter to count the results instead of
> piping it to `wc -l`.
> The second one replaces the use of backticks (`...`) with $(...) as the
> former has several potential issues while the latter does not.
> 
> Diederik de Haas (2):
>   perf test: Replace 'grep | wc -l' with 'grep -c'
>   perf test: Replace legacy `...` with $(...)


Thanks, applied.

- Arnaldo