From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
        "David S . Miller" <davem@davemloft.net>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: [PATCH-next] crypto: aspeed: fix type warnings
Thread-Topic: [PATCH-next] crypto: aspeed: fix type warnings
Thread-Index: AQHZNrHmMT+Cp3JQVkSaFLeXTAj48q66+kKAgAAC+UA=
Date:   Thu, 2 Feb 2023 03:23:29 +0000
Message-ID: <TY2PR06MB321395387369059BC9F9722E80D69@TY2PR06MB3213.apcprd06.prod.outlook.com>
References: <20230202025600.2598548-1-neal_liu@aspeedtech.com>
 <Y9spg/66x/wQ3x+g@gondor.apana.org.au>
In-Reply-To: <Y9spg/66x/wQ3x+g@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8PCUFn4sd/VatAIX9SBDGXf7XzkHlvKE6OzmpffNU+12qfsRQZKL6afX3lFY?=
 =?us-ascii?Q?Xkd6mZfTvc/f99vB2Y30EgfvniElIOxDe6d8qY1lXqWtdYpIubDNR7dYhz6q?=
 =?us-ascii?Q?b3ebSg/9BG0VsvSkX0pGPxxg8T1iNr8kIIfzxIWSa5262S0f9Yi6eqWSXptw?=
 =?us-ascii?Q?w14/F46iqbmFc71gUDeJOqi30D4N0tE1ox4Ckl4fk/WOpAHv8Tn3upGr1Sxy?=
 =?us-ascii?Q?9+xXk8mA3qR+cJhxsuajsPqvD1HRsFnLn9hJ0i9/Ei4YFKbyBqgXEzJgWK2f?=
 =?us-ascii?Q?jaIqa/0303YzaiDwdS0irQF/Yi/qbHdx5aSUhUy0i1rV1v/XA5drRykHiECe?=
 =?us-ascii?Q?w6B15jJC5RtGqPcozX+cZAIlYII1JUus1VlKx63OYChDfKdn7u5lvXV1zFNN?=
 =?us-ascii?Q?s2NbluvJtmTYUaa235WpmL8nBgY2EataXxQ2pMJ8YsRDrYmBXFxF9vUsrHyg?=
 =?us-ascii?Q?zwLedVBSZcVp3W0/3I9b5jLpfiR10YlcPLYJiLWkZleyfeORTg36wsOnBP21?=
 =?us-ascii?Q?1PAbFUxHNxiYruIpi79u/p8rc68Ucsq9QSnneh1PaLRu3IwHH54RCNUhEVtq?=
 =?us-ascii?Q?14JuKBXW8b7IkcjH1OaxUUe125B9CXAL7wEszxdzot1CJro3UiNxdhaBZ5rL?=
 =?us-ascii?Q?+okukk9+9dMDfFBZTR6hXXJ2RPZBFTleRS5aMoW0NzY/naom6ee4+1xWRtB1?=
 =?us-ascii?Q?l08UUwr/26jssDQJ2CV1UA4sfGTE67hy05tAliEeXB9EDderWsU6R1iSZA38?=
 =?us-ascii?Q?gdHB9/8ndokSFDycSTahCKbMCH6zZb7EckYkKa966LOPnzOLu0A16zKpKfT7?=
 =?us-ascii?Q?gWTvd+L0whi3qpmKlFuRMhME3UzHrqG3XzZFzw+cin440/EWZdz2Ynfrtar+?=
 =?us-ascii?Q?tER4Gx92HK5W4tmPHYQOzykcI5ykFYsu1ZqwXtWqTlAtFatnZ+DC7BqOFw2b?=
 =?us-ascii?Q?rwAqyYhOXqFaFv9xsW/fPfFK/fvRnyR3GeACXd5hCXrr0jCA6WbOQLR9Zgrf?=
 =?us-ascii?Q?YBgQPM7SZNPWeeIW0+nyRDJf7Vsi7DSD3DtRds+55TvmhVHXS3L633TQi8f+?=
 =?us-ascii?Q?3ZlwEzpn2qSKsI8CLB1D3KOz/C8uDoMFrZP/JB2HP2bLtwCCsavCG3i522Ip?=
 =?us-ascii?Q?pUsaYiELs+my32uBcGHjmKrkmhzxcJz7+d6tJ3V31UCBau5XyavZfhqeYqom?=
 =?us-ascii?Q?z83qpEOGJ6dn0BVDLIKZ3Rdkid/67InjfgSxx6zC1IfDXnHEzSjvujBCUGC9?=
 =?us-ascii?Q?RZ/JmWjzaES5aL74Xqb8coai1ybsFoBLucyYk/owVW0CsjFyxu1KAGt+JmjR?=
 =?us-ascii?Q?5xakPsXJ3BtrDibn3+6DOxPjj0fYIup4GsEKHK6ecQsY5ZOpKVL4H/0INScr?=
 =?us-ascii?Q?z2EK9UmLzMHG5Dictyn5u1DpNEUToIUjOAs5i7AsK9i2zKNfnH1c4AzFRZEM?=
 =?us-ascii?Q?lG0ClmuSayV7d254dkN7Su14FnkfTcPn2cesIz+qBWgJWSvm/+fSZ7OBKE2k?=
 =?us-ascii?Q?q0porg3QeY0o3IobvNVuZS/XtJNUSP/vxM8PB2eyX0wm16YBJBCpB9zBBs/y?=
 =?us-ascii?Q?tak2m+tYvXBGvD7gn6zn0tlwfOkpavp1KhZZL5w8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3213.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5352615a-824d-44e8-fc79-08db04ccdb12
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 03:23:29.7726
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WO4TWgfL9PfALmP+9B0sBPWj+t7yM5vxrm9FBqckMaAyb9OECeNI02Qys9twSa2Fhf8rQ7xb3QoT2YzOyXtAkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4559
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Thursday, February 2, 2023 11:10 AM
> To: Neal Liu <neal_liu@aspeedtech.com>
> Cc: Joel Stanley <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; Davi=
d
> S . Miller <davem@davemloft.net>; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> linux-crypto@vger.kernel.org
> Subject: Re: [PATCH-next] crypto: aspeed: fix type warnings
>=20
> On Thu, Feb 02, 2023 at 10:56:00AM +0800, Neal Liu wrote:
> >
> > @@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct
> > aspeed_acry_dev *acry_dev, void *buf,  static int
> > aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)  {
> >  	struct akcipher_request *req =3D acry_dev->req;
> > -	u8 *sram_buffer =3D (u8 *)acry_dev->acry_sram;
> > +	u8 *sram_buffer =3D (u8 __force *)acry_dev->acry_sram;
>=20
> Wouldn't it be better to keep the iomem marker and then use readb on
> sram_buffer?
>=20
This way works too.
I cannot tell which way is better. Do you prefer to keep the iomem marker?
Thanks

-Neal